Added unit tests for the open mcs nrefactory related bugs. We should

ensure that mcs doesn't regress there.

ICSharpCode.NRefactory.Tests/CSharp/Parser/Bugs/ParserBugTests.cs

@@ -0,0 +1,327 @@
+// 
+// ParserBugTests.cs
+//  
+// Author:
+//       Mike Krüger <mkrueger@xamarin.com>
+// 
+// Copyright (c) 2012 Xamarin Inc. (http://xamarin.com)
+// 
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+// 
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+// 
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+using System;
+using NUnit.Framework;
+using ICSharpCode.NRefactory.CSharp;
+using System.Linq;
+
+namespace ICSharpCode.NRefactory.CSharp.Parser.Bugs
+{
+	[TestFixture]
+	public class ParserBugTests
+	{
+		/// <summary>
+		/// Bug 4252 - override bug in mcs ast
+		/// </summary>
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug4242()
+		{
+			string code = @"
+class Foo
+{
+
+    class Bar
+    {
+          override foo
+    }
+
+    public Foo () 
+    {
+    }
+}";
+			var unit = CompilationUnit.Parse(code);
+			var type = unit.Members.First() as TypeDeclaration;
+			var constructor = type.Members.Skip(1).First() as ConstructorDeclaration;
+			var passed = !constructor.HasModifier(Modifiers.Override);
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 4059 - Return statement without semicolon missing in the AST
+		/// </summary>
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug4059()
+		{
+			string code = @"
+class Stub
+{
+    Test A ()
+    {
+        return new Test ()
+    }
+}";
+			var unit = CompilationUnit.Parse(code);
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			bool passed = method.Body.Statements.FirstOrDefault() is ReturnStatement;
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 4058 - Unattached parameter attributes should be included in the AST
+		/// </summary>
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug4058()
+		{
+			string code = @"
+class TestClass
+{
+  TestClass([attr])
+  {
+  }
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var constructor = type.Members.First() as ConstructorDeclaration;
+			bool passed = constructor.LParToken.NextSibling is AttributeSection;
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		
+		
+		/// <summary>
+		/// Bug 3952 - Syntax errors that causes AST not inserted 
+		/// </summary>
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug3952()
+		{
+			string code = @"
+class Foo
+{
+	void Bar()
+	{
+		Test(new Foo (
+	}
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			bool passed = !method.Body.IsNull;
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 3578 - For condition not in the AST.
+		/// </summary>
+		[Test]
+		public void TestBug3578()
+		{
+			string code = 
+@"class Foo
+{
+	void Bar ()
+	{
+		for (int i = 0; i < foo.bar)
+	}
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			bool passed = @"class Foo
+{
+	void Bar ()
+	{
+		for (int i = 0; i < foo.bar;)
+	}
+}" == unit.GetText ().Trim ();
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 3517 - Incomplete conditional operator in the AST request.
+		/// </summary>
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug3517()
+		{
+			string code = 
+@"class Test
+{
+	void Foo ()
+	{
+		a = cond ? expr
+	}
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			var exprStmt = method.Body.Statements.FirstOrDefault() as ExpressionStatement;
+			var expr = exprStmt.Expression as AssignmentExpression;
+			bool passed = expr != null && expr.Right is ConditionalExpression;
+			
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		[Ignore("Still open")]
+		[Test]
+		public void TestBug3517Case2()
+		{
+			string code = 
+@"class Test
+{
+	void Foo ()
+	{
+		a = cond ? expr :
+	}
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			var exprStmt = method.Body.Statements.FirstOrDefault() as ExpressionStatement;
+			var expr = exprStmt.Expression as AssignmentExpression;
+			bool passed = expr != null && expr.Right is ConditionalExpression;
+			
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 3468 - Local variable declarations are not inserted in ast & break declaring member locations.
+		/// </summary>
+		[Test]
+		public void TestBug3468()
+		{
+			string code = 
+@"class C
+{
+    public static void Main (string[] args)
+    {
+        string str = 
+    }
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			bool passed = !method.Body.IsNull;
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 3288 - Try ... catch not added to the ast if catch block is missing
+		/// </summary>
+		[Test]
+		public void TestBug3288()
+		{
+			string code = 
+@"class Test
+{
+	public void Main(string[] args)
+	{
+		try {
+		} catch (Exception name)
+	}
+}";
+			var unit = CompilationUnit.Parse(code);
+			
+			var type = unit.Members.First() as TypeDeclaration;
+			var method = type.Members.First() as MethodDeclaration;
+			bool passed = method.Body.Statements.FirstOrDefault() is TryCatchStatement;
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+		/// <summary>
+		/// Bug 3155 - Anonymous methods in variable declarations don't produce an ast, if the ';' is missing.
+		/// </summary>
+		[Test]
+		public void TestBug3155()
+		{
+			string code = 
+@"using System;
+
+class Test
+{
+    void Foo ()
+    {
+        Action<int> act = delegate (int testMe) {
+
+        }
+    }
+}
+";
+			var unit = CompilationUnit.Parse(code);
+			
+			bool passed = unit.GetText().Trim() == @"using System;
+class Test
+{
+	void Foo ()
+	{
+		Action<int> act = delegate (int testMe) {
+		};
+	}
+}";
+			if (!passed) {
+				Console.WriteLine("Expected:" + code);
+				Console.WriteLine("Was:" + unit.GetText());
+			}
+			Assert.IsTrue(passed);
+		}
+		
+	}
+}
+

ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj

@@ -262,6 +262,7 @@
     <Compile Include="CSharp\CodeActions\CreateDelegateTests.cs" />
     <Compile Include="CSharp\CodeActions\IntroduceConstantTests.cs" />
     <Compile Include="CSharp\CodeActions\ExtractMethodTests.cs" />
+    <Compile Include="CSharp\Parser\Bugs\ParserBugTests.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\Mono.Cecil\Mono.Cecil.csproj">
@@ -289,6 +290,7 @@
     <Folder Include="CSharp\Parser\" />
     <Folder Include="CSharp\CodeIssues\" />
     <Folder Include="CSharp\CodeActions\" />
+    <Folder Include="CSharp\Parser\Bugs\" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
   <ProjectExtensions>