Browse Source

Remove Recent parameter from Get-Packages cmdlet.

pull/53/merge
Matt Ward 12 years ago
parent
commit
be9327b7a2
  1. 13
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/GetPackageCmdlet.cs
  2. 43
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/GetPackageCmdletTests.cs

13
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/GetPackageCmdlet.cs

@ -54,9 +54,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets @@ -54,9 +54,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets
[Parameter(ParameterSetName = "Updated")]
public string Source { get; set; }
[Parameter(ParameterSetName = "Recent")]
public SwitchParameter Recent { get; set; }
[Parameter]
[ValidateRange(0, Int32.MaxValue)]
public int Skip {
@ -91,7 +88,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets @@ -91,7 +88,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
bool ParametersRequireProject()
{
if (ListAvailable.IsPresent || Recent.IsPresent) {
if (ListAvailable.IsPresent) {
return false;
}
return true;
@ -108,8 +105,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets @@ -108,8 +105,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets
return GetAvailablePackages();
} else if (Updates.IsPresent) {
return GetUpdatedPackages();
} else if (Recent.IsPresent) {
return GetRecentPackages();
}
return GetInstalledPackages();
}
@ -183,12 +178,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets @@ -183,12 +178,6 @@ namespace ICSharpCode.PackageManagement.Cmdlets
return ProjectName != null;
}
IQueryable<IPackage> GetRecentPackages()
{
IQueryable<IPackage> packages = registeredPackageRepositories.RecentPackageRepository.GetPackages();
return FilterPackages(packages);
}
IQueryable<IPackage> GetInstalledPackages()
{
IQueryable<IPackage> packages = GetPackagesFromSelectedProjectOrSolution();

43
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/GetPackageCmdletTests.cs

@ -77,11 +77,6 @@ namespace PackageManagement.Cmdlets.Tests @@ -77,11 +77,6 @@ namespace PackageManagement.Cmdlets.Tests
cmdlet.Source = source;
}
void EnableRecentParameter()
{
cmdlet.Recent = new SwitchParameter(true);
}
void SetSkipParameter(int skip)
{
cmdlet.Skip = skip;
@ -386,44 +381,6 @@ namespace PackageManagement.Cmdlets.Tests @@ -386,44 +381,6 @@ namespace PackageManagement.Cmdlets.Tests
Assert.AreEqual("MyProject", actualProjectName);
}
[Test]
public void ProcessRecord_RecentPackagesRequested_RecentPackagesReturned()
{
CreateCmdlet();
FakePackageRepository recentPackageRepository = fakeRegisteredPackageRepositories.FakeRecentPackageRepository;
recentPackageRepository.AddFakePackage("A");
EnableRecentParameter();
RunCmdlet();
List<object> actualPackages = fakeCommandRuntime.ObjectsPassedToWriteObject;
List<FakePackage> expectedPackages = recentPackageRepository.FakePackages;
Assert.AreEqual(expectedPackages, actualPackages);
}
[Test]
public void ProcessRecord_RecentPackagesRequestedWithFilter_FilteredRecentPackagesReturned()
{
CreateCmdlet();
FakePackageRepository recentPackageRepository = fakeRegisteredPackageRepositories.FakeRecentPackageRepository;
recentPackageRepository.AddFakePackage("A");
FakePackage packageB = recentPackageRepository.AddFakePackage("B");
EnableRecentParameter();
SetFilterParameter("B");
RunCmdlet();
List<object> actualPackages = fakeCommandRuntime.ObjectsPassedToWriteObject;
var expectedPackages = new FakePackage[] {
packageB
};
Assert.AreEqual(expectedPackages, actualPackages);
}
[Test]
public void ProcessRecord_FilterParameterPassedContainingTwoSearchTermsSeparatedBySpaceCharacter_InstallPackagesAreFilteredByBothSearchTerms()
{

Loading…
Cancel
Save