Browse Source

GatherVisitor: added calls to base methods

newNRvisualizers
Mansheng Yang 14 years ago
parent
commit
bd1f050818
  1. 9
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/AccessToClosureIssues/AccessToClosureIssue.cs
  2. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/TypeParameterNotUsedIssue.cs
  3. 3
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableNotUsedIssues/LocalVariableNotUsedIssue.cs
  4. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableNotUsedIssues/ParameterNotUsedIssue.cs
  5. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableOnlyAssignedIssues/LocalVariableOnlyAssignedIssue.cs
  6. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableOnlyAssignedIssues/ParameterOnlyAssignedIssue.cs

9
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/AccessToClosureIssues/AccessToClosureIssue.cs

@ -63,7 +63,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -63,7 +63,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
protected abstract NodeKind GetNodeKind (AstNode node);
protected virtual bool CanReachModification (ControlFlowNode node, Statement start,
IDictionary<Statement, IList<Node>> modifications)
IDictionary<Statement, IList<Node>> modifications)
{
return node.NextStatement != null && node.NextStatement != start &&
modifications.ContainsKey (node.NextStatement);
@ -98,13 +98,15 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -98,13 +98,15 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
CheckVariable (((LocalResolveResult)ctx.Resolve (variableInitializer)).Variable,
variableDecl.Type,
variableDecl.GetParent<Statement> ());
base.VisitVariableInitializer (variableInitializer);
}
public override void VisitForeachStatement (ForeachStatement foreachStatement)
{
CheckVariable (((LocalResolveResult)ctx.Resolve (foreachStatement.VariableNameToken)).Variable,
foreachStatement.VariableType,
foreachStatement.VariableType,
foreachStatement);
base.VisitForeachStatement (foreachStatement);
}
public override void VisitParameterDeclaration (ParameterDeclaration parameterDeclaration)
@ -121,8 +123,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -121,8 +123,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
body = ((ConstructorDeclaration)parent).Body;
}
if (body != null)
CheckVariable (((LocalResolveResult)ctx.Resolve (parameterDeclaration)).Variable,
CheckVariable (((LocalResolveResult)ctx.Resolve (parameterDeclaration)).Variable,
parameterDeclaration.Type, body);
base.VisitParameterDeclaration (parameterDeclaration);
}
void FindLocalReferences (IVariable variable, FoundReferenceCallback callback)

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/TypeParameterNotUsedIssue.cs

@ -87,6 +87,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -87,6 +87,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
AddIssue (decl.NameToken, ctx.TranslateString ("Type parameter is never used"));
base.VisitTypeParameterDeclaration (decl);
}
}
}

3
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableNotUsedIssues/LocalVariableNotUsedIssue.cs

@ -78,6 +78,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -78,6 +78,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
script.Replace (decl, newDeclaration);
}
});
base.VisitVariableInitializer (variableInitializer);
}
public override void VisitForeachStatement (ForeachStatement foreachStatement)
@ -90,6 +91,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -90,6 +91,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
AddIssue (foreachStatement.VariableNameToken, ctx.TranslateString ("Local variable is never used"));
base.VisitForeachStatement (foreachStatement);
}
}

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableNotUsedIssues/ParameterNotUsedIssue.cs

@ -60,6 +60,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -60,6 +60,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
AddIssue (parameterDeclaration.NameToken, ctx.TranslateString ("Parameter is never used"));
base.VisitParameterDeclaration (parameterDeclaration);
}
}
}

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableOnlyAssignedIssues/LocalVariableOnlyAssignedIssue.cs

@ -64,6 +64,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -64,6 +64,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
AddIssue (variableInitializer.NameToken,
ctx.TranslateString ("Local variable is assigned by its value is never used"));
base.VisitVariableInitializer (variableInitializer);
}
}
}

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/VariableOnlyAssignedIssues/ParameterOnlyAssignedIssue.cs

@ -60,6 +60,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -60,6 +60,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
AddIssue (parameterDeclaration.NameToken,
ctx.TranslateString ("Parameter is assigned by its value is never used"));
base.VisitParameterDeclaration (parameterDeclaration);
}
}
}

Loading…
Cancel
Save