From bae24695cd2489816c14f58b6e1b91cf6f531967 Mon Sep 17 00:00:00 2001 From: Matt Ward Date: Mon, 3 Dec 2012 19:35:21 +0000 Subject: [PATCH] Fix changing Source Analysis project options not showing as dirty. Problem occurred if the project had no SourceAnalysisOverrideSettingsFile set in the project. In this case the options panel was overriding the ProjectOptions.Load method and changing the values but not setting the IsDirty flag back to false so the UI was showing it as not dirty when in fact it had been changed. Further changes did not cause the IsDirty flag to change so the UI never displayed the an asterisk indicating there were outstanding changes. --- .../Analysis/SourceAnalysis/Src/AnalysisOptionsPanel.xaml.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/AddIns/Analysis/SourceAnalysis/Src/AnalysisOptionsPanel.xaml.cs b/src/AddIns/Analysis/SourceAnalysis/Src/AnalysisOptionsPanel.xaml.cs index 83a67babab..5cc0950e2c 100644 --- a/src/AddIns/Analysis/SourceAnalysis/Src/AnalysisOptionsPanel.xaml.cs +++ b/src/AddIns/Analysis/SourceAnalysis/Src/AnalysisOptionsPanel.xaml.cs @@ -44,6 +44,7 @@ namespace ICSharpCode.SourceAnalysis if (String.IsNullOrEmpty(SourceAnalysisOverrideSettingsFile.Value)) { SourceAnalysisOverrideSettingsFile.Value = StyleCopWrapper.GetMasterSettingsFile(); SourceAnalysisOverrideSettingsFile.Location = PropertyStorageLocations.Base; + IsDirty = false; } }