Browse Source

- removed some debug code from AXmlParser in Release build to increase performance a bit

- fixed some minor ErrorPainter bugs

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@4868 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61
shortcuts
Siegfried Pammer 16 years ago
parent
commit
bab3f4369f
  1. 12
      src/AddIns/DisplayBindings/AvalonEdit.AddIn/Src/CodeEditor.cs
  2. 2
      src/AddIns/DisplayBindings/AvalonEdit.AddIn/Src/TextMarkerService.cs
  3. 1
      src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Xml/AXmlParser.cs
  4. 3
      src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Xml/TrackedSegmentCollection.cs
  5. 2
      src/Libraries/ICSharpCode.TextEditor/Project/Src/Document/DefaultDocument.cs
  6. 2
      src/Main/Base/Project/Src/Services/Tasks/ErrorPainter.cs

12
src/AddIns/DisplayBindings/AvalonEdit.AddIn/Src/CodeEditor.cs

@ -51,7 +51,7 @@ namespace ICSharpCode.AvalonEdit.AddIn @@ -51,7 +51,7 @@ namespace ICSharpCode.AvalonEdit.AddIn
CodeEditorAdapter secondaryTextEditorAdapter;
readonly IconBarManager iconBarManager;
readonly TextMarkerService textMarkerService;
readonly ErrorPainter errorPainter;
ErrorPainter errorPainter;
BracketHighlightRenderer primaryBracketRenderer;
BracketHighlightRenderer secondaryBracketRenderer;
@ -117,6 +117,11 @@ namespace ICSharpCode.AvalonEdit.AddIn @@ -117,6 +117,11 @@ namespace ICSharpCode.AvalonEdit.AddIn
if (secondaryTextEditorAdapter != null)
secondaryTextEditorAdapter.FileNameChanged();
if (this.errorPainter != null)
this.errorPainter.Dispose();
this.errorPainter = new ErrorPainter(primaryTextEditorAdapter);
FetchParseInformation();
}
}
@ -141,8 +146,6 @@ namespace ICSharpCode.AvalonEdit.AddIn @@ -141,8 +146,6 @@ namespace ICSharpCode.AvalonEdit.AddIn
primaryTextEditorAdapter = (CodeEditorAdapter)primaryTextEditor.TextArea.GetService(typeof(ITextEditor));
Debug.Assert(primaryTextEditorAdapter != null);
this.errorPainter = new ErrorPainter(primaryTextEditorAdapter);
this.primaryBracketRenderer = new BracketHighlightRenderer(primaryTextEditor.TextArea.TextView);
this.Document = primaryTextEditor.Document;
@ -527,7 +530,8 @@ namespace ICSharpCode.AvalonEdit.AddIn @@ -527,7 +530,8 @@ namespace ICSharpCode.AvalonEdit.AddIn
if (secondaryTextEditorAdapter != null)
secondaryTextEditorAdapter.Language.Detach();
errorPainter.Dispose();
if (errorPainter != null)
errorPainter.Dispose();
this.Document = null;
}
}

2
src/AddIns/DisplayBindings/AvalonEdit.AddIn/Src/TextMarkerService.cs

@ -169,7 +169,7 @@ namespace ICSharpCode.AvalonEdit.AddIn @@ -169,7 +169,7 @@ namespace ICSharpCode.AvalonEdit.AddIn
case TextMarkerType.SquigglyUnderline:
double offset = 2.5;
int count = (int)((endPoint.X - startPoint.X) / offset) + 1;
int count = Math.Max((int)((endPoint.X - startPoint.X) / offset) + 1, 4);
StreamGeometry geometry = new StreamGeometry();

1
src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Xml/AXmlParser.cs

@ -128,6 +128,7 @@ namespace ICSharpCode.AvalonEdit.Xml @@ -128,6 +128,7 @@ namespace ICSharpCode.AvalonEdit.Xml
}
}
[Conditional("DEBUG")]
internal static void Log(string text, params object[] pars)
{
System.Diagnostics.Debug.WriteLine(string.Format("XML: " + text, pars));

3
src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Xml/TrackedSegmentCollection.cs

@ -69,7 +69,8 @@ namespace ICSharpCode.AvalonEdit.Xml @@ -69,7 +69,8 @@ namespace ICSharpCode.AvalonEdit.Xml
/// <summary> Add object to cache, optionally adding extra memory tracking </summary>
public void AddParsedObject(AXmlObject obj, int? maxTouchedLocation)
{
AXmlParser.Assert(obj.Length > 0 || obj is AXmlDocument, string.Format("Invalid object {0}. It has zero length.", obj));
if (!(obj.Length > 0 || obj is AXmlDocument))
AXmlParser.Assert(false, string.Format("Invalid object {0}. It has zero length.", obj));
// // Expensive check
// if (obj is AXmlContainer) {
// int objStartOffset = obj.StartOffset;

2
src/Libraries/ICSharpCode.TextEditor/Project/Src/Document/DefaultDocument.cs

@ -40,7 +40,7 @@ namespace ICSharpCode.TextEditor.Document @@ -40,7 +40,7 @@ namespace ICSharpCode.TextEditor.Document
/// <summary>
/// The indentation from the line above will be
/// taken to indent the curent line
/// taken to indent the current line
/// </summary>
Auto,

2
src/Main/Base/Project/Src/Services/Tasks/ErrorPainter.cs

@ -33,6 +33,8 @@ namespace ICSharpCode.SharpDevelop @@ -33,6 +33,8 @@ namespace ICSharpCode.SharpDevelop
TaskService.Cleared += new EventHandler(OnCleared);
DebuggerService.DebugStarted += OnDebugStarted;
DebuggerService.DebugStopped += OnDebugStopped;
UpdateErrors();
}
bool isDisposed;

Loading…
Cancel
Save