|
|
|
@ -23,7 +23,6 @@
@@ -23,7 +23,6 @@
|
|
|
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
|
// THE SOFTWARE.
|
|
|
|
|
|
|
|
|
|
using System; |
|
|
|
|
using ICSharpCode.NRefactory.TypeSystem; |
|
|
|
|
using System.Threading; |
|
|
|
@ -40,42 +39,48 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
@@ -40,42 +39,48 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
|
|
|
|
|
var type = context.GetNode<AstType>(); |
|
|
|
|
if (type == null || type.Role != Roles.BaseType) |
|
|
|
|
yield break; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
var state = context.GetResolverStateBefore(type); |
|
|
|
|
if (state.CurrentTypeDefinition == null) |
|
|
|
|
yield break; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
var resolveResult = context.Resolve(type); |
|
|
|
|
if (resolveResult.Type.Kind != TypeKind.Interface) |
|
|
|
|
yield break; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
var toImplement = CollectMembersToImplement(state.CurrentTypeDefinition, resolveResult.Type, false); |
|
|
|
|
if (toImplement.Count == 0) |
|
|
|
|
yield break; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
yield return new CodeAction(context.TranslateString("Implement interface"), script => { |
|
|
|
|
script.InsertWithCursor( |
|
|
|
|
context.TranslateString ("Implement Interface"), |
|
|
|
|
context.TranslateString("Implement Interface"), |
|
|
|
|
state.CurrentTypeDefinition, |
|
|
|
|
GenerateImplementation (context, toImplement) |
|
|
|
|
GenerateImplementation(context, toImplement) |
|
|
|
|
); |
|
|
|
|
}); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
public static IEnumerable<AstNode> GenerateImplementation(RefactoringContext context, IEnumerable<Tuple<IMember, bool>> toImplement) |
|
|
|
|
{ |
|
|
|
|
var nodes = new Dictionary<IType, List<AstNode>>(); |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
foreach (var member in toImplement) { |
|
|
|
|
if (!nodes.ContainsKey(member.Item1.DeclaringType)) |
|
|
|
|
nodes [member.Item1.DeclaringType] = new List<AstNode>(); |
|
|
|
|
nodes [member.Item1.DeclaringType].Add(GenerateMemberImplementation(context, member)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
foreach (var kv in nodes) { |
|
|
|
|
yield return new PreProcessorDirective( |
|
|
|
|
PreProcessorDirectiveType.Region, |
|
|
|
|
string.Format("{0} implementation", kv.Key.Name)); |
|
|
|
|
if (kv.Key.Kind == TypeKind.Interface) { |
|
|
|
|
yield return new PreProcessorDirective( |
|
|
|
|
PreProcessorDirectiveType.Region, |
|
|
|
|
string.Format("{0} implementation", kv.Key.Name)); |
|
|
|
|
} else { |
|
|
|
|
yield return new PreProcessorDirective( |
|
|
|
|
PreProcessorDirectiveType.Region, |
|
|
|
|
string.Format("implemented abstract members of {0}", kv.Key.Name)); |
|
|
|
|
} |
|
|
|
|
foreach (var member in kv.Value) |
|
|
|
|
yield return member; |
|
|
|
|
yield return new PreProcessorDirective( |
|
|
|
@ -83,23 +88,131 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
@@ -83,23 +88,131 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
|
|
|
|
|
); |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static AstNode GenerateMemberImplementation(RefactoringContext context, Tuple<IMember, bool> member) |
|
|
|
|
{ |
|
|
|
|
switch (member.Item1.EntityType) { |
|
|
|
|
case EntityType.Property: |
|
|
|
|
return null; |
|
|
|
|
return GenerateProperty(context, (IProperty)member.Item1, member.Item2); |
|
|
|
|
case EntityType.Indexer: |
|
|
|
|
return null; |
|
|
|
|
return GenerateIndexer(context, (IProperty)member.Item1, member.Item2); |
|
|
|
|
case EntityType.Event: |
|
|
|
|
return null; |
|
|
|
|
return GenerateEvent(context, (IEvent)member.Item1, member.Item2); |
|
|
|
|
case EntityType.Method: |
|
|
|
|
return GenerateMethod(context, (IMethod)member.Item1, member.Item2); |
|
|
|
|
default: |
|
|
|
|
throw new ArgumentOutOfRangeException(); |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
static AstNode GenerateEvent(RefactoringContext context, IEvent evt, bool explicitImplementation) |
|
|
|
|
{ |
|
|
|
|
if (!explicitImplementation) { |
|
|
|
|
return new EventDeclaration() { |
|
|
|
|
Modifiers = Modifiers.Public, |
|
|
|
|
Name = evt.Name, |
|
|
|
|
ReturnType = context.CreateShortType (evt.ReturnType) |
|
|
|
|
}; |
|
|
|
|
} |
|
|
|
|
return new CustomEventDeclaration() { |
|
|
|
|
Name = evt.Name, |
|
|
|
|
ReturnType = context.CreateShortType (evt.ReturnType), |
|
|
|
|
PrivateImplementationType = context.CreateShortType(evt.DeclaringType), |
|
|
|
|
AddAccessor = new Accessor { |
|
|
|
|
Body = new BlockStatement() { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}, |
|
|
|
|
RemoveAccessor = new Accessor { |
|
|
|
|
Body = new BlockStatement() { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
static AstNode GenerateProperty(RefactoringContext context, IProperty property, bool explicitImplementation) |
|
|
|
|
{ |
|
|
|
|
var result = new PropertyDeclaration() { |
|
|
|
|
Name = property.Name, |
|
|
|
|
ReturnType = context.CreateShortType (property.ReturnType) |
|
|
|
|
}; |
|
|
|
|
|
|
|
|
|
if (!explicitImplementation) { |
|
|
|
|
result.Modifiers = Modifiers.Public; |
|
|
|
|
} else { |
|
|
|
|
result.PrivateImplementationType = context.CreateShortType(property.DeclaringType); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
if (property.CanGet) { |
|
|
|
|
if (property.DeclaringType.Kind != TypeKind.Interface) { |
|
|
|
|
result.Getter = new Accessor() { |
|
|
|
|
Body = new BlockStatement () { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
} else { |
|
|
|
|
result.Getter = new Accessor(); |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
if (property.CanSet) { |
|
|
|
|
if (property.DeclaringType.Kind != TypeKind.Interface) { |
|
|
|
|
result.Setter = new Accessor() { |
|
|
|
|
Body = new BlockStatement () { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
} else { |
|
|
|
|
result.Setter = new Accessor(); |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
return result; |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
static AstNode GenerateIndexer(RefactoringContext context, IProperty indexer, bool explicitImplementation) |
|
|
|
|
{ |
|
|
|
|
var result = new IndexerDeclaration() { |
|
|
|
|
ReturnType = context.CreateShortType (indexer.ReturnType) |
|
|
|
|
}; |
|
|
|
|
|
|
|
|
|
if (!explicitImplementation) { |
|
|
|
|
result.Modifiers = Modifiers.Public; |
|
|
|
|
} else { |
|
|
|
|
result.PrivateImplementationType = context.CreateShortType(indexer.DeclaringType); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
foreach (var p in indexer.Parameters) { |
|
|
|
|
ParameterModifier modifier; |
|
|
|
|
if (p.IsOut) { |
|
|
|
|
modifier = ParameterModifier.Out; |
|
|
|
|
} else if (p.IsRef) { |
|
|
|
|
modifier = ParameterModifier.Ref; |
|
|
|
|
} else if (p.IsParams) { |
|
|
|
|
modifier = ParameterModifier.Params; |
|
|
|
|
} else { |
|
|
|
|
modifier = ParameterModifier.None; |
|
|
|
|
} |
|
|
|
|
result.Parameters.Add(new ParameterDeclaration(context.CreateShortType(p.Type), p.Name, modifier)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
if (indexer.CanGet) { |
|
|
|
|
result.Getter = new Accessor() { |
|
|
|
|
Body = new BlockStatement () { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
} |
|
|
|
|
if (indexer.CanSet) { |
|
|
|
|
result.Setter = new Accessor() { |
|
|
|
|
Body = new BlockStatement () { |
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
} |
|
|
|
|
return result; |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
static AstNode GenerateMethod(RefactoringContext context, IMethod method, bool explicitImplementation) |
|
|
|
|
{ |
|
|
|
|
var result = new MethodDeclaration() { |
|
|
|
@ -109,40 +222,40 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
@@ -109,40 +222,40 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
|
|
|
|
|
new ThrowStatement(new ObjectCreateExpression(context.CreateShortType("System", "NotImplementedException"))) |
|
|
|
|
} |
|
|
|
|
}; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (!explicitImplementation) { |
|
|
|
|
result.Modifiers = Modifiers.Public; |
|
|
|
|
} else { |
|
|
|
|
result.PrivateImplementationType = context.CreateShortType(method.DeclaringType); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
foreach (var typeParam in method.TypeParameters) { |
|
|
|
|
result.TypeParameters.Add(new TypeParameterDeclaration(typeParam.Name)); |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
var constraint = new Constraint() { |
|
|
|
|
TypeParameter = new SimpleType(typeParam.Name) |
|
|
|
|
}; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (typeParam.HasDefaultConstructorConstraint) { |
|
|
|
|
constraint.BaseTypes.Add (new PrimitiveType("new")); |
|
|
|
|
constraint.BaseTypes.Add(new PrimitiveType("new")); |
|
|
|
|
} else if (typeParam.HasReferenceTypeConstraint) { |
|
|
|
|
constraint.BaseTypes.Add (new PrimitiveType("class")); |
|
|
|
|
constraint.BaseTypes.Add(new PrimitiveType("class")); |
|
|
|
|
} else if (typeParam.HasValueTypeConstraint) { |
|
|
|
|
constraint.BaseTypes.Add (new PrimitiveType("struct")); |
|
|
|
|
constraint.BaseTypes.Add(new PrimitiveType("struct")); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
foreach (var type in typeParam.DirectBaseTypes) { |
|
|
|
|
if (type.FullName == "System.Object") |
|
|
|
|
continue; |
|
|
|
|
if (type.FullName == "System.ValueType") |
|
|
|
|
continue; |
|
|
|
|
constraint.BaseTypes.Add (context.CreateShortType (type)); |
|
|
|
|
constraint.BaseTypes.Add(context.CreateShortType(type)); |
|
|
|
|
} |
|
|
|
|
if (constraint.BaseTypes.Count == 0) |
|
|
|
|
continue; |
|
|
|
|
result.Constraints.Add (constraint); |
|
|
|
|
result.Constraints.Add(constraint); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
foreach (var p in method.Parameters) { |
|
|
|
|
ParameterModifier modifier; |
|
|
|
|
if (p.IsOut) { |
|
|
|
@ -156,74 +269,77 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
@@ -156,74 +269,77 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
|
|
|
|
|
} |
|
|
|
|
result.Parameters.Add(new ParameterDeclaration(context.CreateShortType(p.Type), p.Name, modifier)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
return result; |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
public static List<Tuple<IMember, bool>> CollectMembersToImplement(ITypeDefinition implementingType, IType interfaceType, bool explicitly) |
|
|
|
|
{ |
|
|
|
|
var def = interfaceType.GetDefinition(); |
|
|
|
|
List<Tuple<IMember, bool>> toImplement = new List<Tuple<IMember, bool>>(); |
|
|
|
|
bool alreadyImplemented; |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// Stub out non-implemented events defined by @iface
|
|
|
|
|
foreach (var ev in interfaceType.GetEvents (e => !e.IsSynthetic && e.DeclaringTypeDefinition.ReflectionName == def.ReflectionName).Reverse ()) { |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = implementingType.GetAllBaseTypeDefinitions().Any( |
|
|
|
|
x => x.Kind != TypeKind.Interface && x.Events.Any (y => y.Name == ev.Name) |
|
|
|
|
); |
|
|
|
|
|
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(ev, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
foreach (var evGroup in interfaceType.GetEvents (e => !e.IsSynthetic && e.DeclaringTypeDefinition.ReflectionName == def.ReflectionName).GroupBy (m => m.DeclaringType).Reverse ()) |
|
|
|
|
foreach (var ev in evGroup) { |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = implementingType.GetAllBaseTypeDefinitions().Any( |
|
|
|
|
x => x.Kind != TypeKind.Interface && x.Events.Any(y => y.Name == ev.Name) |
|
|
|
|
); |
|
|
|
|
|
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(ev, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
// Stub out non-implemented methods defined by @iface
|
|
|
|
|
foreach (var method in interfaceType.GetMethods (d => !d.IsSynthetic /* && d.DeclaringTypeDefinition.ReflectionName == def.ReflectionName*/).Reverse ()) { |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = false; |
|
|
|
|
foreach (var methodGroup in interfaceType.GetMethods (d => !d.IsSynthetic).GroupBy (m => m.DeclaringType).Reverse ()) |
|
|
|
|
foreach (var method in methodGroup) { |
|
|
|
|
|
|
|
|
|
foreach (var cmet in implementingType.GetMethods ()) { |
|
|
|
|
if (CompareMethods(method, cmet)) { |
|
|
|
|
if (!needsExplicitly && !cmet.ReturnType.Equals(method.ReturnType)) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
else |
|
|
|
|
alreadyImplemented |= !needsExplicitly /*|| cmet.InterfaceImplementations.Any (impl => impl.InterfaceType.Equals (interfaceType))*/; |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = false; |
|
|
|
|
|
|
|
|
|
foreach (var cmet in implementingType.GetMethods ()) { |
|
|
|
|
if (CompareMethods(method, cmet)) { |
|
|
|
|
if (!needsExplicitly && !cmet.ReturnType.Equals(method.ReturnType)) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
else |
|
|
|
|
alreadyImplemented |= !needsExplicitly /*|| cmet.InterfaceImplementations.Any (impl => impl.InterfaceType.Equals (interfaceType))*/; |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
if (toImplement.Where(t => t.Item1 is IMethod).Any(t => CompareMethods(method, (IMethod)t.Item1))) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(method, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
if (toImplement.Where (t => t.Item1 is IMethod).Any (t => CompareMethods (method, (IMethod)t.Item1))) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(method, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// Stub out non-implemented properties defined by @iface
|
|
|
|
|
foreach (var prop in interfaceType.GetProperties (p => !p.IsSynthetic && p.DeclaringTypeDefinition.ReflectionName == def.ReflectionName).Reverse ()) { |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = false; |
|
|
|
|
foreach (var t in implementingType.GetAllBaseTypeDefinitions ()) { |
|
|
|
|
if (t.Kind == TypeKind.Interface) |
|
|
|
|
continue; |
|
|
|
|
foreach (IProperty cprop in t.Properties) { |
|
|
|
|
if (cprop.Name == prop.Name) { |
|
|
|
|
if (!needsExplicitly && !cprop.ReturnType.Equals(prop.ReturnType)) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
else |
|
|
|
|
alreadyImplemented |= !needsExplicitly/* || cprop.InterfaceImplementations.Any (impl => impl.InterfaceType.Resolve (ctx).Equals (interfaceType))*/; |
|
|
|
|
foreach (var propGroup in interfaceType.GetProperties (p => !p.IsSynthetic && p.DeclaringTypeDefinition.ReflectionName == def.ReflectionName).GroupBy (m => m.DeclaringType).Reverse ()) |
|
|
|
|
foreach (var prop in propGroup) { |
|
|
|
|
bool needsExplicitly = explicitly; |
|
|
|
|
alreadyImplemented = false; |
|
|
|
|
foreach (var t in implementingType.GetAllBaseTypeDefinitions ()) { |
|
|
|
|
if (t.Kind == TypeKind.Interface) |
|
|
|
|
continue; |
|
|
|
|
foreach (IProperty cprop in t.Properties) { |
|
|
|
|
if (cprop.Name == prop.Name) { |
|
|
|
|
if (!needsExplicitly && !cprop.ReturnType.Equals(prop.ReturnType)) |
|
|
|
|
needsExplicitly = true; |
|
|
|
|
else |
|
|
|
|
alreadyImplemented |= !needsExplicitly/* || cprop.InterfaceImplementations.Any (impl => impl.InterfaceType.Resolve (ctx).Equals (interfaceType))*/; |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(prop, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
if (!alreadyImplemented) |
|
|
|
|
toImplement.Add(new Tuple<IMember, bool>(prop, needsExplicitly)); |
|
|
|
|
} |
|
|
|
|
return toImplement; |
|
|
|
|
} |
|
|
|
|
|
|
|
|
|
static bool CompareMethods (IMethod interfaceMethod, IMethod typeMethod) |
|
|
|
|
|
|
|
|
|
internal static bool CompareMethods(IMethod interfaceMethod, IMethod typeMethod) |
|
|
|
|
{ |
|
|
|
|
if (typeMethod.IsExplicitInterfaceImplementation) |
|
|
|
|
return typeMethod.ImplementedInterfaceMembers.Any (m => m.Equals (interfaceMethod)); |
|
|
|
|
return SignatureComparer.Ordinal.Equals (interfaceMethod, typeMethod); |
|
|
|
|
return typeMethod.ImplementedInterfaceMembers.Any(m => m.Equals(interfaceMethod)); |
|
|
|
|
return SignatureComparer.Ordinal.Equals(interfaceMethod, typeMethod); |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|
} |
|
|
|
|