Browse Source

Rename PackageManagementService to PackageManagementSolution.

pull/15/head
Matt Ward 14 years ago
parent
commit
a354836b3b
  1. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/GetPackageCmdlet.cs
  2. 8
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/InstallPackageCmdlet.cs
  3. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/PackageManagementCmdlet.cs
  4. 8
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/UninstallPackageCmdlet.cs
  5. 8
      src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/UpdatePackageCmdlet.cs
  6. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableGetPackageCmdlet.cs
  7. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableInstallPackageCmdlet.cs
  8. 2
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestablePackageManagementCmdlet.cs
  9. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableUninstallPackageCmdlet.cs
  10. 10
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableUpdatePackageCmdlet.cs
  11. 20
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/GetPackageCmdletTests.cs
  12. 6
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/InstallPackageCmdletTests.cs
  13. 6
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/UninstallPackageCmdletTests.cs
  14. 6
      src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/UpdatePackageCmdletTests.cs
  15. 4
      src/AddIns/Misc/PackageManagement/Project/PackageManagement.csproj
  16. 12
      src/AddIns/Misc/PackageManagement/Project/Src/AddPackageReferenceViewModel.cs
  17. 4
      src/AddIns/Misc/PackageManagement/Project/Src/Design/DesignTimeLicenseAcceptanceViewModel.cs
  18. 6
      src/AddIns/Misc/PackageManagement/Project/Src/Design/DesignTimePackagesViewModel.cs
  19. 4
      src/AddIns/Misc/PackageManagement/Project/Src/Design/FakePackageManagementService.cs
  20. 2
      src/AddIns/Misc/PackageManagement/Project/Src/IPackageManagementSolution.cs
  21. 2
      src/AddIns/Misc/PackageManagement/Project/Src/IPackageViewModelFactory.cs
  22. 4
      src/AddIns/Misc/PackageManagement/Project/Src/InstallPackageAction.cs
  23. 8
      src/AddIns/Misc/PackageManagement/Project/Src/InstalledPackagesViewModel.cs
  24. 8
      src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementServices.cs
  25. 6
      src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementSolution.cs
  26. 18
      src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementViewModels.cs
  27. 14
      src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModel.cs
  28. 10
      src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModelFactory.cs
  29. 10
      src/AddIns/Misc/PackageManagement/Project/Src/ProcessPackageAction.cs
  30. 8
      src/AddIns/Misc/PackageManagement/Project/Src/UninstallPackageAction.cs
  31. 4
      src/AddIns/Misc/PackageManagement/Project/Src/UpdatePackageAction.cs
  32. 10
      src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackageViewModel.cs
  33. 2
      src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackageViewModelFactory.cs
  34. 14
      src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackages.cs
  35. 12
      src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackagesViewModel.cs
  36. 2
      src/AddIns/Misc/PackageManagement/Test/PackageManagement.Tests.csproj
  37. 34
      src/AddIns/Misc/PackageManagement/Test/Src/AddPackageReferenceViewModelTests.cs
  38. 2
      src/AddIns/Misc/PackageManagement/Test/Src/Helpers/ExceptionThrowingPackageManagementService.cs
  39. 8
      src/AddIns/Misc/PackageManagement/Test/Src/Helpers/FakePackageViewModelFactory.cs
  40. 16
      src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestablePackageViewModel.cs
  41. 10
      src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableProcessPackageAction.cs
  42. 14
      src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableUpdatedPackageViewModel.cs
  43. 14
      src/AddIns/Misc/PackageManagement/Test/Src/InstallPackageActionTests.cs
  44. 40
      src/AddIns/Misc/PackageManagement/Test/Src/InstalledPackagesViewModelTests.cs
  45. 66
      src/AddIns/Misc/PackageManagement/Test/Src/PackageManagementSolutionTests.cs
  46. 54
      src/AddIns/Misc/PackageManagement/Test/Src/PackageViewModelTests.cs
  47. 6
      src/AddIns/Misc/PackageManagement/Test/Src/ProcessPackageActionTests.cs
  48. 6
      src/AddIns/Misc/PackageManagement/Test/Src/Scripting/PackageManagementConsoleViewModelTests.cs
  49. 14
      src/AddIns/Misc/PackageManagement/Test/Src/UninstallPackageActionTests.cs
  50. 46
      src/AddIns/Misc/PackageManagement/Test/Src/UpdatePackageActionTests.cs
  51. 6
      src/AddIns/Misc/PackageManagement/Test/Src/UpdatedPackageViewModelTests.cs
  52. 30
      src/AddIns/Misc/PackageManagement/Test/Src/UpdatedPackagesViewModelTests.cs

10
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/GetPackageCmdlet.cs

@ -23,7 +23,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
public GetPackageCmdlet() public GetPackageCmdlet()
: this( : this(
PackageManagementServices.RegisteredPackageRepositories, PackageManagementServices.RegisteredPackageRepositories,
PackageManagementServices.PackageManagementService, PackageManagementServices.Solution,
PackageManagementServices.ConsoleHost, PackageManagementServices.ConsoleHost,
null) null)
{ {
@ -31,10 +31,10 @@ namespace ICSharpCode.PackageManagement.Cmdlets
public GetPackageCmdlet( public GetPackageCmdlet(
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementConsoleHost consoleHost, IPackageManagementConsoleHost consoleHost,
ICmdletTerminatingError terminatingError) ICmdletTerminatingError terminatingError)
: base(packageManagementService, consoleHost, terminatingError) : base(solution, consoleHost, terminatingError)
{ {
this.registeredPackageRepositories = registeredPackageRepositories; this.registeredPackageRepositories = registeredPackageRepositories;
} }
@ -154,7 +154,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
IQueryable<IPackage> GetUpdatedPackages() IQueryable<IPackage> GetUpdatedPackages()
{ {
IPackageRepository aggregateRepository = registeredPackageRepositories.CreateAggregateRepository(); IPackageRepository aggregateRepository = registeredPackageRepositories.CreateAggregateRepository();
var updatedPackages = new UpdatedPackages(PackageManagementService, aggregateRepository, DefaultProject); var updatedPackages = new UpdatedPackages(Solution, aggregateRepository, DefaultProject);
updatedPackages.SearchTerms = Filter; updatedPackages.SearchTerms = Filter;
return updatedPackages.GetUpdatedPackages().AsQueryable(); return updatedPackages.GetUpdatedPackages().AsQueryable();
} }
@ -174,7 +174,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
ISharpDevelopProjectManager CreateProjectManagerForActiveProject(IPackageRepository repository) ISharpDevelopProjectManager CreateProjectManagerForActiveProject(IPackageRepository repository)
{ {
return PackageManagementService.CreateProjectManager(repository, DefaultProject); return Solution.CreateProjectManager(repository, DefaultProject);
} }
IQueryable<IPackage> GetRecentPackages() IQueryable<IPackage> GetRecentPackages()

8
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/InstallPackageCmdlet.cs

@ -14,17 +14,17 @@ namespace ICSharpCode.PackageManagement.Cmdlets
{ {
public InstallPackageCmdlet() public InstallPackageCmdlet()
: this( : this(
PackageManagementServices.PackageManagementService, PackageManagementServices.Solution,
PackageManagementServices.ConsoleHost, PackageManagementServices.ConsoleHost,
null) null)
{ {
} }
public InstallPackageCmdlet( public InstallPackageCmdlet(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementConsoleHost consoleHost, IPackageManagementConsoleHost consoleHost,
ICmdletTerminatingError terminatingError) ICmdletTerminatingError terminatingError)
: base(packageManagementService, consoleHost, terminatingError) : base(solution, consoleHost, terminatingError)
{ {
} }
@ -60,7 +60,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
InstallPackageAction CreateInstallPackageTask(PackageSource packageSource, MSBuildBasedProject project) InstallPackageAction CreateInstallPackageTask(PackageSource packageSource, MSBuildBasedProject project)
{ {
InstallPackageAction action = PackageManagementService.CreateInstallPackageAction(); InstallPackageAction action = Solution.CreateInstallPackageAction();
action.PackageId = Id; action.PackageId = Id;
action.PackageVersion = Version; action.PackageVersion = Version;
action.Project = project; action.Project = project;

10
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/PackageManagementCmdlet.cs

@ -11,22 +11,22 @@ namespace ICSharpCode.PackageManagement.Cmdlets
{ {
public abstract class PackageManagementCmdlet : PSCmdlet, ITerminatingCmdlet public abstract class PackageManagementCmdlet : PSCmdlet, ITerminatingCmdlet
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IPackageManagementConsoleHost consoleHost; IPackageManagementConsoleHost consoleHost;
ICmdletTerminatingError terminatingError; ICmdletTerminatingError terminatingError;
public PackageManagementCmdlet( public PackageManagementCmdlet(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementConsoleHost consoleHost, IPackageManagementConsoleHost consoleHost,
ICmdletTerminatingError terminatingError) ICmdletTerminatingError terminatingError)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
this.consoleHost = consoleHost; this.consoleHost = consoleHost;
this.terminatingError = terminatingError; this.terminatingError = terminatingError;
} }
protected IPackageManagementService PackageManagementService { protected IPackageManagementSolution Solution {
get { return packageManagementService; } get { return solution; }
} }
protected IPackageManagementConsoleHost ConsoleHost { protected IPackageManagementConsoleHost ConsoleHost {

8
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/UninstallPackageCmdlet.cs

@ -14,17 +14,17 @@ namespace ICSharpCode.PackageManagement.Cmdlets
{ {
public UninstallPackageCmdlet() public UninstallPackageCmdlet()
: this( : this(
PackageManagementServices.PackageManagementService, PackageManagementServices.Solution,
PackageManagementServices.ConsoleHost, PackageManagementServices.ConsoleHost,
null) null)
{ {
} }
public UninstallPackageCmdlet( public UninstallPackageCmdlet(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementConsoleHost consoleHost, IPackageManagementConsoleHost consoleHost,
ICmdletTerminatingError terminatingError) ICmdletTerminatingError terminatingError)
: base(packageManagementService, consoleHost, terminatingError) : base(solution, consoleHost, terminatingError)
{ {
} }
@ -65,7 +65,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
UninstallPackageAction CreateUninstallPackageAction(MSBuildBasedProject project, PackageSource packageSource) UninstallPackageAction CreateUninstallPackageAction(MSBuildBasedProject project, PackageSource packageSource)
{ {
var action = PackageManagementService.CreateUninstallPackageAction(); var action = Solution.CreateUninstallPackageAction();
action.PackageId = Id; action.PackageId = Id;
action.PackageVersion = Version; action.PackageVersion = Version;
action.Project = project; action.Project = project;

8
src/AddIns/Misc/PackageManagement/Cmdlets/Project/Src/UpdatePackageCmdlet.cs

@ -14,17 +14,17 @@ namespace ICSharpCode.PackageManagement.Cmdlets
{ {
public UpdatePackageCmdlet() public UpdatePackageCmdlet()
: this( : this(
PackageManagementServices.PackageManagementService, PackageManagementServices.Solution,
PackageManagementServices.ConsoleHost, PackageManagementServices.ConsoleHost,
null) null)
{ {
} }
public UpdatePackageCmdlet( public UpdatePackageCmdlet(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementConsoleHost consoleHost, IPackageManagementConsoleHost consoleHost,
ICmdletTerminatingError terminatingError) ICmdletTerminatingError terminatingError)
: base(packageManagementService, consoleHost, terminatingError) : base(solution, consoleHost, terminatingError)
{ {
} }
@ -60,7 +60,7 @@ namespace ICSharpCode.PackageManagement.Cmdlets
UpdatePackageAction CreateUpdatePackageAction(PackageSource packageSource, MSBuildBasedProject project) UpdatePackageAction CreateUpdatePackageAction(PackageSource packageSource, MSBuildBasedProject project)
{ {
var action = PackageManagementService.CreateUpdatePackageAction(); var action = Solution.CreateUpdatePackageAction();
action.PackageSource = packageSource; action.PackageSource = packageSource;
action.Project = project; action.Project = project;
action.PackageId = Id; action.PackageId = Id;

10
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableGetPackageCmdlet.cs

@ -12,7 +12,7 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
{ {
public class TestableGetPackageCmdlet : GetPackageCmdlet public class TestableGetPackageCmdlet : GetPackageCmdlet
{ {
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public FakeRegisteredPackageRepositories FakeRegisteredPackageRepositories; public FakeRegisteredPackageRepositories FakeRegisteredPackageRepositories;
public FakeCommandRuntime FakeCommandRuntime; public FakeCommandRuntime FakeCommandRuntime;
public List<IPackage> PackagesPassedToWriteObject = new List<IPackage>(); public List<IPackage> PackagesPassedToWriteObject = new List<IPackage>();
@ -21,7 +21,7 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
public TestableGetPackageCmdlet() public TestableGetPackageCmdlet()
: this( : this(
new FakePackageManagementService(), new FakePackageManagementSolution(),
new FakeRegisteredPackageRepositories(), new FakeRegisteredPackageRepositories(),
new FakePackageManagementConsoleHost(), new FakePackageManagementConsoleHost(),
new FakeCommandRuntime(), new FakeCommandRuntime(),
@ -30,14 +30,14 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
} }
public TestableGetPackageCmdlet( public TestableGetPackageCmdlet(
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakeRegisteredPackageRepositories registeredPackageRepositories, FakeRegisteredPackageRepositories registeredPackageRepositories,
FakePackageManagementConsoleHost consoleHost, FakePackageManagementConsoleHost consoleHost,
FakeCommandRuntime commandRuntime, FakeCommandRuntime commandRuntime,
FakeCmdletTerminatingError terminatingError) FakeCmdletTerminatingError terminatingError)
: base(registeredPackageRepositories, packageManagementService, consoleHost, terminatingError) : base(registeredPackageRepositories, solution, consoleHost, terminatingError)
{ {
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakeRegisteredPackageRepositories = registeredPackageRepositories; this.FakeRegisteredPackageRepositories = registeredPackageRepositories;
this.FakePackageManagementConsoleHost = consoleHost; this.FakePackageManagementConsoleHost = consoleHost;
this.FakeCommandRuntime = commandRuntime; this.FakeCommandRuntime = commandRuntime;

10
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableInstallPackageCmdlet.cs

@ -12,23 +12,23 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
{ {
public FakeCmdletTerminatingError FakeCmdletTerminatingError; public FakeCmdletTerminatingError FakeCmdletTerminatingError;
public FakePackageManagementConsoleHost FakePackageManagementConsoleHost; public FakePackageManagementConsoleHost FakePackageManagementConsoleHost;
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public TestableInstallPackageCmdlet() public TestableInstallPackageCmdlet()
: this( : this(
new FakePackageManagementService(), new FakePackageManagementSolution(),
new FakePackageManagementConsoleHost(), new FakePackageManagementConsoleHost(),
new FakeCmdletTerminatingError()) new FakeCmdletTerminatingError())
{ {
} }
public TestableInstallPackageCmdlet( public TestableInstallPackageCmdlet(
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementConsoleHost consoleHost, FakePackageManagementConsoleHost consoleHost,
FakeCmdletTerminatingError cmdletTerminatingError) FakeCmdletTerminatingError cmdletTerminatingError)
: base(packageManagementService, consoleHost, cmdletTerminatingError) : base(solution, consoleHost, cmdletTerminatingError)
{ {
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakePackageManagementConsoleHost = consoleHost; this.FakePackageManagementConsoleHost = consoleHost;
this.FakeCmdletTerminatingError = cmdletTerminatingError; this.FakeCmdletTerminatingError = cmdletTerminatingError;
} }

2
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestablePackageManagementCmdlet.cs

@ -12,7 +12,7 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
{ {
public TestablePackageManagementCmdlet(FakeCmdletTerminatingError terminatingError) public TestablePackageManagementCmdlet(FakeCmdletTerminatingError terminatingError)
: base( : base(
new FakePackageManagementService(), new FakePackageManagementSolution(),
new FakePackageManagementConsoleHost(), new FakePackageManagementConsoleHost(),
terminatingError) terminatingError)
{ {

10
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableUninstallPackageCmdlet.cs

@ -12,23 +12,23 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
{ {
public FakeCmdletTerminatingError FakeCmdletTerminatingError; public FakeCmdletTerminatingError FakeCmdletTerminatingError;
public FakePackageManagementConsoleHost FakePackageManagementConsoleHost; public FakePackageManagementConsoleHost FakePackageManagementConsoleHost;
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public TestableUninstallPackageCmdlet() public TestableUninstallPackageCmdlet()
: this( : this(
new FakePackageManagementService(), new FakePackageManagementSolution(),
new FakePackageManagementConsoleHost(), new FakePackageManagementConsoleHost(),
new FakeCmdletTerminatingError()) new FakeCmdletTerminatingError())
{ {
} }
public TestableUninstallPackageCmdlet( public TestableUninstallPackageCmdlet(
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementConsoleHost consoleHost, FakePackageManagementConsoleHost consoleHost,
FakeCmdletTerminatingError cmdletTerminatingError) FakeCmdletTerminatingError cmdletTerminatingError)
: base(packageManagementService, consoleHost, cmdletTerminatingError) : base(solution, consoleHost, cmdletTerminatingError)
{ {
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakePackageManagementConsoleHost = consoleHost; this.FakePackageManagementConsoleHost = consoleHost;
this.FakeCmdletTerminatingError = cmdletTerminatingError; this.FakeCmdletTerminatingError = cmdletTerminatingError;
} }

10
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Helpers/TestableUpdatePackageCmdlet.cs

@ -12,23 +12,23 @@ namespace PackageManagement.Cmdlets.Tests.Helpers
{ {
public FakeCmdletTerminatingError FakeCmdletTerminatingError; public FakeCmdletTerminatingError FakeCmdletTerminatingError;
public FakePackageManagementConsoleHost FakePackageManagementConsoleHost; public FakePackageManagementConsoleHost FakePackageManagementConsoleHost;
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public TestableUpdatePackageCmdlet() public TestableUpdatePackageCmdlet()
: this( : this(
new FakePackageManagementService(), new FakePackageManagementSolution(),
new FakePackageManagementConsoleHost(), new FakePackageManagementConsoleHost(),
new FakeCmdletTerminatingError()) new FakeCmdletTerminatingError())
{ {
} }
public TestableUpdatePackageCmdlet( public TestableUpdatePackageCmdlet(
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementConsoleHost consoleHost, FakePackageManagementConsoleHost consoleHost,
FakeCmdletTerminatingError cmdletTerminatingError) FakeCmdletTerminatingError cmdletTerminatingError)
: base(packageManagementService, consoleHost, cmdletTerminatingError) : base(solution, consoleHost, cmdletTerminatingError)
{ {
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakePackageManagementConsoleHost = consoleHost; this.FakePackageManagementConsoleHost = consoleHost;
this.FakeCmdletTerminatingError = cmdletTerminatingError; this.FakeCmdletTerminatingError = cmdletTerminatingError;
} }

20
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/GetPackageCmdletTests.cs

@ -15,7 +15,7 @@ namespace PackageManagement.Cmdlets.Tests
public class GetPackageCmdletTests : CmdletTestsBase public class GetPackageCmdletTests : CmdletTestsBase
{ {
TestableGetPackageCmdlet cmdlet; TestableGetPackageCmdlet cmdlet;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories; FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories;
FakeCommandRuntime fakeCommandRuntime; FakeCommandRuntime fakeCommandRuntime;
FakeCmdletTerminatingError fakeTerminatingError; FakeCmdletTerminatingError fakeTerminatingError;
@ -23,7 +23,7 @@ namespace PackageManagement.Cmdlets.Tests
void CreateCmdlet() void CreateCmdlet()
{ {
cmdlet = new TestableGetPackageCmdlet(); cmdlet = new TestableGetPackageCmdlet();
fakePackageManagementService = cmdlet.FakePackageManagementService; fakeSolution = cmdlet.FakeSolution;
fakeRegisteredPackageRepositories = cmdlet.FakeRegisteredPackageRepositories; fakeRegisteredPackageRepositories = cmdlet.FakeRegisteredPackageRepositories;
fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost; fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost;
fakeCommandRuntime = cmdlet.FakeCommandRuntime; fakeCommandRuntime = cmdlet.FakeCommandRuntime;
@ -53,7 +53,7 @@ namespace PackageManagement.Cmdlets.Tests
FakePackage AddPackageToProjectManagerLocalRepository(string id, string version) FakePackage AddPackageToProjectManagerLocalRepository(string id, string version)
{ {
var package = FakePackage.CreatePackageWithVersion(id, version); var package = FakePackage.CreatePackageWithVersion(id, version);
fakePackageManagementService fakeSolution
.FakeProjectManagerToReturnFromCreateProjectManager .FakeProjectManagerToReturnFromCreateProjectManager
.FakeLocalRepository .FakeLocalRepository
.FakePackages.Add(package); .FakePackages.Add(package);
@ -168,7 +168,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
CreateCmdlet(); CreateCmdlet();
AddDefaultProjectToConsoleHost(); AddDefaultProjectToConsoleHost();
FakeProjectManager projectManager = fakePackageManagementService.FakeProjectManagerToReturnFromCreateProjectManager; FakeProjectManager projectManager = fakeSolution.FakeProjectManagerToReturnFromCreateProjectManager;
projectManager.FakeLocalRepository.AddFakePackage("One"); projectManager.FakeLocalRepository.AddFakePackage("One");
projectManager.FakeLocalRepository.AddFakePackage("Two"); projectManager.FakeLocalRepository.AddFakePackage("Two");
@ -201,7 +201,7 @@ namespace PackageManagement.Cmdlets.Tests
RunCmdlet(); RunCmdlet();
var actualRepository = fakePackageManagementService.PackageRepositoryPassedToCreateProjectManager; var actualRepository = fakeSolution.PackageRepositoryPassedToCreateProjectManager;
var expectedRepository = fakeRegisteredPackageRepositories.FakePackageRepository; var expectedRepository = fakeRegisteredPackageRepositories.FakePackageRepository;
Assert.AreEqual(expectedRepository, actualRepository); Assert.AreEqual(expectedRepository, actualRepository);
@ -216,7 +216,7 @@ namespace PackageManagement.Cmdlets.Tests
RunCmdlet(); RunCmdlet();
var actualProject = fakePackageManagementService.ProjectPassedToCreateProjectManager; var actualProject = fakeSolution.ProjectPassedToCreateProjectManager;
Assert.AreEqual(project, actualProject); Assert.AreEqual(project, actualProject);
} }
@ -248,7 +248,7 @@ namespace PackageManagement.Cmdlets.Tests
EnableUpdatesParameter(); EnableUpdatesParameter();
RunCmdlet(); RunCmdlet();
var actualProject = fakePackageManagementService.ProjectPassedToCreateProjectManager; var actualProject = fakeSolution.ProjectPassedToCreateProjectManager;
Assert.AreEqual(project, actualProject); Assert.AreEqual(project, actualProject);
} }
@ -261,7 +261,7 @@ namespace PackageManagement.Cmdlets.Tests
EnableUpdatesParameter(); EnableUpdatesParameter();
RunCmdlet(); RunCmdlet();
var actualRepository = fakePackageManagementService.PackageRepositoryPassedToCreateProjectManager; var actualRepository = fakeSolution.PackageRepositoryPassedToCreateProjectManager;
var expectedRepository = fakeRegisteredPackageRepositories.FakeAggregateRepository; var expectedRepository = fakeRegisteredPackageRepositories.FakeAggregateRepository;
Assert.AreEqual(expectedRepository, actualRepository); Assert.AreEqual(expectedRepository, actualRepository);
@ -293,7 +293,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
CreateCmdlet(); CreateCmdlet();
AddPackageSourceToConsoleHost(); AddPackageSourceToConsoleHost();
FakeProjectManager projectManager = fakePackageManagementService.FakeProjectManagerToReturnFromCreateProjectManager; FakeProjectManager projectManager = fakeSolution.FakeProjectManagerToReturnFromCreateProjectManager;
projectManager.FakeLocalRepository.AddFakePackage("A"); projectManager.FakeLocalRepository.AddFakePackage("A");
var package = projectManager.FakeLocalRepository.AddFakePackage("B"); var package = projectManager.FakeLocalRepository.AddFakePackage("B");
@ -403,7 +403,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
CreateCmdlet(); CreateCmdlet();
AddPackageSourceToConsoleHost(); AddPackageSourceToConsoleHost();
FakeProjectManager projectManager = fakePackageManagementService.FakeProjectManagerToReturnFromCreateProjectManager; FakeProjectManager projectManager = fakeSolution.FakeProjectManagerToReturnFromCreateProjectManager;
var packageA = projectManager.FakeLocalRepository.AddFakePackage("A"); var packageA = projectManager.FakeLocalRepository.AddFakePackage("A");
var packageB = projectManager.FakeLocalRepository.AddFakePackage("B"); var packageB = projectManager.FakeLocalRepository.AddFakePackage("B");
var packageC = projectManager.FakeLocalRepository.AddFakePackage("C"); var packageC = projectManager.FakeLocalRepository.AddFakePackage("C");

6
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/InstallPackageCmdletTests.cs

@ -18,7 +18,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
TestableInstallPackageCmdlet cmdlet; TestableInstallPackageCmdlet cmdlet;
FakeCmdletTerminatingError fakeTerminatingError; FakeCmdletTerminatingError fakeTerminatingError;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeInstallPackageAction fakeInstallPackageTask; FakeInstallPackageAction fakeInstallPackageTask;
void CreateCmdletWithoutActiveProject() void CreateCmdletWithoutActiveProject()
@ -26,8 +26,8 @@ namespace PackageManagement.Cmdlets.Tests
cmdlet = new TestableInstallPackageCmdlet(); cmdlet = new TestableInstallPackageCmdlet();
fakeTerminatingError = cmdlet.FakeCmdletTerminatingError; fakeTerminatingError = cmdlet.FakeCmdletTerminatingError;
fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost; fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost;
fakePackageManagementService = cmdlet.FakePackageManagementService; fakeSolution = cmdlet.FakeSolution;
fakeInstallPackageTask = fakePackageManagementService.ActionToReturnFromCreateInstallPackageAction; fakeInstallPackageTask = fakeSolution.ActionToReturnFromCreateInstallPackageAction;
} }
void CreateCmdletWithActivePackageSourceAndProject() void CreateCmdletWithActivePackageSourceAndProject()

6
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/UninstallPackageCmdletTests.cs

@ -15,7 +15,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
TestableUninstallPackageCmdlet cmdlet; TestableUninstallPackageCmdlet cmdlet;
FakeCmdletTerminatingError fakeTerminatingError; FakeCmdletTerminatingError fakeTerminatingError;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeUninstallPackageAction uninstallPackageAction; FakeUninstallPackageAction uninstallPackageAction;
void CreateCmdletWithoutActiveProject() void CreateCmdletWithoutActiveProject()
@ -23,8 +23,8 @@ namespace PackageManagement.Cmdlets.Tests
cmdlet = new TestableUninstallPackageCmdlet(); cmdlet = new TestableUninstallPackageCmdlet();
fakeTerminatingError = cmdlet.FakeCmdletTerminatingError; fakeTerminatingError = cmdlet.FakeCmdletTerminatingError;
fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost; fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost;
fakePackageManagementService = cmdlet.FakePackageManagementService; fakeSolution = cmdlet.FakeSolution;
uninstallPackageAction = fakePackageManagementService.ActionToReturnFromCreateUninstallPackageAction; uninstallPackageAction = fakeSolution.ActionToReturnFromCreateUninstallPackageAction;
} }
void CreateCmdletWithActivePackageSourceAndProject() void CreateCmdletWithActivePackageSourceAndProject()

6
src/AddIns/Misc/PackageManagement/Cmdlets/Test/Src/UpdatePackageCmdletTests.cs

@ -15,7 +15,7 @@ namespace PackageManagement.Cmdlets.Tests
{ {
TestableUpdatePackageCmdlet cmdlet; TestableUpdatePackageCmdlet cmdlet;
FakeCmdletTerminatingError fakeTerminatingError; FakeCmdletTerminatingError fakeTerminatingError;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeUpdatePackageAction fakeUpdatePackageAction; FakeUpdatePackageAction fakeUpdatePackageAction;
void CreateCmdletWithoutActiveProject() void CreateCmdletWithoutActiveProject()
@ -23,8 +23,8 @@ namespace PackageManagement.Cmdlets.Tests
cmdlet = new TestableUpdatePackageCmdlet(); cmdlet = new TestableUpdatePackageCmdlet();
fakeTerminatingError = cmdlet.FakeCmdletTerminatingError; fakeTerminatingError = cmdlet.FakeCmdletTerminatingError;
fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost; fakeConsoleHost = cmdlet.FakePackageManagementConsoleHost;
fakePackageManagementService = cmdlet.FakePackageManagementService; fakeSolution = cmdlet.FakeSolution;
fakeUpdatePackageAction = fakePackageManagementService.ActionToReturnFromCreateUpdatePackageAction; fakeUpdatePackageAction = fakeSolution.ActionToReturnFromCreateUpdatePackageAction;
} }
void CreateCmdletWithActivePackageSourceAndProject() void CreateCmdletWithActivePackageSourceAndProject()

4
src/AddIns/Misc/PackageManagement/Project/PackageManagement.csproj

@ -123,7 +123,7 @@
<Compile Include="Src\InstalledPackagesViewModel.cs" /> <Compile Include="Src\InstalledPackagesViewModel.cs" />
<Compile Include="Src\IPackageManagementFileService.cs" /> <Compile Include="Src\IPackageManagementFileService.cs" />
<Compile Include="Src\IPackageManagementProjectService.cs" /> <Compile Include="Src\IPackageManagementProjectService.cs" />
<Compile Include="Src\IPackageManagementService.cs" /> <Compile Include="Src\IPackageManagementSolution.cs" />
<Compile Include="Src\IPackageManagerFactory.cs" /> <Compile Include="Src\IPackageManagerFactory.cs" />
<Compile Include="Src\IPackageViewModelFactory.cs" /> <Compile Include="Src\IPackageViewModelFactory.cs" />
<Compile Include="Src\ISharpDevelopPackageManager.cs" /> <Compile Include="Src\ISharpDevelopPackageManager.cs" />
@ -149,7 +149,7 @@
<Compile Include="Src\PackageManagementOptionsViewModel.cs" /> <Compile Include="Src\PackageManagementOptionsViewModel.cs" />
<Compile Include="Src\PackageManagementProjectService.cs" /> <Compile Include="Src\PackageManagementProjectService.cs" />
<Compile Include="Src\PackageManagementEnumerableExtensions.cs" /> <Compile Include="Src\PackageManagementEnumerableExtensions.cs" />
<Compile Include="Src\PackageManagementService.cs" /> <Compile Include="Src\PackageManagementSolution.cs" />
<Compile Include="Src\PackageManagementTask.cs" /> <Compile Include="Src\PackageManagementTask.cs" />
<Compile Include="Src\PackageManagementTaskFactory.cs" /> <Compile Include="Src\PackageManagementTaskFactory.cs" />
<Compile Include="Src\PackageRepositoryPaths.cs" /> <Compile Include="Src\PackageRepositoryPaths.cs" />

12
src/AddIns/Misc/PackageManagement/Project/Src/AddPackageReferenceViewModel.cs

@ -10,20 +10,20 @@ namespace ICSharpCode.PackageManagement
{ {
public class AddPackageReferenceViewModel : ViewModelBase<AddPackageReferenceViewModel>, IDisposable public class AddPackageReferenceViewModel : ViewModelBase<AddPackageReferenceViewModel>, IDisposable
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IPackageManagementEvents packageManagementEvents; IPackageManagementEvents packageManagementEvents;
ILicenseAcceptanceService licenseAcceptanceService; ILicenseAcceptanceService licenseAcceptanceService;
string message; string message;
bool hasError; bool hasError;
public AddPackageReferenceViewModel( public AddPackageReferenceViewModel(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageManagementEvents packageManagementEvents, IPackageManagementEvents packageManagementEvents,
ILicenseAcceptanceService licenseAcceptanceService, ILicenseAcceptanceService licenseAcceptanceService,
ITaskFactory taskFactory) ITaskFactory taskFactory)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
this.packageManagementEvents = packageManagementEvents; this.packageManagementEvents = packageManagementEvents;
this.licenseAcceptanceService = licenseAcceptanceService; this.licenseAcceptanceService = licenseAcceptanceService;
@ -31,11 +31,11 @@ namespace ICSharpCode.PackageManagement
packageManagementEvents.PackageOperationsStarting += PackageOperationsStarting; packageManagementEvents.PackageOperationsStarting += PackageOperationsStarting;
packageManagementEvents.AcceptLicenses += AcceptLicenses; packageManagementEvents.AcceptLicenses += AcceptLicenses;
var packageViewModelFactory = new PackageViewModelFactory(packageManagementService, packageManagementEvents); var packageViewModelFactory = new PackageViewModelFactory(solution, packageManagementEvents);
AvailablePackagesViewModel = new AvailablePackagesViewModel(registeredPackageRepositories, packageViewModelFactory, taskFactory); AvailablePackagesViewModel = new AvailablePackagesViewModel(registeredPackageRepositories, packageViewModelFactory, taskFactory);
InstalledPackagesViewModel = new InstalledPackagesViewModel(packageManagementService, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory); InstalledPackagesViewModel = new InstalledPackagesViewModel(solution, packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
UpdatedPackagesViewModel = new UpdatedPackagesViewModel(packageManagementService, registeredPackageRepositories, packageViewModelFactory, taskFactory); UpdatedPackagesViewModel = new UpdatedPackagesViewModel(solution, registeredPackageRepositories, packageViewModelFactory, taskFactory);
RecentPackagesViewModel = new RecentPackagesViewModel(packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory); RecentPackagesViewModel = new RecentPackagesViewModel(packageManagementEvents, registeredPackageRepositories, packageViewModelFactory, taskFactory);
AvailablePackagesViewModel.ReadPackages(); AvailablePackagesViewModel.ReadPackages();

4
src/AddIns/Misc/PackageManagement/Project/Src/Design/DesignTimeLicenseAcceptanceViewModel.cs

@ -16,8 +16,8 @@ namespace ICSharpCode.PackageManagement.Design
static IEnumerable<IPackage> CreatePackages() static IEnumerable<IPackage> CreatePackages()
{ {
var packageManagementService = new DesignTimeRegisteredPackageRepositories(); var repositories = new DesignTimeRegisteredPackageRepositories();
return packageManagementService.FakeActiveRepository.FakePackages; return repositories.FakeActiveRepository.FakePackages;
} }
} }
} }

6
src/AddIns/Misc/PackageManagement/Project/Src/Design/DesignTimePackagesViewModel.cs

@ -11,16 +11,16 @@ namespace ICSharpCode.PackageManagement.Design
public class DesignTimePackagesViewModel : PackagesViewModel public class DesignTimePackagesViewModel : PackagesViewModel
{ {
public DesignTimePackagesViewModel() public DesignTimePackagesViewModel()
: this(new DesignTimeRegisteredPackageRepositories(), new FakePackageManagementService()) : this(new DesignTimeRegisteredPackageRepositories(), new FakePackageManagementSolution())
{ {
} }
public DesignTimePackagesViewModel( public DesignTimePackagesViewModel(
DesignTimeRegisteredPackageRepositories registeredPackageRepositories, DesignTimeRegisteredPackageRepositories registeredPackageRepositories,
FakePackageManagementService packageManagementService) FakePackageManagementSolution solution)
: base( : base(
registeredPackageRepositories, registeredPackageRepositories,
new PackageViewModelFactory(packageManagementService, null), new PackageViewModelFactory(solution, null),
new PackageManagementTaskFactory()) new PackageManagementTaskFactory())
{ {
PageSize = 3; PageSize = 3;

4
src/AddIns/Misc/PackageManagement/Project/Src/Design/FakePackageManagementService.cs

@ -10,11 +10,11 @@ using NuGet;
namespace ICSharpCode.PackageManagement.Design namespace ICSharpCode.PackageManagement.Design
{ {
public class FakePackageManagementService : IPackageManagementService public class FakePackageManagementSolution : IPackageManagementSolution
{ {
public FakeProjectManager FakeActiveProjectManager { get; set; } public FakeProjectManager FakeActiveProjectManager { get; set; }
public FakePackageManagementService() public FakePackageManagementSolution()
{ {
FakeActiveProjectManager = new FakeProjectManager(); FakeActiveProjectManager = new FakeProjectManager();
} }

2
src/AddIns/Misc/PackageManagement/Project/Src/IPackageManagementService.cs → src/AddIns/Misc/PackageManagement/Project/Src/IPackageManagementSolution.cs

@ -8,7 +8,7 @@ using NuGet;
namespace ICSharpCode.PackageManagement namespace ICSharpCode.PackageManagement
{ {
public interface IPackageManagementService public interface IPackageManagementSolution
{ {
ISharpDevelopProjectManager CreateProjectManager(IPackageRepository repository, MSBuildBasedProject project); ISharpDevelopProjectManager CreateProjectManager(IPackageRepository repository, MSBuildBasedProject project);
ISharpDevelopPackageManager CreatePackageManagerForActiveProject(); ISharpDevelopPackageManager CreatePackageManagerForActiveProject();

2
src/AddIns/Misc/PackageManagement/Project/Src/IPackageViewModelFactory.cs

@ -10,7 +10,7 @@ namespace ICSharpCode.PackageManagement
{ {
PackageViewModel CreatePackageViewModel(IPackageFromRepository package); PackageViewModel CreatePackageViewModel(IPackageFromRepository package);
IPackageManagementService PackageManagementService { get; } IPackageManagementSolution Solution { get; }
IPackageManagementEvents PackageManagementEvents { get; } IPackageManagementEvents PackageManagementEvents { get; }
} }
} }

4
src/AddIns/Misc/PackageManagement/Project/Src/InstallPackageAction.cs

@ -11,9 +11,9 @@ namespace ICSharpCode.PackageManagement
public class InstallPackageAction : ProcessPackageAction public class InstallPackageAction : ProcessPackageAction
{ {
public InstallPackageAction( public InstallPackageAction(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
: base(packageManagementService, packageManagementEvents) : base(solution, packageManagementEvents)
{ {
} }

8
src/AddIns/Misc/PackageManagement/Project/Src/InstalledPackagesViewModel.cs

@ -10,21 +10,21 @@ namespace ICSharpCode.PackageManagement
{ {
public class InstalledPackagesViewModel : PackagesViewModel public class InstalledPackagesViewModel : PackagesViewModel
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IPackageManagementEvents packageManagementEvents; IPackageManagementEvents packageManagementEvents;
IProjectManager projectManager; IProjectManager projectManager;
IPackageRepository repository; IPackageRepository repository;
string errorMessage = String.Empty; string errorMessage = String.Empty;
public InstalledPackagesViewModel( public InstalledPackagesViewModel(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents, IPackageManagementEvents packageManagementEvents,
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageViewModelFactory packageViewModelFactory, IPackageViewModelFactory packageViewModelFactory,
ITaskFactory taskFactory) ITaskFactory taskFactory)
: base(registeredPackageRepositories, packageViewModelFactory, taskFactory) : base(registeredPackageRepositories, packageViewModelFactory, taskFactory)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
this.packageManagementEvents = packageManagementEvents; this.packageManagementEvents = packageManagementEvents;
packageManagementEvents.ParentPackageInstalled += InstalledPackagesChanged; packageManagementEvents.ParentPackageInstalled += InstalledPackagesChanged;
packageManagementEvents.ParentPackageUninstalled += InstalledPackagesChanged; packageManagementEvents.ParentPackageUninstalled += InstalledPackagesChanged;
@ -35,7 +35,7 @@ namespace ICSharpCode.PackageManagement
void GetActiveProjectManager() void GetActiveProjectManager()
{ {
try { try {
this.projectManager = packageManagementService.ActiveProjectManager; this.projectManager = solution.ActiveProjectManager;
} catch (Exception ex) { } catch (Exception ex) {
errorMessage = ex.Message; errorMessage = ex.Message;
} }

8
src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementServices.cs

@ -9,7 +9,7 @@ namespace ICSharpCode.PackageManagement
public static class PackageManagementServices public static class PackageManagementServices
{ {
static readonly PackageManagementOptions options; static readonly PackageManagementOptions options;
static readonly PackageManagementService packageManagementService; static readonly PackageManagementSolution solution;
static readonly PackageManagementConsoleHost consoleHost = new PackageManagementConsoleHost(); static readonly PackageManagementConsoleHost consoleHost = new PackageManagementConsoleHost();
static readonly RegisteredPackageRepositories registeredPackageRepositories; static readonly RegisteredPackageRepositories registeredPackageRepositories;
static readonly PackageManagementEvents packageManagementEvents = new PackageManagementEvents(); static readonly PackageManagementEvents packageManagementEvents = new PackageManagementEvents();
@ -22,7 +22,7 @@ namespace ICSharpCode.PackageManagement
options = new PackageManagementOptions(); options = new PackageManagementOptions();
registeredPackageRepositories = new RegisteredPackageRepositories(options); registeredPackageRepositories = new RegisteredPackageRepositories(options);
outputMessagesView = new PackageManagementOutputMessagesView(packageManagementEvents); outputMessagesView = new PackageManagementOutputMessagesView(packageManagementEvents);
packageManagementService = new PackageManagementService(registeredPackageRepositories, packageManagementEvents); solution = new PackageManagementSolution(registeredPackageRepositories, packageManagementEvents);
projectBrowserRefresher = new ProjectBrowserRefresher(projectService, packageManagementEvents); projectBrowserRefresher = new ProjectBrowserRefresher(projectService, packageManagementEvents);
} }
@ -30,8 +30,8 @@ namespace ICSharpCode.PackageManagement
get { return options; } get { return options; }
} }
public static IPackageManagementService PackageManagementService { public static IPackageManagementSolution Solution {
get { return packageManagementService; } get { return solution; }
} }
public static IPackageManagementConsoleHost ConsoleHost { public static IPackageManagementConsoleHost ConsoleHost {

6
src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementService.cs → src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementSolution.cs

@ -10,14 +10,14 @@ using NuGet;
namespace ICSharpCode.PackageManagement namespace ICSharpCode.PackageManagement
{ {
public class PackageManagementService : IPackageManagementService public class PackageManagementSolution : IPackageManagementSolution
{ {
IRegisteredPackageRepositories registeredPackageRepositories; IRegisteredPackageRepositories registeredPackageRepositories;
IPackageManagerFactory packageManagerFactory; IPackageManagerFactory packageManagerFactory;
IPackageManagementProjectService projectService; IPackageManagementProjectService projectService;
IPackageManagementEvents packageManagementEvents; IPackageManagementEvents packageManagementEvents;
public PackageManagementService( public PackageManagementSolution(
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
: this( : this(
@ -28,7 +28,7 @@ namespace ICSharpCode.PackageManagement
{ {
} }
public PackageManagementService( public PackageManagementSolution(
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageManagerFactory packageManagerFactory, IPackageManagerFactory packageManagerFactory,
IPackageManagementEvents packageManagementEvents, IPackageManagementEvents packageManagementEvents,

18
src/AddIns/Misc/PackageManagement/Project/Src/PackageManagementViewModels.cs

@ -12,7 +12,7 @@ namespace ICSharpCode.PackageManagement
AddPackageReferenceViewModel addPackageReferenceViewModel; AddPackageReferenceViewModel addPackageReferenceViewModel;
PackageManagementOptionsViewModel packageManagementOptionsViewModel; PackageManagementOptionsViewModel packageManagementOptionsViewModel;
PackageManagementConsoleViewModel packageManagementConsoleViewModel; PackageManagementConsoleViewModel packageManagementConsoleViewModel;
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IRegisteredPackageRepositories registeredPackageRepositories; IRegisteredPackageRepositories registeredPackageRepositories;
public AddPackageReferenceViewModel AddPackageReferenceViewModel { public AddPackageReferenceViewModel AddPackageReferenceViewModel {
@ -25,23 +25,23 @@ namespace ICSharpCode.PackageManagement
void CreateAddPackageReferenceViewModel() void CreateAddPackageReferenceViewModel()
{ {
CreateRegisteredPackageRepositories(); CreateRegisteredPackageRepositories();
CreatePackageManagementService(); CreateSolution();
addPackageReferenceViewModel = addPackageReferenceViewModel =
new AddPackageReferenceViewModel( new AddPackageReferenceViewModel(
packageManagementService, solution,
registeredPackageRepositories, registeredPackageRepositories,
PackageManagementServices.PackageManagementEvents, PackageManagementServices.PackageManagementEvents,
new LicenseAcceptanceService(), new LicenseAcceptanceService(),
new PackageManagementTaskFactory()); new PackageManagementTaskFactory());
} }
void CreatePackageManagementService() void CreateSolution()
{ {
if (packageManagementService == null) { if (solution == null) {
if (IsInDesignMode()) { if (IsInDesignMode()) {
packageManagementService = new FakePackageManagementService(); solution = new FakePackageManagementSolution();
} else { } else {
packageManagementService = PackageManagementServices.PackageManagementService; solution = PackageManagementServices.Solution;
} }
} }
} }
@ -73,7 +73,7 @@ namespace ICSharpCode.PackageManagement
void CreatePackageManagementOptionsViewModel() void CreatePackageManagementOptionsViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
if (IsInDesignMode()) { if (IsInDesignMode()) {
packageManagementOptionsViewModel = new DesignTimePackageManagementOptionsViewModel(); packageManagementOptionsViewModel = new DesignTimePackageManagementOptionsViewModel();
} else { } else {
@ -92,7 +92,7 @@ namespace ICSharpCode.PackageManagement
void CreatePackageManagementConsoleViewModel() void CreatePackageManagementConsoleViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
var consoleHost = PackageManagementServices.ConsoleHost; var consoleHost = PackageManagementServices.ConsoleHost;
packageManagementConsoleViewModel = packageManagementConsoleViewModel =
new PackageManagementConsoleViewModel( new PackageManagementConsoleViewModel(

14
src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModel.cs

@ -14,7 +14,7 @@ namespace ICSharpCode.PackageManagement
DelegateCommand addPackageCommand; DelegateCommand addPackageCommand;
DelegateCommand removePackageCommand; DelegateCommand removePackageCommand;
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IPackageManagementEvents packageManagementEvents; IPackageManagementEvents packageManagementEvents;
IPackageFromRepository package; IPackageFromRepository package;
IEnumerable<PackageOperation> packageOperations = new PackageOperation[0]; IEnumerable<PackageOperation> packageOperations = new PackageOperation[0];
@ -22,12 +22,12 @@ namespace ICSharpCode.PackageManagement
public PackageViewModel( public PackageViewModel(
IPackageFromRepository package, IPackageFromRepository package,
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents, IPackageManagementEvents packageManagementEvents,
ILogger logger) ILogger logger)
{ {
this.package = package; this.package = package;
this.packageManagementService = packageManagementService; this.solution = solution;
this.packageManagementEvents = packageManagementEvents; this.packageManagementEvents = packageManagementEvents;
this.logger = CreateLogger(logger); this.logger = CreateLogger(logger);
@ -93,7 +93,7 @@ namespace ICSharpCode.PackageManagement
bool IsPackageInstalled(IPackage package) bool IsPackageInstalled(IPackage package)
{ {
return packageManagementService.ActiveProjectManager.IsInstalled(package); return solution.ActiveProjectManager.IsInstalled(package);
} }
public IEnumerable<PackageDependency> Dependencies { public IEnumerable<PackageDependency> Dependencies {
@ -165,7 +165,7 @@ namespace ICSharpCode.PackageManagement
ISharpDevelopPackageManager CreatePackageManagerForActiveProject() ISharpDevelopPackageManager CreatePackageManagerForActiveProject()
{ {
ISharpDevelopPackageManager packageManager = packageManagementService.CreatePackageManagerForActiveProject(); ISharpDevelopPackageManager packageManager = solution.CreatePackageManagerForActiveProject();
packageManager.Logger = logger; packageManager.Logger = logger;
return packageManager; return packageManager;
} }
@ -229,7 +229,7 @@ namespace ICSharpCode.PackageManagement
IPackageFromRepository package, IPackageFromRepository package,
IEnumerable<PackageOperation> packageOperations) IEnumerable<PackageOperation> packageOperations)
{ {
InstallPackageAction task = packageManagementService.CreateInstallPackageAction(); InstallPackageAction task = solution.CreateInstallPackageAction();
task.PackageRepository = package.Repository; task.PackageRepository = package.Repository;
task.Package = package; task.Package = package;
task.Operations = packageOperations; task.Operations = packageOperations;
@ -259,7 +259,7 @@ namespace ICSharpCode.PackageManagement
void TryUninstallingPackage() void TryUninstallingPackage()
{ {
try { try {
var action = packageManagementService.CreateUninstallPackageAction(); var action = solution.CreateUninstallPackageAction();
action.PackageRepository = package.Repository; action.PackageRepository = package.Repository;
action.Package = package; action.Package = package;
action.Execute(); action.Execute();

10
src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModelFactory.cs

@ -10,16 +10,16 @@ namespace ICSharpCode.PackageManagement
{ {
public PackageViewModelFactory(IPackageViewModelFactory packageViewModelFactory) public PackageViewModelFactory(IPackageViewModelFactory packageViewModelFactory)
: this( : this(
packageViewModelFactory.PackageManagementService, packageViewModelFactory.Solution,
packageViewModelFactory.PackageManagementEvents) packageViewModelFactory.PackageManagementEvents)
{ {
} }
public PackageViewModelFactory( public PackageViewModelFactory(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
{ {
this.PackageManagementService = packageManagementService; this.Solution = solution;
this.PackageManagementEvents = packageManagementEvents; this.PackageManagementEvents = packageManagementEvents;
this.Logger = new PackageManagementLogger(packageManagementEvents); this.Logger = new PackageManagementLogger(packageManagementEvents);
} }
@ -28,12 +28,12 @@ namespace ICSharpCode.PackageManagement
{ {
return new PackageViewModel( return new PackageViewModel(
package, package,
PackageManagementService, Solution,
PackageManagementEvents, PackageManagementEvents,
Logger); Logger);
} }
public IPackageManagementService PackageManagementService { get; private set; } public IPackageManagementSolution Solution { get; private set; }
public IPackageManagementEvents PackageManagementEvents { get; private set; } public IPackageManagementEvents PackageManagementEvents { get; private set; }
public ILogger Logger { get; private set; } public ILogger Logger { get; private set; }
} }

10
src/AddIns/Misc/PackageManagement/Project/Src/ProcessPackageAction.cs

@ -9,14 +9,14 @@ namespace ICSharpCode.PackageManagement
{ {
public abstract class ProcessPackageAction public abstract class ProcessPackageAction
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
IPackageManagementEvents packageManagementEvents; IPackageManagementEvents packageManagementEvents;
public ProcessPackageAction( public ProcessPackageAction(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
this.packageManagementEvents = packageManagementEvents; this.packageManagementEvents = packageManagementEvents;
} }
@ -67,9 +67,9 @@ namespace ICSharpCode.PackageManagement
void CreatePackageManager() void CreatePackageManager()
{ {
if (PackageRepository == null) { if (PackageRepository == null) {
PackageManager = packageManagementService.CreatePackageManager(PackageSource, Project); PackageManager = solution.CreatePackageManager(PackageSource, Project);
} else { } else {
PackageManager = packageManagementService.CreatePackageManagerForActiveProject(PackageRepository); PackageManager = solution.CreatePackageManagerForActiveProject(PackageRepository);
} }
} }

8
src/AddIns/Misc/PackageManagement/Project/Src/UninstallPackageAction.cs

@ -9,14 +9,14 @@ namespace ICSharpCode.PackageManagement
{ {
public class UninstallPackageAction : ProcessPackageAction public class UninstallPackageAction : ProcessPackageAction
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
public UninstallPackageAction( public UninstallPackageAction(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
: base(packageManagementService, packageManagementEvents) : base(solution, packageManagementEvents)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
} }
public bool ForceRemove { get; set; } public bool ForceRemove { get; set; }

4
src/AddIns/Misc/PackageManagement/Project/Src/UpdatePackageAction.cs

@ -10,9 +10,9 @@ namespace ICSharpCode.PackageManagement
public class UpdatePackageAction : ProcessPackageAction public class UpdatePackageAction : ProcessPackageAction
{ {
public UpdatePackageAction( public UpdatePackageAction(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents) IPackageManagementEvents packageManagementEvents)
: base(packageManagementService, packageManagementEvents) : base(solution, packageManagementEvents)
{ {
UpdateDependencies = true; UpdateDependencies = true;

10
src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackageViewModel.cs

@ -9,23 +9,23 @@ namespace ICSharpCode.PackageManagement
{ {
public class UpdatedPackageViewModel : PackageViewModel public class UpdatedPackageViewModel : PackageViewModel
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
public UpdatedPackageViewModel( public UpdatedPackageViewModel(
IPackageFromRepository package, IPackageFromRepository package,
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageManagementEvents packageManagementEvents, IPackageManagementEvents packageManagementEvents,
ILogger logger) ILogger logger)
: base(package, packageManagementService, packageManagementEvents, logger) : base(package, solution, packageManagementEvents, logger)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
} }
protected override void InstallPackage( protected override void InstallPackage(
IPackageFromRepository package, IPackageFromRepository package,
IEnumerable<PackageOperation> packageOperations) IEnumerable<PackageOperation> packageOperations)
{ {
var action = packageManagementService.CreateUpdatePackageAction(); var action = solution.CreateUpdatePackageAction();
action.PackageRepository = package.Repository; action.PackageRepository = package.Repository;
action.Package = package; action.Package = package;
action.Operations = packageOperations; action.Operations = packageOperations;

2
src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackageViewModelFactory.cs

@ -17,7 +17,7 @@ namespace ICSharpCode.PackageManagement
{ {
return new UpdatedPackageViewModel( return new UpdatedPackageViewModel(
package, package,
PackageManagementService, Solution,
PackageManagementEvents, PackageManagementEvents,
Logger); Logger);
} }

14
src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackages.cs

@ -12,24 +12,24 @@ namespace ICSharpCode.PackageManagement
{ {
public class UpdatedPackages public class UpdatedPackages
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
MSBuildBasedProject project; MSBuildBasedProject project;
IPackageRepository localRepository; IPackageRepository localRepository;
IPackageRepository sourceRepository; IPackageRepository sourceRepository;
public UpdatedPackages( public UpdatedPackages(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageRepository aggregateRepository) IPackageRepository aggregateRepository)
: this(packageManagementService, aggregateRepository, null) : this(solution, aggregateRepository, null)
{ {
} }
public UpdatedPackages( public UpdatedPackages(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IPackageRepository aggregateRepository, IPackageRepository aggregateRepository,
MSBuildBasedProject project) MSBuildBasedProject project)
{ {
this.packageManagementService = packageManagementService; this.solution = solution;
this.sourceRepository = aggregateRepository; this.sourceRepository = aggregateRepository;
this.project = project; this.project = project;
GetRepositories(); GetRepositories();
@ -68,9 +68,9 @@ namespace ICSharpCode.PackageManagement
IProjectManager CreateProjectManager() IProjectManager CreateProjectManager()
{ {
if (project != null) { if (project != null) {
return packageManagementService.CreateProjectManager(sourceRepository, project); return solution.CreateProjectManager(sourceRepository, project);
} }
return packageManagementService.ActiveProjectManager; return solution.ActiveProjectManager;
} }
} }
} }

12
src/AddIns/Misc/PackageManagement/Project/Src/UpdatedPackagesViewModel.cs

@ -11,17 +11,17 @@ namespace ICSharpCode.PackageManagement
{ {
public class UpdatedPackagesViewModel : PackagesViewModel public class UpdatedPackagesViewModel : PackagesViewModel
{ {
IPackageManagementService packageManagementService; IPackageManagementSolution solution;
UpdatedPackages updatedPackages; UpdatedPackages updatedPackages;
string errorMessage = String.Empty; string errorMessage = String.Empty;
public UpdatedPackagesViewModel( public UpdatedPackagesViewModel(
IPackageManagementService packageManagementService, IPackageManagementSolution solution,
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
IPackageViewModelFactory packageViewModelFactory, IPackageViewModelFactory packageViewModelFactory,
ITaskFactory taskFactory) ITaskFactory taskFactory)
: this( : this(
packageManagementService, solution,
registeredPackageRepositories, registeredPackageRepositories,
new UpdatedPackageViewModelFactory(packageViewModelFactory), new UpdatedPackageViewModelFactory(packageViewModelFactory),
taskFactory) taskFactory)
@ -29,7 +29,7 @@ namespace ICSharpCode.PackageManagement
} }
public UpdatedPackagesViewModel( public UpdatedPackagesViewModel(
IPackageManagementService packageManagementService, IPackageManagementSolution packageManagementService,
IRegisteredPackageRepositories registeredPackageRepositories, IRegisteredPackageRepositories registeredPackageRepositories,
UpdatedPackageViewModelFactory packageViewModelFactory, UpdatedPackageViewModelFactory packageViewModelFactory,
ITaskFactory taskFactory) ITaskFactory taskFactory)
@ -38,14 +38,14 @@ namespace ICSharpCode.PackageManagement
packageViewModelFactory, packageViewModelFactory,
taskFactory) taskFactory)
{ {
this.packageManagementService = packageManagementService; this.solution = packageManagementService;
} }
protected override void UpdateRepositoryBeforeReadPackagesTaskStarts() protected override void UpdateRepositoryBeforeReadPackagesTaskStarts()
{ {
try { try {
IPackageRepository aggregateRepository = RegisteredPackageRepositories.CreateAggregateRepository(); IPackageRepository aggregateRepository = RegisteredPackageRepositories.CreateAggregateRepository();
updatedPackages = new UpdatedPackages(packageManagementService, aggregateRepository); updatedPackages = new UpdatedPackages(solution, aggregateRepository);
} catch (Exception ex) { } catch (Exception ex) {
errorMessage = ex.Message; errorMessage = ex.Message;
} }

2
src/AddIns/Misc/PackageManagement/Test/PackageManagement.Tests.csproj

@ -145,7 +145,7 @@
<Compile Include="Src\PackageManagementOptionsTests.cs" /> <Compile Include="Src\PackageManagementOptionsTests.cs" />
<Compile Include="Src\PackageManagementOptionsViewModelTests.cs" /> <Compile Include="Src\PackageManagementOptionsViewModelTests.cs" />
<Compile Include="Src\PackageManagementOutputMessagesViewTests.cs" /> <Compile Include="Src\PackageManagementOutputMessagesViewTests.cs" />
<Compile Include="Src\PackageManagementServiceTests.cs" /> <Compile Include="Src\PackageManagementSolutionTests.cs" />
<Compile Include="Src\PackageRepositoryCacheTests.cs" /> <Compile Include="Src\PackageRepositoryCacheTests.cs" />
<Compile Include="Src\PackageRepositoryPathsTests.cs" /> <Compile Include="Src\PackageRepositoryPathsTests.cs" />
<Compile Include="Src\PackageSourceViewModelTests.cs" /> <Compile Include="Src\PackageSourceViewModelTests.cs" />

34
src/AddIns/Misc/PackageManagement/Test/Src/AddPackageReferenceViewModelTests.cs

@ -18,30 +18,30 @@ namespace PackageManagement.Tests
AddPackageReferenceViewModel viewModel; AddPackageReferenceViewModel viewModel;
PackageManagementEvents packageManagementEvents; PackageManagementEvents packageManagementEvents;
FakeLicenseAcceptanceService fakeLicenseAcceptanceSevice; FakeLicenseAcceptanceService fakeLicenseAcceptanceSevice;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories; FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories;
FakeTaskFactory taskFactory; FakeTaskFactory taskFactory;
List<FakePackage> packagesPassedToOnAcceptLicenses; List<FakePackage> packagesPassedToOnAcceptLicenses;
void CreatePackageManagementService() void CreateSolution()
{ {
fakePackageManagementService = new FakePackageManagementService(); fakeSolution = new FakePackageManagementSolution();
fakeRegisteredPackageRepositories = new FakeRegisteredPackageRepositories(); fakeRegisteredPackageRepositories = new FakeRegisteredPackageRepositories();
} }
void CreateViewModel() void CreateViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
CreateViewModel(fakePackageManagementService); CreateViewModel(fakeSolution);
} }
void CreateViewModel(FakePackageManagementService packageManagementService) void CreateViewModel(FakePackageManagementSolution solution)
{ {
taskFactory = new FakeTaskFactory(); taskFactory = new FakeTaskFactory();
packageManagementEvents = new PackageManagementEvents(); packageManagementEvents = new PackageManagementEvents();
fakeLicenseAcceptanceSevice = new FakeLicenseAcceptanceService(); fakeLicenseAcceptanceSevice = new FakeLicenseAcceptanceService();
viewModel = new AddPackageReferenceViewModel( viewModel = new AddPackageReferenceViewModel(
packageManagementService, solution,
fakeRegisteredPackageRepositories, fakeRegisteredPackageRepositories,
packageManagementEvents, packageManagementEvents,
fakeLicenseAcceptanceSevice, fakeLicenseAcceptanceSevice,
@ -91,12 +91,12 @@ namespace PackageManagement.Tests
[Test] [Test]
public void InstalledPackagesViewModel_ProjectHasOneInstalledPackage_HasOnePackageViewModel() public void InstalledPackagesViewModel_ProjectHasOneInstalledPackage_HasOnePackageViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
var projectManager = new FakeProjectManager(); var projectManager = new FakeProjectManager();
fakePackageManagementService.FakeActiveProjectManager = projectManager; fakeSolution.FakeActiveProjectManager = projectManager;
FakePackage package = new FakePackage(); FakePackage package = new FakePackage();
projectManager.FakeLocalRepository.FakePackages.Add(package); projectManager.FakeLocalRepository.FakePackages.Add(package);
CreateViewModel(fakePackageManagementService); CreateViewModel(fakeSolution);
IEnumerable<IPackage> expectedPackages = projectManager.FakeLocalRepository.FakePackages; IEnumerable<IPackage> expectedPackages = projectManager.FakeLocalRepository.FakePackages;
IEnumerable<PackageViewModel> actualPackageViewModels = viewModel.InstalledPackagesViewModel.PackageViewModels; IEnumerable<PackageViewModel> actualPackageViewModels = viewModel.InstalledPackagesViewModel.PackageViewModels;
@ -107,11 +107,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void AvailablePackagesViewModel_ActiveRepositoryHasOnePackage_HasOnePackageViewModel() public void AvailablePackagesViewModel_ActiveRepositoryHasOnePackage_HasOnePackageViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
var package = new FakePackage(); var package = new FakePackage();
package.Id = "Test"; package.Id = "Test";
fakeRegisteredPackageRepositories.FakeActiveRepository.FakePackages.Add(package); fakeRegisteredPackageRepositories.FakeActiveRepository.FakePackages.Add(package);
CreateViewModel(fakePackageManagementService); CreateViewModel(fakeSolution);
List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeActiveRepository.FakePackages; List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeActiveRepository.FakePackages;
@ -121,13 +121,13 @@ namespace PackageManagement.Tests
[Test] [Test]
public void PackageUpdatesViewModel_OneUpdatedPackageVersion_HasOnePackageViewModel() public void PackageUpdatesViewModel_OneUpdatedPackageVersion_HasOnePackageViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
var oldPackage = new FakePackage() { var oldPackage = new FakePackage() {
Id = "Test", Id = "Test",
Version = new Version("1.0.0.0") Version = new Version("1.0.0.0")
}; };
fakePackageManagementService.AddPackageToProjectLocalRepository(oldPackage); fakeSolution.AddPackageToProjectLocalRepository(oldPackage);
var newPackage = new FakePackage() { var newPackage = new FakePackage() {
Id = "Test", Id = "Test",
@ -135,7 +135,7 @@ namespace PackageManagement.Tests
}; };
fakeRegisteredPackageRepositories.FakeAggregateRepository.FakePackages.Add(newPackage); fakeRegisteredPackageRepositories.FakeAggregateRepository.FakePackages.Add(newPackage);
CreateViewModel(fakePackageManagementService); CreateViewModel(fakeSolution);
List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeAggregateRepository.FakePackages; List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeAggregateRepository.FakePackages;
@ -145,11 +145,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void RecentPackagesViewModel_RecentRepositoryHasOnePackage_HasOnePackageViewModel() public void RecentPackagesViewModel_RecentRepositoryHasOnePackage_HasOnePackageViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
var package = new FakePackage(); var package = new FakePackage();
package.Id = "Test"; package.Id = "Test";
fakeRegisteredPackageRepositories.FakeRecentPackageRepository.FakePackages.Add(package); fakeRegisteredPackageRepositories.FakeRecentPackageRepository.FakePackages.Add(package);
CreateViewModel(fakePackageManagementService); CreateViewModel(fakeSolution);
List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeRecentPackageRepository.FakePackages; List<FakePackage> expectedPackages = fakeRegisteredPackageRepositories.FakeRecentPackageRepository.FakePackages;

2
src/AddIns/Misc/PackageManagement/Test/Src/Helpers/ExceptionThrowingPackageManagementService.cs

@ -9,7 +9,7 @@ using NuGet;
namespace PackageManagement.Tests.Helpers namespace PackageManagement.Tests.Helpers
{ {
public class ExceptionThrowingPackageManagementService : FakePackageManagementService public class ExceptionThrowingPackageManagementSolution : FakePackageManagementSolution
{ {
public Exception ExeptionToThrowWhenActiveProjectManagerAccessed { get; set; } public Exception ExeptionToThrowWhenActiveProjectManagerAccessed { get; set; }
public Exception ExeptionToThrowWhenCreateInstallPackageTaskCalled { get; set; } public Exception ExeptionToThrowWhenCreateInstallPackageTaskCalled { get; set; }

8
src/AddIns/Misc/PackageManagement/Test/Src/Helpers/FakePackageViewModelFactory.cs

@ -10,7 +10,7 @@ namespace PackageManagement.Tests.Helpers
{ {
public class FakePackageViewModelFactory : IPackageViewModelFactory public class FakePackageViewModelFactory : IPackageViewModelFactory
{ {
public FakePackageManagementService FakePackageManagementService = new FakePackageManagementService(); public FakePackageManagementSolution FakeSolution = new FakePackageManagementSolution();
public FakePackageManagementEvents FakePackageManagementEvents = new FakePackageManagementEvents(); public FakePackageManagementEvents FakePackageManagementEvents = new FakePackageManagementEvents();
public FakeLogger FakeLogger = new FakeLogger(); public FakeLogger FakeLogger = new FakeLogger();
@ -18,13 +18,13 @@ namespace PackageManagement.Tests.Helpers
{ {
return new PackageViewModel( return new PackageViewModel(
package, package,
FakePackageManagementService, FakeSolution,
FakePackageManagementEvents, FakePackageManagementEvents,
FakeLogger); FakeLogger);
} }
public IPackageManagementService PackageManagementService { public IPackageManagementSolution Solution {
get { return FakePackageManagementService; } get { return FakeSolution; }
} }
public IPackageManagementEvents PackageManagementEvents { public IPackageManagementEvents PackageManagementEvents {

16
src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestablePackageViewModel.cs

@ -10,15 +10,15 @@ namespace PackageManagement.Tests.Helpers
{ {
public class TestablePackageViewModel : PackageViewModel public class TestablePackageViewModel : PackageViewModel
{ {
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public FakePackageManagementEvents FakePackageManagementEvents; public FakePackageManagementEvents FakePackageManagementEvents;
public FakePackage FakePackage; public FakePackage FakePackage;
public FakeLogger FakeLogger; public FakeLogger FakeLogger;
public TestablePackageViewModel(FakePackageManagementService packageManagementService) public TestablePackageViewModel(FakePackageManagementSolution solution)
: this( : this(
new FakePackage(), new FakePackage(),
packageManagementService, solution,
new FakePackageManagementEvents(), new FakePackageManagementEvents(),
new FakeLogger()) new FakeLogger())
{ {
@ -26,17 +26,17 @@ namespace PackageManagement.Tests.Helpers
public TestablePackageViewModel( public TestablePackageViewModel(
FakePackage package, FakePackage package,
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementEvents packageManagementEvents, FakePackageManagementEvents packageManagementEvents,
FakeLogger logger) FakeLogger logger)
: base( : base(
package, package,
packageManagementService, solution,
packageManagementEvents, packageManagementEvents,
logger) logger)
{ {
this.FakePackage = package; this.FakePackage = package;
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakePackageManagementEvents = packageManagementEvents; this.FakePackageManagementEvents = packageManagementEvents;
this.FakeLogger = logger; this.FakeLogger = logger;
} }
@ -56,7 +56,7 @@ namespace PackageManagement.Tests.Helpers
{ {
var operation = new PackageOperation(FakePackage, PackageAction.Install); var operation = new PackageOperation(FakePackage, PackageAction.Install);
FakePackageManagementService FakeSolution
.FakePackageManagerToReturnFromCreatePackageManager .FakePackageManagerToReturnFromCreatePackageManager
.PackageOperationsToReturnFromGetInstallPackageOperations .PackageOperationsToReturnFromGetInstallPackageOperations
.Add(operation); .Add(operation);
@ -69,7 +69,7 @@ namespace PackageManagement.Tests.Helpers
var package = new FakePackage("PackageToUninstall"); var package = new FakePackage("PackageToUninstall");
var operation = new PackageOperation(package, PackageAction.Uninstall); var operation = new PackageOperation(package, PackageAction.Uninstall);
FakePackageManagementService FakeSolution
.FakePackageManagerToReturnFromCreatePackageManager .FakePackageManagerToReturnFromCreatePackageManager
.PackageOperationsToReturnFromGetInstallPackageOperations .PackageOperationsToReturnFromGetInstallPackageOperations
.Add(operation); .Add(operation);

10
src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableProcessPackageAction.cs

@ -9,22 +9,22 @@ namespace PackageManagement.Tests.Helpers
{ {
public class TestableProcessPackageAction : ProcessPackageAction public class TestableProcessPackageAction : ProcessPackageAction
{ {
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public FakePackageManagementEvents FakePackageManagementEvents; public FakePackageManagementEvents FakePackageManagementEvents;
public FakePackageRepository FakePackageRepository = new FakePackageRepository(); public FakePackageRepository FakePackageRepository = new FakePackageRepository();
public FakePackage FakePackage = new FakePackage("Test"); public FakePackage FakePackage = new FakePackage("Test");
public TestableProcessPackageAction() public TestableProcessPackageAction()
: this(new FakePackageManagementService(), new FakePackageManagementEvents()) : this(new FakePackageManagementSolution(), new FakePackageManagementEvents())
{ {
} }
public TestableProcessPackageAction( public TestableProcessPackageAction(
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementEvents packageManagementEvents) FakePackageManagementEvents packageManagementEvents)
: base(packageManagementService, packageManagementEvents) : base(solution, packageManagementEvents)
{ {
FakePackageManagementService = packageManagementService; FakeSolution = solution;
FakePackageManagementEvents = packageManagementEvents; FakePackageManagementEvents = packageManagementEvents;
this.PackageRepository = FakePackageRepository; this.PackageRepository = FakePackageRepository;
this.Package = FakePackage; this.Package = FakePackage;

14
src/AddIns/Misc/PackageManagement/Test/Src/Helpers/TestableUpdatedPackageViewModel.cs

@ -11,21 +11,21 @@ namespace PackageManagement.Tests.Helpers
public class TestableUpdatedPackageViewModel : UpdatedPackageViewModel public class TestableUpdatedPackageViewModel : UpdatedPackageViewModel
{ {
public FakePackageOperationResolver FakePackageOperationResolver = new FakePackageOperationResolver(); public FakePackageOperationResolver FakePackageOperationResolver = new FakePackageOperationResolver();
public FakePackageManagementService FakePackageManagementService; public FakePackageManagementSolution FakeSolution;
public FakePackageManagementEvents FakePackageManagementEvents; public FakePackageManagementEvents FakePackageManagementEvents;
public FakePackage FakePackage; public FakePackage FakePackage;
public FakeLogger FakeLogger; public FakeLogger FakeLogger;
public ILogger LoggerUsedWhenCreatingPackageResolver; public ILogger LoggerUsedWhenCreatingPackageResolver;
public TestableUpdatedPackageViewModel() public TestableUpdatedPackageViewModel()
: this(new FakePackageManagementService()) : this(new FakePackageManagementSolution())
{ {
} }
public TestableUpdatedPackageViewModel(FakePackageManagementService packageManagementService) public TestableUpdatedPackageViewModel(FakePackageManagementSolution solution)
: this( : this(
new FakePackage(), new FakePackage(),
packageManagementService, solution,
new FakePackageManagementEvents(), new FakePackageManagementEvents(),
new FakeLogger()) new FakeLogger())
{ {
@ -33,17 +33,17 @@ namespace PackageManagement.Tests.Helpers
public TestableUpdatedPackageViewModel( public TestableUpdatedPackageViewModel(
FakePackage package, FakePackage package,
FakePackageManagementService packageManagementService, FakePackageManagementSolution solution,
FakePackageManagementEvents packageManagementEvents, FakePackageManagementEvents packageManagementEvents,
FakeLogger logger) FakeLogger logger)
: base( : base(
package, package,
packageManagementService, solution,
packageManagementEvents, packageManagementEvents,
logger) logger)
{ {
this.FakePackage = package; this.FakePackage = package;
this.FakePackageManagementService = packageManagementService; this.FakeSolution = solution;
this.FakeLogger = logger; this.FakeLogger = logger;
} }
} }

14
src/AddIns/Misc/PackageManagement/Test/Src/InstallPackageActionTests.cs

@ -12,7 +12,7 @@ namespace PackageManagement.Tests
[TestFixture] [TestFixture]
public class InstallPackageActionTests public class InstallPackageActionTests
{ {
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakePackageManagementEvents fakePackageManagementEvents; FakePackageManagementEvents fakePackageManagementEvents;
FakePackageManager fakePackageManager; FakePackageManager fakePackageManager;
InstallPackageAction action; InstallPackageAction action;
@ -20,10 +20,10 @@ namespace PackageManagement.Tests
void CreateAction() void CreateAction()
{ {
fakePackageManagementService = new FakePackageManagementService(); fakeSolution = new FakePackageManagementSolution();
fakePackageManagementEvents = new FakePackageManagementEvents(); fakePackageManagementEvents = new FakePackageManagementEvents();
fakePackageManager = fakePackageManagementService.FakePackageManagerToReturnFromCreatePackageManager; fakePackageManager = fakeSolution.FakePackageManagerToReturnFromCreatePackageManager;
action = new InstallPackageAction(fakePackageManagementService, fakePackageManagementEvents); action = new InstallPackageAction(fakeSolution, fakePackageManagementEvents);
installPackageHelper = new InstallPackageHelper(action); installPackageHelper = new InstallPackageHelper(action);
} }
@ -59,7 +59,7 @@ namespace PackageManagement.Tests
installPackageHelper.InstallPackageById("PackageId"); installPackageHelper.InstallPackageById("PackageId");
var expectedPackageSource = installPackageHelper.PackageSource; var expectedPackageSource = installPackageHelper.PackageSource;
var actualPackageSource = fakePackageManagementService.PackageSourcePassedToCreatePackageManager; var actualPackageSource = fakeSolution.PackageSourcePassedToCreatePackageManager;
Assert.AreEqual(expectedPackageSource, actualPackageSource); Assert.AreEqual(expectedPackageSource, actualPackageSource);
} }
@ -78,7 +78,7 @@ namespace PackageManagement.Tests
installPackageHelper.InstallTestPackage(); installPackageHelper.InstallTestPackage();
var expectedRepository = installPackageHelper.PackageRepository; var expectedRepository = installPackageHelper.PackageRepository;
var actualRepository = fakePackageManagementService.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakeSolution.PackageRepositoryPassedToCreatePackageManager;
Assert.AreEqual(expectedRepository, actualRepository); Assert.AreEqual(expectedRepository, actualRepository);
} }
@ -141,7 +141,7 @@ namespace PackageManagement.Tests
CreateAction(); CreateAction();
installPackageHelper.InstallPackageById("PackageId"); installPackageHelper.InstallPackageById("PackageId");
var actualProject = fakePackageManagementService.ProjectPassedToCreatePackageManager; var actualProject = fakeSolution.ProjectPassedToCreatePackageManager;
var expectedProject = installPackageHelper.TestableProject; var expectedProject = installPackageHelper.TestableProject;
Assert.AreEqual(expectedProject, actualProject); Assert.AreEqual(expectedProject, actualProject);

40
src/AddIns/Misc/PackageManagement/Test/Src/InstalledPackagesViewModelTests.cs

@ -14,30 +14,30 @@ namespace PackageManagement.Tests
public class InstalledPackagesViewModelTests public class InstalledPackagesViewModelTests
{ {
InstalledPackagesViewModel viewModel; InstalledPackagesViewModel viewModel;
FakePackageManagementService packageManagementService; FakePackageManagementSolution solution;
PackageManagementEvents packageManagementEvents; PackageManagementEvents packageManagementEvents;
FakeRegisteredPackageRepositories registeredPackageRepositories; FakeRegisteredPackageRepositories registeredPackageRepositories;
ExceptionThrowingPackageManagementService exceptionThrowingPackageManagementService; ExceptionThrowingPackageManagementSolution exceptionThrowingSolution;
FakeTaskFactory taskFactory; FakeTaskFactory taskFactory;
void CreateViewModel() void CreateViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
CreateViewModel(packageManagementService); CreateViewModel(solution);
} }
void CreatePackageManagementService() void CreateSolution()
{ {
packageManagementService = new FakePackageManagementService(); solution = new FakePackageManagementSolution();
registeredPackageRepositories = new FakeRegisteredPackageRepositories(); registeredPackageRepositories = new FakeRegisteredPackageRepositories();
} }
void CreateExceptionThrowingPackageManagementService() void CreateExceptionThrowingSolution()
{ {
exceptionThrowingPackageManagementService = new ExceptionThrowingPackageManagementService(); exceptionThrowingSolution = new ExceptionThrowingPackageManagementSolution();
} }
void CreateViewModel(FakePackageManagementService packageManagementService) void CreateViewModel(FakePackageManagementSolution solution)
{ {
registeredPackageRepositories = new FakeRegisteredPackageRepositories(); registeredPackageRepositories = new FakeRegisteredPackageRepositories();
var packageViewModelFactory = new FakePackageViewModelFactory(); var packageViewModelFactory = new FakePackageViewModelFactory();
@ -45,7 +45,7 @@ namespace PackageManagement.Tests
packageManagementEvents = new PackageManagementEvents(); packageManagementEvents = new PackageManagementEvents();
viewModel = new InstalledPackagesViewModel( viewModel = new InstalledPackagesViewModel(
packageManagementService, solution,
packageManagementEvents, packageManagementEvents,
registeredPackageRepositories, registeredPackageRepositories,
packageViewModelFactory, packageViewModelFactory,
@ -65,7 +65,7 @@ namespace PackageManagement.Tests
FakePackage AddPackageToProjectManagerLocalPackageRepository() FakePackage AddPackageToProjectManagerLocalPackageRepository()
{ {
var package = new FakePackage("Test"); var package = new FakePackage("Test");
FakePackageRepository repository = packageManagementService.FakeActiveProjectManager.FakeLocalRepository; FakePackageRepository repository = solution.FakeActiveProjectManager.FakeLocalRepository;
repository.FakePackages.Add(package); repository.FakePackages.Add(package);
return package; return package;
} }
@ -94,7 +94,7 @@ namespace PackageManagement.Tests
viewModel.ReadPackages(); viewModel.ReadPackages();
CompleteReadPackagesTask(); CompleteReadPackagesTask();
packageManagementService.FakeActiveProjectManager.FakeLocalRepository.FakePackages.Clear(); solution.FakeActiveProjectManager.FakeLocalRepository.FakePackages.Clear();
ClearReadPackagesTasks(); ClearReadPackagesTasks();
packageManagementEvents.OnParentPackageUninstalled(new FakePackage()); packageManagementEvents.OnParentPackageUninstalled(new FakePackage());
@ -106,9 +106,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void ReadPackages_ActiveProjectManagerThrowsException_ErrorMessageFromExceptionNotOverriddenByReadPackagesCall() public void ReadPackages_ActiveProjectManagerThrowsException_ErrorMessageFromExceptionNotOverriddenByReadPackagesCall()
{ {
CreateExceptionThrowingPackageManagementService(); CreateExceptionThrowingSolution();
exceptionThrowingPackageManagementService.ExeptionToThrowWhenActiveProjectManagerAccessed = new Exception("Test"); exceptionThrowingSolution.ExeptionToThrowWhenActiveProjectManagerAccessed = new Exception("Test");
CreateViewModel(exceptionThrowingPackageManagementService); CreateViewModel(exceptionThrowingSolution);
viewModel.ReadPackages(); viewModel.ReadPackages();
ApplicationException ex = Assert.Throws<ApplicationException>(() => CompleteReadPackagesTask()); ApplicationException ex = Assert.Throws<ApplicationException>(() => CompleteReadPackagesTask());
@ -118,12 +118,12 @@ namespace PackageManagement.Tests
[Test] [Test]
public void ReadPackages_OnePackageInLocalRepository_RepositoryIsNotCreatedByBackgroundThread() public void ReadPackages_OnePackageInLocalRepository_RepositoryIsNotCreatedByBackgroundThread()
{ {
CreatePackageManagementService(); CreateSolution();
packageManagementService.AddPackageToProjectLocalRepository(new FakePackage()); solution.AddPackageToProjectLocalRepository(new FakePackage());
CreateViewModel(packageManagementService); CreateViewModel(solution);
viewModel.ReadPackages(); viewModel.ReadPackages();
packageManagementService.FakeActiveProjectManager.FakeLocalRepository = null; solution.FakeActiveProjectManager.FakeLocalRepository = null;
CompleteReadPackagesTask(); CompleteReadPackagesTask();
Assert.AreEqual(1, viewModel.PackageViewModels.Count); Assert.AreEqual(1, viewModel.PackageViewModels.Count);
@ -153,7 +153,7 @@ namespace PackageManagement.Tests
viewModel.ReadPackages(); viewModel.ReadPackages();
CompleteReadPackagesTask(); CompleteReadPackagesTask();
packageManagementService.FakeActiveProjectManager.FakeLocalRepository.FakePackages.Clear(); solution.FakeActiveProjectManager.FakeLocalRepository.FakePackages.Clear();
ClearReadPackagesTasks(); ClearReadPackagesTasks();
viewModel.Dispose(); viewModel.Dispose();

66
src/AddIns/Misc/PackageManagement/Test/Src/PackageManagementServiceTests.cs → src/AddIns/Misc/PackageManagement/Test/Src/PackageManagementSolutionTests.cs

@ -15,9 +15,9 @@ using PackageManagement.Tests.Helpers;
namespace PackageManagement.Tests namespace PackageManagement.Tests
{ {
[TestFixture] [TestFixture]
public class PackageManagementServiceTests public class PackageManagementSolutionTests
{ {
PackageManagementService packageManagementService; PackageManagementSolution solution;
FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories; FakeRegisteredPackageRepositories fakeRegisteredPackageRepositories;
OneRegisteredPackageSourceHelper packageSourcesHelper; OneRegisteredPackageSourceHelper packageSourcesHelper;
FakePackageManagerFactory fakePackageManagerFactory; FakePackageManagerFactory fakePackageManagerFactory;
@ -29,13 +29,13 @@ namespace PackageManagement.Tests
packageSourcesHelper = new OneRegisteredPackageSourceHelper(); packageSourcesHelper = new OneRegisteredPackageSourceHelper();
} }
void CreatePackageManagementService() void CreateSolution()
{ {
CreatePackageSources(); CreatePackageSources();
CreatePackageManagementService(packageSourcesHelper.Options); CreateSolution(packageSourcesHelper.Options);
} }
void CreatePackageManagementService(PackageManagementOptions options) void CreateSolution(PackageManagementOptions options)
{ {
testProject = ProjectHelper.CreateTestProject(); testProject = ProjectHelper.CreateTestProject();
fakeRegisteredPackageRepositories = new FakeRegisteredPackageRepositories(); fakeRegisteredPackageRepositories = new FakeRegisteredPackageRepositories();
@ -44,8 +44,8 @@ namespace PackageManagement.Tests
var packageManagementEvents = new FakePackageManagementEvents(); var packageManagementEvents = new FakePackageManagementEvents();
fakeProjectService.CurrentProject = testProject; fakeProjectService.CurrentProject = testProject;
packageManagementService = solution =
new PackageManagementService( new PackageManagementSolution(
fakeRegisteredPackageRepositories, fakeRegisteredPackageRepositories,
fakePackageManagerFactory, fakePackageManagerFactory,
packageManagementEvents, packageManagementEvents,
@ -78,9 +78,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void ActiveProjectManager_ProjectIsSelected_ReferencesSelectedProject() public void ActiveProjectManager_ProjectIsSelected_ReferencesSelectedProject()
{ {
CreatePackageManagementService(); CreateSolution();
IProjectManager activeProjectManager = packageManagementService.ActiveProjectManager; IProjectManager activeProjectManager = solution.ActiveProjectManager;
IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository; IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository;
Assert.AreEqual(testProject, actualProject); Assert.AreEqual(testProject, actualProject);
@ -89,11 +89,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreateProjectManager_RepositoryAndProjectSpecified_CreatesPackageManagerFromPackageManagerFactory() public void CreateProjectManager_RepositoryAndProjectSpecified_CreatesPackageManagerFromPackageManagerFactory()
{ {
CreatePackageManagementService(); CreateSolution();
var repository = new FakePackageRepository(); var repository = new FakePackageRepository();
var project = ProjectHelper.CreateTestProject(); var project = ProjectHelper.CreateTestProject();
ISharpDevelopProjectManager projectManager = packageManagementService.CreateProjectManager(repository, project); ISharpDevelopProjectManager projectManager = solution.CreateProjectManager(repository, project);
var expectedProjectManager = fakePackageManagerFactory.FakePackageManager.FakeProjectManager; var expectedProjectManager = fakePackageManagerFactory.FakePackageManager.FakeProjectManager;
Assert.AreEqual(expectedProjectManager, projectManager); Assert.AreEqual(expectedProjectManager, projectManager);
@ -102,10 +102,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreateProjectManager_RepositorySpecified_RepositoryUsedToCreateProjectManager() public void CreateProjectManager_RepositorySpecified_RepositoryUsedToCreateProjectManager()
{ {
CreatePackageManagementService(); CreateSolution();
var repository = new FakePackageRepository(); var repository = new FakePackageRepository();
packageManagementService.CreateProjectManager(repository, null); solution.CreateProjectManager(repository, null);
var expectedRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager; var expectedRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager;
@ -115,10 +115,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreateProjectManager_ProjectSpecified_ProjectUsedToCreateProjectManager() public void CreateProjectManager_ProjectSpecified_ProjectUsedToCreateProjectManager()
{ {
CreatePackageManagementService(); CreateSolution();
var project = ProjectHelper.CreateTestProject(); var project = ProjectHelper.CreateTestProject();
packageManagementService.CreateProjectManager(null, project); solution.CreateProjectManager(null, project);
var expectedProject = fakePackageManagerFactory.ProjectPassedToCreateRepository; var expectedProject = fakePackageManagerFactory.ProjectPassedToCreateRepository;
@ -128,9 +128,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManagerForActiveProject_ProjectIsSelected_ReferencesSelectedProject() public void CreatePackageManagerForActiveProject_ProjectIsSelected_ReferencesSelectedProject()
{ {
CreatePackageManagementService(); CreateSolution();
packageManagementService.CreatePackageManagerForActiveProject(); solution.CreatePackageManagerForActiveProject();
IProject expectedProject = fakeProjectService.CurrentProject; IProject expectedProject = fakeProjectService.CurrentProject;
IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository; IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository;
@ -141,10 +141,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManagerForActiveProject_PackageRepositoryPassed_CreatesPackageManagerWithCurrentlyActiveProject() public void CreatePackageManagerForActiveProject_PackageRepositoryPassed_CreatesPackageManagerWithCurrentlyActiveProject()
{ {
CreatePackageManagementService(); CreateSolution();
var repository = new FakePackageRepository(); var repository = new FakePackageRepository();
packageManagementService.CreatePackageManagerForActiveProject(repository); solution.CreatePackageManagerForActiveProject(repository);
IProject expectedProject = fakeProjectService.CurrentProject; IProject expectedProject = fakeProjectService.CurrentProject;
IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository; IProject actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository;
@ -155,10 +155,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManagerForActiveProject_PackageRepositoryPassed_PackageManagerCreatedWithRepository() public void CreatePackageManagerForActiveProject_PackageRepositoryPassed_PackageManagerCreatedWithRepository()
{ {
CreatePackageManagementService(); CreateSolution();
var repository = new FakePackageRepository(); var repository = new FakePackageRepository();
packageManagementService.CreatePackageManagerForActiveProject(repository); solution.CreatePackageManagerForActiveProject(repository);
var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager;
@ -168,9 +168,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManagerForActiveProject_ProjectIsSelected_UsesActiveRepository() public void CreatePackageManagerForActiveProject_ProjectIsSelected_UsesActiveRepository()
{ {
CreatePackageManagementService(); CreateSolution();
packageManagementService.CreatePackageManagerForActiveProject(); solution.CreatePackageManagerForActiveProject();
var expectedRepository = fakeRegisteredPackageRepositories.ActiveRepository; var expectedRepository = fakeRegisteredPackageRepositories.ActiveRepository;
var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager;
@ -181,10 +181,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManagerForActiveProject_ProjectIsSelected_ReturnsPackageManager() public void CreatePackageManagerForActiveProject_ProjectIsSelected_ReturnsPackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
ISharpDevelopPackageManager packageManager = ISharpDevelopPackageManager packageManager =
packageManagementService.CreatePackageManagerForActiveProject(); solution.CreatePackageManagerForActiveProject();
var expectedPackageManager = fakePackageManagerFactory.FakePackageManager; var expectedPackageManager = fakePackageManagerFactory.FakePackageManager;
@ -194,11 +194,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManager_PackageSourceAndProjectPassed_ReturnsNewPackageManager() public void CreatePackageManager_PackageSourceAndProjectPassed_ReturnsNewPackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
var packageSource = new PackageSource("test"); var packageSource = new PackageSource("test");
ISharpDevelopPackageManager packageManager = ISharpDevelopPackageManager packageManager =
packageManagementService.CreatePackageManager(packageSource, testProject); solution.CreatePackageManager(packageSource, testProject);
var expectedPackageManager = fakePackageManagerFactory.FakePackageManager; var expectedPackageManager = fakePackageManagerFactory.FakePackageManager;
@ -208,11 +208,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManager_PackageSourceAndProjectPassed_PackageSourceUsedToCreateRepository() public void CreatePackageManager_PackageSourceAndProjectPassed_PackageSourceUsedToCreateRepository()
{ {
CreatePackageManagementService(); CreateSolution();
var packageSource = new PackageSource("test"); var packageSource = new PackageSource("test");
ISharpDevelopPackageManager packageManager = ISharpDevelopPackageManager packageManager =
packageManagementService.CreatePackageManager(packageSource, testProject); solution.CreatePackageManager(packageSource, testProject);
var actualPackageSource = fakeRegisteredPackageRepositories.PackageSourcePassedToCreateRepository; var actualPackageSource = fakeRegisteredPackageRepositories.PackageSourcePassedToCreateRepository;
@ -222,11 +222,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManager_PackageSourceAndProjectPassed_CreatedRepositoryUsedToCreatePackageManager() public void CreatePackageManager_PackageSourceAndProjectPassed_CreatedRepositoryUsedToCreatePackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
var packageSource = new PackageSource("test"); var packageSource = new PackageSource("test");
ISharpDevelopPackageManager packageManager = ISharpDevelopPackageManager packageManager =
packageManagementService.CreatePackageManager(packageSource, testProject); solution.CreatePackageManager(packageSource, testProject);
var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakePackageManagerFactory.PackageRepositoryPassedToCreatePackageManager;
var expectedRepository = fakeRegisteredPackageRepositories.FakePackageRepository; var expectedRepository = fakeRegisteredPackageRepositories.FakePackageRepository;
@ -237,11 +237,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void CreatePackageManager_PackageSourceAndProjectPassed_ProjectUsedToCreatePackageManager() public void CreatePackageManager_PackageSourceAndProjectPassed_ProjectUsedToCreatePackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
var packageSource = new PackageSource("test"); var packageSource = new PackageSource("test");
ISharpDevelopPackageManager packageManager = ISharpDevelopPackageManager packageManager =
packageManagementService.CreatePackageManager(packageSource, testProject); solution.CreatePackageManager(packageSource, testProject);
var actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository; var actualProject = fakePackageManagerFactory.ProjectPassedToCreateRepository;

54
src/AddIns/Misc/PackageManagement/Test/Src/PackageViewModelTests.cs

@ -15,34 +15,34 @@ namespace PackageManagement.Tests
{ {
TestablePackageViewModel viewModel; TestablePackageViewModel viewModel;
FakePackage package; FakePackage package;
FakePackageManagementService packageManagementService; FakePackageManagementSolution solution;
FakePackageManagementEvents packageManagementEvents; FakePackageManagementEvents packageManagementEvents;
ExceptionThrowingPackageManagementService exceptionThrowingPackageManagementService; ExceptionThrowingPackageManagementSolution exceptionThrowingSolution;
FakeInstallPackageAction fakeInstallPackageTask; FakeInstallPackageAction fakeInstallPackageTask;
FakeUninstallPackageAction fakeUninstallPackageAction; FakeUninstallPackageAction fakeUninstallPackageAction;
FakeLogger fakeLogger; FakeLogger fakeLogger;
void CreateViewModel() void CreateViewModel()
{ {
packageManagementService = new FakePackageManagementService(); solution = new FakePackageManagementSolution();
CreateViewModel(packageManagementService); CreateViewModel(solution);
} }
void CreateViewModelWithExceptionThrowingPackageManagementService() void CreateViewModelWithExceptionThrowingSolution()
{ {
exceptionThrowingPackageManagementService = new ExceptionThrowingPackageManagementService(); exceptionThrowingSolution = new ExceptionThrowingPackageManagementSolution();
CreateViewModel(exceptionThrowingPackageManagementService); CreateViewModel(exceptionThrowingSolution);
} }
void CreateViewModel(FakePackageManagementService packageManagementService) void CreateViewModel(FakePackageManagementSolution solution)
{ {
viewModel = new TestablePackageViewModel(packageManagementService); viewModel = new TestablePackageViewModel(solution);
package = viewModel.FakePackage; package = viewModel.FakePackage;
this.packageManagementService = packageManagementService; this.solution = solution;
packageManagementEvents = viewModel.FakePackageManagementEvents; packageManagementEvents = viewModel.FakePackageManagementEvents;
fakeLogger = viewModel.FakeLogger; fakeLogger = viewModel.FakeLogger;
fakeInstallPackageTask = packageManagementService.ActionToReturnFromCreateInstallPackageAction; fakeInstallPackageTask = solution.ActionToReturnFromCreateInstallPackageAction;
fakeUninstallPackageAction = packageManagementService.ActionToReturnFromCreateUninstallPackageAction; fakeUninstallPackageAction = solution.ActionToReturnFromCreateUninstallPackageAction;
} }
[Test] [Test]
@ -176,7 +176,7 @@ namespace PackageManagement.Tests
public void IsAdded_ProjectHasPackageAdded_ReturnsTrue() public void IsAdded_ProjectHasPackageAdded_ReturnsTrue()
{ {
CreateViewModel(); CreateViewModel();
packageManagementService.FakeActiveProjectManager.IsInstalledReturnValue = true; solution.FakeActiveProjectManager.IsInstalledReturnValue = true;
Assert.IsTrue(viewModel.IsAdded); Assert.IsTrue(viewModel.IsAdded);
} }
@ -185,7 +185,7 @@ namespace PackageManagement.Tests
public void IsAdded_ProjectDoesNotHavePackageInstalled_ReturnsFalse() public void IsAdded_ProjectDoesNotHavePackageInstalled_ReturnsFalse()
{ {
CreateViewModel(); CreateViewModel();
packageManagementService.FakeActiveProjectManager.IsInstalledReturnValue = false; solution.FakeActiveProjectManager.IsInstalledReturnValue = false;
Assert.IsFalse(viewModel.IsAdded); Assert.IsFalse(viewModel.IsAdded);
} }
@ -364,7 +364,7 @@ namespace PackageManagement.Tests
viewModel.AddPackage(); viewModel.AddPackage();
ILogger expectedLogger = viewModel.OperationLoggerCreated; ILogger expectedLogger = viewModel.OperationLoggerCreated;
ILogger actualLogger = packageManagementService ILogger actualLogger = solution
.FakePackageManagerToReturnFromCreatePackageManager .FakePackageManagerToReturnFromCreatePackageManager
.Logger; .Logger;
Assert.AreEqual(expectedLogger, actualLogger); Assert.AreEqual(expectedLogger, actualLogger);
@ -454,10 +454,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void AddPackage_ExceptionWhenInstallingPackage_ExceptionErrorMessageReported() public void AddPackage_ExceptionWhenInstallingPackage_ExceptionErrorMessageReported()
{ {
CreateViewModelWithExceptionThrowingPackageManagementService(); CreateViewModelWithExceptionThrowingSolution();
viewModel.AddOneFakeInstallPackageOperationForViewModelPackage(); viewModel.AddOneFakeInstallPackageOperationForViewModelPackage();
Exception ex = new Exception("Test"); Exception ex = new Exception("Test");
exceptionThrowingPackageManagementService.ExeptionToThrowWhenCreateInstallPackageTaskCalled = ex; exceptionThrowingSolution.ExeptionToThrowWhenCreateInstallPackageTaskCalled = ex;
viewModel.AddPackage(); viewModel.AddPackage();
Assert.AreEqual(ex, packageManagementEvents.ExceptionPassedToOnPackageOperationError); Assert.AreEqual(ex, packageManagementEvents.ExceptionPassedToOnPackageOperationError);
@ -476,10 +476,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void AddPackage_ExceptionWhenInstallingPackage_ExceptionLogged() public void AddPackage_ExceptionWhenInstallingPackage_ExceptionLogged()
{ {
CreateViewModelWithExceptionThrowingPackageManagementService(); CreateViewModelWithExceptionThrowingSolution();
viewModel.AddOneFakeInstallPackageOperationForViewModelPackage(); viewModel.AddOneFakeInstallPackageOperationForViewModelPackage();
Exception ex = new Exception("Exception error message"); Exception ex = new Exception("Exception error message");
exceptionThrowingPackageManagementService.ExeptionToThrowWhenCreateInstallPackageTaskCalled = ex; exceptionThrowingSolution.ExeptionToThrowWhenCreateInstallPackageTaskCalled = ex;
viewModel.AddPackage(); viewModel.AddPackage();
string actualMessage = fakeLogger.SecondFormattedMessageLogged; string actualMessage = fakeLogger.SecondFormattedMessageLogged;
@ -491,9 +491,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void RemovePackage_ExceptionWhenUninstallingPackage_ExceptionErrorMessageReported() public void RemovePackage_ExceptionWhenUninstallingPackage_ExceptionErrorMessageReported()
{ {
CreateViewModelWithExceptionThrowingPackageManagementService(); CreateViewModelWithExceptionThrowingSolution();
Exception ex = new Exception("Test"); Exception ex = new Exception("Test");
exceptionThrowingPackageManagementService.ExeptionToThrowWhenCreateUninstallPackageActionCalled = ex; exceptionThrowingSolution.ExeptionToThrowWhenCreateUninstallPackageActionCalled = ex;
viewModel.RemovePackage(); viewModel.RemovePackage();
Assert.AreEqual(ex, packageManagementEvents.ExceptionPassedToOnPackageOperationError); Assert.AreEqual(ex, packageManagementEvents.ExceptionPassedToOnPackageOperationError);
@ -511,9 +511,9 @@ namespace PackageManagement.Tests
[Test] [Test]
public void RemovePackage_ExceptionWhenUninstallingPackage_ExceptionLogged() public void RemovePackage_ExceptionWhenUninstallingPackage_ExceptionLogged()
{ {
CreateViewModelWithExceptionThrowingPackageManagementService(); CreateViewModelWithExceptionThrowingSolution();
Exception ex = new Exception("Exception error message"); Exception ex = new Exception("Exception error message");
exceptionThrowingPackageManagementService.ExeptionToThrowWhenCreateUninstallPackageActionCalled = ex; exceptionThrowingSolution.ExeptionToThrowWhenCreateUninstallPackageActionCalled = ex;
viewModel.RemovePackage(); viewModel.RemovePackage();
string actualMessage = fakeLogger.SecondFormattedMessageLogged; string actualMessage = fakeLogger.SecondFormattedMessageLogged;
@ -525,11 +525,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void AddPackage_ExceptionThrownWhenResolvingPackageOperations_ExceptionReported() public void AddPackage_ExceptionThrownWhenResolvingPackageOperations_ExceptionReported()
{ {
CreateViewModelWithExceptionThrowingPackageManagementService(); CreateViewModelWithExceptionThrowingSolution();
viewModel.AddOneFakeInstallPackageOperationForViewModelPackage(); viewModel.AddOneFakeInstallPackageOperationForViewModelPackage();
var exception = new Exception("Test");; var exception = new Exception("Test");;
exceptionThrowingPackageManagementService.ExceptionToThrowWhenCreatePackageManagerForActiveProjectCalled = exceptionThrowingSolution.ExceptionToThrowWhenCreatePackageManagerForActiveProjectCalled =
exception; exception;
viewModel.AddPackage(); viewModel.AddPackage();
@ -544,7 +544,7 @@ namespace PackageManagement.Tests
viewModel.AddPackage(); viewModel.AddPackage();
var expectedPackage = package; var expectedPackage = package;
var actualPackage = packageManagementService var actualPackage = solution
.FakePackageManagerToReturnFromCreatePackageManager .FakePackageManagerToReturnFromCreatePackageManager
.PackagePassedToGetInstallPackageOperations; .PackagePassedToGetInstallPackageOperations;
@ -558,7 +558,7 @@ namespace PackageManagement.Tests
viewModel.AddOneFakeInstallPackageOperationForViewModelPackage(); viewModel.AddOneFakeInstallPackageOperationForViewModelPackage();
viewModel.AddPackage(); viewModel.AddPackage();
bool result = packageManagementService bool result = solution
.FakePackageManagerToReturnFromCreatePackageManager .FakePackageManagerToReturnFromCreatePackageManager
.IgnoreDependenciesPassedToGetInstallPackageOperations; .IgnoreDependenciesPassedToGetInstallPackageOperations;

6
src/AddIns/Misc/PackageManagement/Test/Src/ProcessPackageActionTests.cs

@ -14,16 +14,16 @@ namespace PackageManagement.Tests
public class ProcessPackageActionTests public class ProcessPackageActionTests
{ {
TestableProcessPackageAction action; TestableProcessPackageAction action;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakePackageManager fakePackageManager; FakePackageManager fakePackageManager;
FakeLogger fakeLogger; FakeLogger fakeLogger;
void CreateAction() void CreateAction()
{ {
action = new TestableProcessPackageAction(); action = new TestableProcessPackageAction();
fakePackageManagementService = action.FakePackageManagementService; fakeSolution = action.FakeSolution;
fakeLogger = new FakeLogger(); fakeLogger = new FakeLogger();
fakePackageManager = fakePackageManagementService.FakePackageManagerToReturnFromCreatePackageManager; fakePackageManager = fakeSolution.FakePackageManagerToReturnFromCreatePackageManager;
} }
ILogger AddLoggerToAction() ILogger AddLoggerToAction()

6
src/AddIns/Misc/PackageManagement/Test/Src/Scripting/PackageManagementConsoleViewModelTests.cs

@ -94,7 +94,7 @@ namespace PackageManagement.Tests.Scripting
viewModel.PropertyChanged += (sender, e) => propertiesChanged.Add(e.PropertyName); viewModel.PropertyChanged += (sender, e) => propertiesChanged.Add(e.PropertyName);
} }
Solution CreatePackageManagementServiceWithEmptySolutionOpen() Solution CreateConsoleHostWithEmptySolutionOpen()
{ {
CreateConsoleHost(); CreateConsoleHost();
var solution = new Solution(); var solution = new Solution();
@ -104,7 +104,7 @@ namespace PackageManagement.Tests.Scripting
Solution CreateViewModelWithEmptySolutionOpen() Solution CreateViewModelWithEmptySolutionOpen()
{ {
var solution = CreatePackageManagementServiceWithEmptySolutionOpen(); var solution = CreateConsoleHostWithEmptySolutionOpen();
CreateViewModel(consoleHost); CreateViewModel(consoleHost);
return solution; return solution;
} }
@ -254,7 +254,7 @@ namespace PackageManagement.Tests.Scripting
[Test] [Test]
public void Constructor_EmptySolutionOpenWhenConsoleCreated_DoesNotThrowException() public void Constructor_EmptySolutionOpenWhenConsoleCreated_DoesNotThrowException()
{ {
CreatePackageManagementServiceWithEmptySolutionOpen(); CreateConsoleHostWithEmptySolutionOpen();
Assert.DoesNotThrow(() => CreateViewModel(consoleHost)); Assert.DoesNotThrow(() => CreateViewModel(consoleHost));
} }

14
src/AddIns/Misc/PackageManagement/Test/Src/UninstallPackageActionTests.cs

@ -14,17 +14,17 @@ namespace PackageManagement.Tests
public class UninstallPackageActionTests public class UninstallPackageActionTests
{ {
UninstallPackageAction action; UninstallPackageAction action;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakePackageManagementEvents fakePackageManagementEvents; FakePackageManagementEvents fakePackageManagementEvents;
FakePackageManager fakePackageManager; FakePackageManager fakePackageManager;
UninstallPackageHelper uninstallPackageHelper; UninstallPackageHelper uninstallPackageHelper;
void CreateAction() void CreateAction()
{ {
fakePackageManagementService = new FakePackageManagementService(); fakeSolution = new FakePackageManagementSolution();
fakePackageManagementEvents = new FakePackageManagementEvents(); fakePackageManagementEvents = new FakePackageManagementEvents();
fakePackageManager = fakePackageManagementService.FakePackageManagerToReturnFromCreatePackageManager; fakePackageManager = fakeSolution.FakePackageManagerToReturnFromCreatePackageManager;
action = new UninstallPackageAction(fakePackageManagementService, fakePackageManagementEvents); action = new UninstallPackageAction(fakeSolution, fakePackageManagementEvents);
uninstallPackageHelper = new UninstallPackageHelper(action); uninstallPackageHelper = new UninstallPackageHelper(action);
} }
@ -55,7 +55,7 @@ namespace PackageManagement.Tests
uninstallPackageHelper.UninstallTestPackage(); uninstallPackageHelper.UninstallTestPackage();
var actualRepository = fakePackageManagementService.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakeSolution.PackageRepositoryPassedToCreatePackageManager;
var expectedRepository = uninstallPackageHelper.FakePackageRepository; var expectedRepository = uninstallPackageHelper.FakePackageRepository;
@ -110,7 +110,7 @@ namespace PackageManagement.Tests
uninstallPackageHelper.PackageSource = expectedPackageSource; uninstallPackageHelper.PackageSource = expectedPackageSource;
uninstallPackageHelper.UninstallPackageById("PackageId"); uninstallPackageHelper.UninstallPackageById("PackageId");
var actualPackageSource = fakePackageManagementService.PackageSourcePassedToCreatePackageManager; var actualPackageSource = fakeSolution.PackageSourcePassedToCreatePackageManager;
Assert.AreEqual(expectedPackageSource, actualPackageSource); Assert.AreEqual(expectedPackageSource, actualPackageSource);
} }
@ -124,7 +124,7 @@ namespace PackageManagement.Tests
uninstallPackageHelper.UninstallPackageById("PackageId"); uninstallPackageHelper.UninstallPackageById("PackageId");
var actualProject = fakePackageManagementService.ProjectPassedToCreatePackageManager; var actualProject = fakeSolution.ProjectPassedToCreatePackageManager;
Assert.AreEqual(expectedProject, actualProject); Assert.AreEqual(expectedProject, actualProject);
} }

46
src/AddIns/Misc/PackageManagement/Test/Src/UpdatePackageActionTests.cs

@ -13,24 +13,24 @@ namespace PackageManagement.Tests
public class UpdatePackageActionTests public class UpdatePackageActionTests
{ {
UpdatePackageAction action; UpdatePackageAction action;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakePackageManagementEvents fakePackageManagementEvents; FakePackageManagementEvents fakePackageManagementEvents;
FakePackageManager fakePackageManager; FakePackageManager fakePackageManager;
UpdatePackageHelper updatePackageHelper; UpdatePackageHelper updatePackageHelper;
void CreatePackageManagementService() void CreateSolution()
{ {
fakePackageManagementService = new FakePackageManagementService(); fakeSolution = new FakePackageManagementSolution();
fakePackageManagementEvents = new FakePackageManagementEvents(); fakePackageManagementEvents = new FakePackageManagementEvents();
fakePackageManager = fakePackageManagementService.FakePackageManagerToReturnFromCreatePackageManager; fakePackageManager = fakeSolution.FakePackageManagerToReturnFromCreatePackageManager;
action = new UpdatePackageAction(fakePackageManagementService, fakePackageManagementEvents); action = new UpdatePackageAction(fakeSolution, fakePackageManagementEvents);
updatePackageHelper = new UpdatePackageHelper(action); updatePackageHelper = new UpdatePackageHelper(action);
} }
[Test] [Test]
public void Execute_PackageAndRepositoryPassed_PackageIsUpdated() public void Execute_PackageAndRepositoryPassed_PackageIsUpdated()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
var expectedPackage = updatePackageHelper.TestPackage; var expectedPackage = updatePackageHelper.TestPackage;
@ -42,18 +42,18 @@ namespace PackageManagement.Tests
[Test] [Test]
public void UpdateDependencies_DefaultValue_ReturnsTrue() public void UpdateDependencies_DefaultValue_ReturnsTrue()
{ {
CreatePackageManagementService(); CreateSolution();
Assert.IsTrue(action.UpdateDependencies); Assert.IsTrue(action.UpdateDependencies);
} }
[Test] [Test]
public void Execute_PackageAndRepositoryPassed_RepositoryUsedToCreatePackageManager() public void Execute_PackageAndRepositoryPassed_RepositoryUsedToCreatePackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
var expectedRepository = updatePackageHelper.PackageRepository; var expectedRepository = updatePackageHelper.PackageRepository;
var actualRepository = fakePackageManagementService.PackageRepositoryPassedToCreatePackageManager; var actualRepository = fakeSolution.PackageRepositoryPassedToCreatePackageManager;
Assert.AreEqual(expectedRepository, actualRepository); Assert.AreEqual(expectedRepository, actualRepository);
} }
@ -61,7 +61,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageAndRepositoryPassed_PackageOperationsUsedToUpdatePackage() public void Execute_PackageAndRepositoryPassed_PackageOperationsUsedToUpdatePackage()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
var expectedOperations = updatePackageHelper.PackageOperations; var expectedOperations = updatePackageHelper.PackageOperations;
@ -73,7 +73,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageAndRepositoryPassed_DependenciesUpdated() public void Execute_PackageAndRepositoryPassed_DependenciesUpdated()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateDependencies = true; updatePackageHelper.UpdateDependencies = true;
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
@ -85,7 +85,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageAndRepositoryPassed_PackageInstalledEventIsFired() public void Execute_PackageAndRepositoryPassed_PackageInstalledEventIsFired()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
var expectedPackage = updatePackageHelper.TestPackage; var expectedPackage = updatePackageHelper.TestPackage;
@ -96,11 +96,11 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageIdAndSourceAndProjectPassed_PackageSourceUsedToCreatePackageManager() public void Execute_PackageIdAndSourceAndProjectPassed_PackageSourceUsedToCreatePackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
var expectedPackageSource = updatePackageHelper.PackageSource; var expectedPackageSource = updatePackageHelper.PackageSource;
var actualPackageSource = fakePackageManagementService.PackageSourcePassedToCreatePackageManager; var actualPackageSource = fakeSolution.PackageSourcePassedToCreatePackageManager;
Assert.AreEqual(expectedPackageSource, actualPackageSource); Assert.AreEqual(expectedPackageSource, actualPackageSource);
} }
@ -108,10 +108,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageIdAndSourceAndProjectPassed_ProjectIsUsedToCreatePackageManager() public void Execute_PackageIdAndSourceAndProjectPassed_ProjectIsUsedToCreatePackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
var actualProject = fakePackageManagementService.ProjectPassedToCreatePackageManager; var actualProject = fakeSolution.ProjectPassedToCreatePackageManager;
var expectedProject = updatePackageHelper.TestableProject; var expectedProject = updatePackageHelper.TestableProject;
Assert.AreEqual(expectedProject, actualProject); Assert.AreEqual(expectedProject, actualProject);
@ -120,7 +120,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackagePassedButNoPackageOperations_PackageOperationsRetrievedFromPackageManager() public void Execute_PackagePassedButNoPackageOperations_PackageOperationsRetrievedFromPackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.PackageOperations = null; updatePackageHelper.PackageOperations = null;
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
@ -133,7 +133,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackagePassedButNoPackageOperations_PackageOperationsCreatedForPackage() public void Execute_PackagePassedButNoPackageOperations_PackageOperationsCreatedForPackage()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.PackageOperations = null; updatePackageHelper.PackageOperations = null;
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
@ -146,7 +146,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageIdAndSourceAndProjectPassedAndUpdateDependenciesIsTrue_DependenciesUpdatedWhenUpdatingPackage() public void Execute_PackageIdAndSourceAndProjectPassedAndUpdateDependenciesIsTrue_DependenciesUpdatedWhenUpdatingPackage()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateDependencies = true; updatePackageHelper.UpdateDependencies = true;
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
@ -159,7 +159,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageIdAndSourceAndProjectPassedAndUpdateDependenciesIsFalse_DependenciesNotUpdatedWhenGettingPackageOperations() public void Execute_PackageIdAndSourceAndProjectPassedAndUpdateDependenciesIsFalse_DependenciesNotUpdatedWhenGettingPackageOperations()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateDependencies = false; updatePackageHelper.UpdateDependencies = false;
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
@ -172,7 +172,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_UpdatedDepdenciesIsFalseAndNoPackageOperations_DependenciesIgnoredWhenGettingPackageOperations() public void Execute_UpdatedDepdenciesIsFalseAndNoPackageOperations_DependenciesIgnoredWhenGettingPackageOperations()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateDependencies = false; updatePackageHelper.UpdateDependencies = false;
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
@ -185,7 +185,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_UpdateDependenciesIsTrueAndNoPackageOperations_DependenciesNotIgnoredWhenGettingPackageOperations() public void Execute_UpdateDependenciesIsTrueAndNoPackageOperations_DependenciesNotIgnoredWhenGettingPackageOperations()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateDependencies = true; updatePackageHelper.UpdateDependencies = true;
updatePackageHelper.UpdatePackageById("PackageId"); updatePackageHelper.UpdatePackageById("PackageId");
@ -198,7 +198,7 @@ namespace PackageManagement.Tests
[Test] [Test]
public void Execute_PackageAndPackageOperationsSet_OperationsNotRetrievedFromPackageManager() public void Execute_PackageAndPackageOperationsSet_OperationsNotRetrievedFromPackageManager()
{ {
CreatePackageManagementService(); CreateSolution();
updatePackageHelper.UpdateTestPackage(); updatePackageHelper.UpdateTestPackage();
var actualPackage = fakePackageManager.PackagePassedToGetInstallPackageOperations; var actualPackage = fakePackageManager.PackagePassedToGetInstallPackageOperations;

6
src/AddIns/Misc/PackageManagement/Test/Src/UpdatedPackageViewModelTests.cs

@ -12,14 +12,14 @@ namespace PackageManagement.Tests
public class UpdatedPackageViewModelTests public class UpdatedPackageViewModelTests
{ {
TestableUpdatedPackageViewModel viewModel; TestableUpdatedPackageViewModel viewModel;
FakePackageManagementService fakePackageManagementService; FakePackageManagementSolution fakeSolution;
FakeUpdatePackageAction updatePackageAction; FakeUpdatePackageAction updatePackageAction;
void CreateViewModel() void CreateViewModel()
{ {
viewModel = new TestableUpdatedPackageViewModel(); viewModel = new TestableUpdatedPackageViewModel();
fakePackageManagementService = viewModel.FakePackageManagementService; fakeSolution = viewModel.FakeSolution;
updatePackageAction = fakePackageManagementService.ActionToReturnFromCreateUpdatePackageAction; updatePackageAction = fakeSolution.ActionToReturnFromCreateUpdatePackageAction;
} }
[Test] [Test]

30
src/AddIns/Misc/PackageManagement/Test/Src/UpdatedPackagesViewModelTests.cs

@ -13,37 +13,37 @@ namespace PackageManagement.Tests
public class UpdatedPackagesViewModelTests public class UpdatedPackagesViewModelTests
{ {
UpdatedPackagesViewModel viewModel; UpdatedPackagesViewModel viewModel;
FakePackageManagementService packageManagementService; FakePackageManagementSolution solution;
FakeTaskFactory taskFactory; FakeTaskFactory taskFactory;
FakeRegisteredPackageRepositories registeredPackageRepositories; FakeRegisteredPackageRepositories registeredPackageRepositories;
ExceptionThrowingPackageManagementService exceptionThrowingPackageManagementService; ExceptionThrowingPackageManagementSolution exceptionThrowingSolution;
void CreateViewModel() void CreateViewModel()
{ {
CreatePackageManagementService(); CreateSolution();
CreateViewModel(packageManagementService); CreateViewModel(solution);
} }
void CreatePackageManagementService() void CreateSolution()
{ {
packageManagementService = new FakePackageManagementService(); solution = new FakePackageManagementSolution();
} }
void CreateViewModel(FakePackageManagementService packageManagementService) void CreateViewModel(FakePackageManagementSolution solution)
{ {
taskFactory = new FakeTaskFactory(); taskFactory = new FakeTaskFactory();
registeredPackageRepositories = new FakeRegisteredPackageRepositories(); registeredPackageRepositories = new FakeRegisteredPackageRepositories();
var packageViewModelFactory = new FakePackageViewModelFactory(); var packageViewModelFactory = new FakePackageViewModelFactory();
viewModel = new UpdatedPackagesViewModel( viewModel = new UpdatedPackagesViewModel(
packageManagementService, solution,
registeredPackageRepositories, registeredPackageRepositories,
packageViewModelFactory, packageViewModelFactory,
taskFactory); taskFactory);
} }
void CreateExceptionThrowingPackageManagementService() void CreateExceptionThrowingSolution()
{ {
exceptionThrowingPackageManagementService = new ExceptionThrowingPackageManagementService(); exceptionThrowingSolution = new ExceptionThrowingPackageManagementSolution();
} }
void CompleteReadPackagesTask() void CompleteReadPackagesTask()
@ -54,7 +54,7 @@ namespace PackageManagement.Tests
FakePackage AddPackageToLocalRepository(string version) FakePackage AddPackageToLocalRepository(string version)
{ {
var package = FakePackage.CreatePackageWithVersion(version); var package = FakePackage.CreatePackageWithVersion(version);
packageManagementService.AddPackageToProjectLocalRepository(package); solution.AddPackageToProjectLocalRepository(package);
return package; return package;
} }
@ -108,7 +108,7 @@ namespace PackageManagement.Tests
viewModel.ReadPackages(); viewModel.ReadPackages();
registeredPackageRepositories.FakeAggregateRepository = null; registeredPackageRepositories.FakeAggregateRepository = null;
packageManagementService.FakeActiveProjectManager.LocalRepository = null; solution.FakeActiveProjectManager.LocalRepository = null;
CompleteReadPackagesTask(); CompleteReadPackagesTask();
Assert.AreEqual(1, viewModel.PackageViewModels.Count); Assert.AreEqual(1, viewModel.PackageViewModels.Count);
@ -117,10 +117,10 @@ namespace PackageManagement.Tests
[Test] [Test]
public void ReadPackages_ActiveProjectManagerThrowsException_ErrorMessageFromExceptionNotOverriddenByReadPackagesCall() public void ReadPackages_ActiveProjectManagerThrowsException_ErrorMessageFromExceptionNotOverriddenByReadPackagesCall()
{ {
CreateExceptionThrowingPackageManagementService(); CreateExceptionThrowingSolution();
exceptionThrowingPackageManagementService.ExeptionToThrowWhenActiveProjectManagerAccessed = exceptionThrowingSolution.ExeptionToThrowWhenActiveProjectManagerAccessed =
new Exception("Test"); new Exception("Test");
CreateViewModel(exceptionThrowingPackageManagementService); CreateViewModel(exceptionThrowingSolution);
viewModel.ReadPackages(); viewModel.ReadPackages();
ApplicationException ex = Assert.Throws<ApplicationException>(() => CompleteReadPackagesTask()); ApplicationException ex = Assert.Throws<ApplicationException>(() => CompleteReadPackagesTask());

Loading…
Cancel
Save