[CodeIssues] ConstantConditionIssue: check if condition is compile time constant to avoid fake warnings

ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ConstantConditionIssue.cs

@@ -88,7 +88,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
 					return;
 
 				var resolveResult = ctx.Resolve (condition);
-				if (!(resolveResult.ConstantValue is bool))
+				if (!(resolveResult.IsCompileTimeConstant && resolveResult.ConstantValue is bool))
 					return;
 
 				var value = (bool)resolveResult.ConstantValue;

ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/ConstantConditionIssueTests.cs

@@ -172,10 +172,11 @@ class TestClass
 			var input = @"
 class TestClass
 {
-	void TestMethod ()
+	void TestMethod (int x = true)
 	{
 		while (true) ;
 		if (false) ;
+		if (x) ;
 	}
 }";
 			Test<ConstantConditionIssue> (input, 0);