From 996193282c1a871122ee0e401565575a44322f85 Mon Sep 17 00:00:00 2001 From: Matt Ward Date: Tue, 30 Nov 2010 19:44:13 +0000 Subject: [PATCH] Fix null reference when completion window closed and completion list selection changed event fired afterwards. --- .../CodeCompletion/CompletionWindow.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/CodeCompletion/CompletionWindow.cs b/src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/CodeCompletion/CompletionWindow.cs index 351c026e51..95b113d516 100644 --- a/src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/CodeCompletion/CompletionWindow.cs +++ b/src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/CodeCompletion/CompletionWindow.cs @@ -48,8 +48,6 @@ namespace ICSharpCode.AvalonEdit.CodeCompletion toolTip.Placement = PlacementMode.Right; toolTip.Closed += toolTip_Closed; - completionList.InsertionRequested += completionList_InsertionRequested; - completionList.SelectionChanged += completionList_SelectionChanged; AttachEvents(); } @@ -98,6 +96,8 @@ namespace ICSharpCode.AvalonEdit.CodeCompletion void AttachEvents() { + this.completionList.InsertionRequested += completionList_InsertionRequested; + this.completionList.SelectionChanged += completionList_SelectionChanged; this.TextArea.Caret.PositionChanged += CaretPositionChanged; this.TextArea.MouseWheel += textArea_MouseWheel; this.TextArea.PreviewTextInput += textArea_PreviewTextInput; @@ -106,6 +106,8 @@ namespace ICSharpCode.AvalonEdit.CodeCompletion /// protected override void DetachEvents() { + this.completionList.InsertionRequested -= completionList_InsertionRequested; + this.completionList.SelectionChanged -= completionList_SelectionChanged; this.TextArea.Caret.PositionChanged -= CaretPositionChanged; this.TextArea.MouseWheel -= textArea_MouseWheel; this.TextArea.PreviewTextInput -= textArea_PreviewTextInput;