UsageDataCollector: improved StackTrace upload:

- always use English for "at", "in" and "line".
 - when no debug information available, upload IL offset
 - when debug information is available, upload filename only, not full file path

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@5573 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/AddIns/Misc/UsageDataCollector/UsageDataCollector.AddIn/AnalyticsMonitor.cs

@@ -95,6 +95,11 @@ namespace ICSharpCode.UsageDataCollector
 							session.AddEnvironmentData("architecture", PROCESSOR_ARCHITECTURE);
 						}
 						session.AddEnvironmentData("userAddInCount", AddInTree.AddIns.Where(a => !a.IsPreinstalled).Count().ToString());
+						
+						#if DEBUG
+						session.AddEnvironmentData("debug", "true");
+						#endif
+						
 						sessionOpened = true;
 					} catch (IncompatibleDatabaseException ex) {
 						if (ex.ActualVersion < ex.ExpectedVersion) {

src/AddIns/Misc/UsageDataCollector/UsageDataCollector/UsageDataSessionWriter.cs

@@ -8,9 +8,13 @@
 using System;
 using System.Collections.Generic;
 using System.Data.SQLite;
+using System.Diagnostics;
 using System.Globalization;
+using System.IO;
+using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Runtime.Serialization;
+using System.Security;
 using System.Text;
 using System.Threading;
 
@@ -288,11 +292,11 @@ namespace ICSharpCode.UsageDataCollector
 			if (exception == null)
 				throw new ArgumentNullException("exception");
 			string exceptionType = GetTypeName(exception);
-			string stacktrace = exception.StackTrace;
+			string stacktrace = GetStackTrace(exception);
 			while (exception.InnerException != null) {
 				exception = exception.InnerException;
 				
-				stacktrace = exception.StackTrace + Environment.NewLine
+				stacktrace = GetStackTrace(exception) + Environment.NewLine
 					+ "-- continuing with outer exception (" + exceptionType + ") --" + Environment.NewLine
 					+ stacktrace;
 				exceptionType = GetTypeName(exception);
@@ -309,6 +313,84 @@ namespace ICSharpCode.UsageDataCollector
 				return type;
 		}
 		
+		static string GetStackTrace(Exception exception)
+		{
+			// Output stacktrace in custom format (very similar to Exception.StackTrace property on English systems).
+			// Include filenames where available, but no paths.
+			StackTrace stackTrace = new StackTrace(exception, true);
+			StringBuilder b = new StringBuilder();
+			for (int i = 0; i < stackTrace.FrameCount; i++) {
+				StackFrame frame = stackTrace.GetFrame(i);
+				MethodBase method = frame.GetMethod();
+				if (method == null)
+					continue;
+				
+				if (b.Length > 0)
+					b.AppendLine();
+				
+				b.Append("   at ");
+				Type declaringType = method.DeclaringType;
+				if (declaringType != null) {
+					b.Append(declaringType.FullName.Replace('+', '.'));
+					b.Append('.');
+				}
+				b.Append(method.Name);
+				// output type parameters, if any
+				if ((method is MethodInfo) && ((MethodInfo) method).IsGenericMethod) {
+					Type[] genericArguments = ((MethodInfo) method).GetGenericArguments();
+					b.Append('[');
+					for (int j = 0; j < genericArguments.Length; j++) {
+						if (j > 0)
+							b.Append(',');
+						b.Append(genericArguments[j].Name);
+					}
+					b.Append(']');
+				}
+				
+				// output parameters, if any
+				b.Append('(');
+				ParameterInfo[] parameters = method.GetParameters();
+				for (int j = 0; j < parameters.Length; j++) {
+					if (j > 0)
+						b.Append(", ");
+					if (parameters[j].ParameterType != null) {
+						b.Append(parameters[j].ParameterType.Name);
+					} else {
+						b.Append('?');
+					}
+					if (!string.IsNullOrEmpty(parameters[j].Name)) {
+						b.Append(' ');
+						b.Append(parameters[j].Name);
+					}
+				}
+				b.Append(')');
+				
+				// source location
+				if (frame.GetILOffset() >= 0) {
+					string filename = null;
+					try {
+						string fullpath = frame.GetFileName();
+						if (fullpath != null)
+							filename = Path.GetFileName(fullpath);
+					} catch (SecurityException) {
+						// StackFrame.GetFileName requires PathDiscovery permission
+					} catch (ArgumentException) {
+						// Path.GetFileName might throw on paths with invalid chars
+					}
+					b.Append(" in ");
+					if (filename != null) {
+						b.Append(filename);
+						b.Append(":line ");
+						b.Append(frame.GetFileLineNumber());
+					} else {
+						b.Append("offset ");
+						b.Append(frame.GetILOffset());
+					}
+				}
+			}
+			return b.ToString();
+		}
+		
 		/// <summary>
 		/// Adds an exception report to the session.
 		/// </summary>