Remove some Console.WriteLine() calls; catch some exceptions which previously were ignored silently or just dumped to the console.

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@319 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/AddIns/DisplayBindings/FormDesigner/Project/Src/Commands/FormCommands.cs

@@ -61,7 +61,7 @@ namespace ICSharpCode.SharpDevelop.FormEditor.Commands
 					menuCommandService.GlobalInvoke(CommandID);
 				}
 			} catch (Exception e) {
-				Console.WriteLine("Got Exception {0}", e);
+				MessageService.ShowError(e);
 			}
 		}
 	}
@@ -141,7 +141,7 @@ namespace ICSharpCode.SharpDevelop.FormEditor.Commands
 				try {
 					verb.Invoke();
 				} catch (Exception ex) {
-					Console.WriteLine("Got Exception {0}", ex);
+					MessageService.ShowError(ex);
 				}
 			}
 		}

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/DesignerGenerator/CSharpDesignerGenerator.cs

@@ -74,7 +74,7 @@ namespace ICSharpCode.FormDesigner
 					}
 				}
 			} catch (Exception ex) {
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 		}
 		
@@ -87,7 +87,7 @@ namespace ICSharpCode.FormDesigner
 				int endOffset = viewContent.Document.PositionToOffset(new Point(0, initializeComponents.BodyRegion.EndLine));
 				viewContent.Document.Insert(endOffset, "\t\tprivate " + e.Component.GetType() + " " + e.Component.Site.Name + ";" + Environment.NewLine);
 			} catch (Exception ex) { 
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 		}
 		

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/DesignerGenerator/VBNetDesignerGenerator.cs

@@ -74,7 +74,7 @@ namespace ICSharpCode.FormDesigner
 					}
 				}
 			} catch (Exception ex) {
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 		}
 		
@@ -87,7 +87,7 @@ namespace ICSharpCode.FormDesigner
 				int endOffset = viewContent.Document.PositionToOffset(new Point(0, initializeComponents.BodyRegion.EndLine));
 				viewContent.Document.Insert(endOffset, "\tPrivate " + e.Component.Site.Name + " As " + e.Component.GetType() + Environment.NewLine);
 			} catch (Exception ex) { 
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 		}
 		

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/DesignerGenerator/XmlDesignerGenerator.cs

@@ -170,7 +170,7 @@ namespace ICSharpCode.FormDesigner
 				
 				return el;
 			} catch (Exception e) {
-				Console.WriteLine(e.ToString());
+				ICSharpCode.Core.MessageService.ShowError(e);
 			}
 			return null;
 		}

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/FormDesignerSecondaryDisplayBinding.cs

@@ -86,12 +86,10 @@ namespace ICSharpCode.FormDesigner
 				ITextEditorControlProvider textAreaControlProvider = (ITextEditorControlProvider)viewContent;
 				string fileExtension = String.Empty;
 				string fileName      = viewContent.IsUntitled ? viewContent.UntitledName : viewContent.FileName;
+				if (fileName == null)
+					return false;
 				
-				try {
+				fileExtension = Path.GetExtension(fileName).ToLower();
-					fileExtension = Path.GetExtension(fileName).ToLower();
-				} catch (Exception e) {
-					Console.WriteLine(e);
-				}
 				
 				switch (fileExtension) {
 					case ".cs":
@@ -136,11 +134,7 @@ namespace ICSharpCode.FormDesigner
 			string fileExtension = String.Empty;
 			string fileName      = viewContent.IsUntitled ? viewContent.UntitledName : viewContent.FileName;
 			
-			try {
+			fileExtension = Path.GetExtension(fileName).ToLower();
-				fileExtension = Path.GetExtension(fileName).ToLower();
-			} catch (Exception e) {
-				Console.WriteLine(e);
-			}
 			
 			if (!FormKeyHandler.inserted) {
 				FormKeyHandler.Insert();

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/Gui/AddComponentsDialog.cs

@@ -142,7 +142,7 @@ namespace ICSharpCode.FormDesigner.Gui
 						}
 					}
 				} catch (Exception e) {
-					Console.WriteLine("got exception : " + e.ToString());
+					MessageService.ShowError(e);
 				}
 			}
 			((ListView)ControlDictionary["componentListView"]).EndUpdate();

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/Gui/OptionPanels/GridOptions.cs

@@ -37,8 +37,7 @@ namespace ICSharpCode.FormDesigner.Gui.OptionPanels
 			int width = 0;
 			try {
 				width = Int32.Parse(ControlDictionary["widthTextBox"].Text);
-			} catch (Exception e) {
+			} catch {
-				Console.WriteLine(e);
 				MessageService.ShowError("Forms Designer grid with is invalid");
 				return false;
 			}
@@ -46,8 +45,7 @@ namespace ICSharpCode.FormDesigner.Gui.OptionPanels
 			int height = 0;
 			try {
 				height = Int32.Parse(ControlDictionary["heightTextBox"].Text);
-			} catch (Exception e) {
+			} catch {
-				Console.WriteLine(e);
 				MessageService.ShowError("Forms Designer height with is invalid");
 				return false;
 			}

src/AddIns/DisplayBindings/FormDesigner/Project/Src/FormDesigner/Services/DefaultServiceContainer.cs

@@ -44,7 +44,7 @@ namespace ICSharpCode.FormDesigner.Services
 					try {
 						disposeMe.Dispose();
 					} catch (Exception e) {
-						Console.WriteLine("Exception while disposing " + disposeMe + ":" + e.ToString());
+						ICSharpCode.Core.MessageService.ShowError(e, "Exception while disposing " + disposeMe);
 					}
 				}
 			}

src/AddIns/Misc/SubversionAddIn/Project/Src/SvnClient.cs

@@ -206,7 +206,7 @@ namespace ICSharpCode.Svn
 					inOperationForm = null;
 				}
 			} catch (Exception e) {
-				Console.WriteLine(e);
+				MessageService.ShowError(e);
 			} finally {
 				done = true;
 			}

src/Libraries/ICSharpCode.TextEditor/Project/Src/Util/RtfWriter.cs

@@ -21,29 +21,24 @@ namespace ICSharpCode.TextEditor.Util
 		
 		public static string GenerateRtf(TextArea textArea)
 		{
-			try {
+			colors = new Dictionary<string, int>();
-				colors = new Dictionary<string, int>();
+			colorNum = 0;
-				colorNum = 0;
+			colorString = new StringBuilder();
-				colorString = new StringBuilder();
+			
-				
+			
-				
+			StringBuilder rtf = new StringBuilder();
-				StringBuilder rtf = new StringBuilder();
+			
-				
+			rtf.Append(@"{\rtf1\ansi\ansicpg1252\deff0\deflang1031");
-				rtf.Append(@"{\rtf1\ansi\ansicpg1252\deff0\deflang1031");
+			BuildFontTable(textArea.Document, rtf);
-				BuildFontTable(textArea.Document, rtf);
+			rtf.Append('\n');
-				rtf.Append('\n');
+			
-				
+			string fileContent = BuildFileContent(textArea);
-				string fileContent = BuildFileContent(textArea);
+			BuildColorTable(textArea.Document, rtf);
-				BuildColorTable(textArea.Document, rtf);
+			rtf.Append('\n');
-				rtf.Append('\n');
+			rtf.Append(@"\viewkind4\uc1\pard");
-				rtf.Append(@"\viewkind4\uc1\pard");
+			rtf.Append(fileContent);
-				rtf.Append(fileContent);
+			rtf.Append("}");
-				rtf.Append("}");
+			return rtf.ToString();
-				return rtf.ToString();
-			} catch (Exception e) {
-				Console.WriteLine(e.ToString());
-			}
-			return null;
 		}
 		
 		static void BuildColorTable(IDocument doc, StringBuilder rtf)

src/Main/Base/Project/Src/Dom/NRefactoryResolver/NRefactoryResolver.cs

@@ -414,9 +414,6 @@ namespace ICSharpCode.SharpDevelop.Dom.NRefactoryResolver
 				if (newOffset <= 0) break;
 				offset = newOffset;
 			}
-//			Console.WriteLine("<source from={0} to={1}>", startLine, endLine);
-//			Console.Write(fileContent.Substring(startOffset, offset - startOffset));
-//			Console.WriteLine("</source>");
 			int length = offset - startOffset;
 			string classDecl, endClassDecl;
 			if (language == SupportedLanguages.VBNet) {

src/Main/Base/Project/Src/Gui/Dialogs/NewFileDialog.cs

@@ -59,7 +59,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 				
 				((TreeView)ControlDictionary["categoryTreeView"]).Select();
 			} catch (Exception e) {
-				Console.WriteLine(e.ToString());
+				MessageService.ShowError(e);
 			}
 		}
 		
@@ -289,7 +289,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 						++curNumber;
 					}
 				} catch (Exception e) {
-					Console.WriteLine(e);
+					MessageService.ShowError(e);
 				}
 			}
 			return StringParser.Parse(SelectedTemplate.DefaultName);

src/Main/Base/Project/Src/Gui/Dialogs/NewProjectDialog.cs

@@ -219,7 +219,7 @@ namespace ICSharpCode.SharpDevelop.Project.Dialogs
 					}
 				}
 			} catch (Exception ex) { 
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 			ControlDictionary["createInLabel"].Text = ResourceService.GetString("Dialog.NewProject.ProjectAtDescription")+ " " + solutionPath;
 		}

src/Main/Base/Project/Src/Gui/Pads/ErrorList/ErrorList.cs

@@ -153,7 +153,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 				listView.Items.Clear();
 				UpdateToolstripStatus();
 			} catch (Exception ex) {
-				Console.WriteLine(ex);
+				MessageService.ShowError(ex);
 			}
 		}
 		
@@ -304,7 +304,6 @@ namespace ICSharpCode.SharpDevelop.Gui
 		
 		void UpdateToolstripStatus()
 		{
-			Console.WriteLine("Updpate " + TaskService.TaskCount);
 			foreach (ToolStripItem item in toolStrip.Items) {
 				if (item is IStatusUpdate) {
 					((IStatusUpdate)item).UpdateStatus();

src/Main/Base/Project/Src/Gui/Pads/OpenTaskView.cs

@@ -101,11 +101,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 		
 		void OnCombineClosed(object sender, EventArgs e)
 		{
-			try {
+			listView.Items.Clear();
-				listView.Items.Clear();
-			} catch (Exception ex) {
-				Console.WriteLine(ex);
-			}
 		}
 		
 		void SelectTaskView(object sender, EventArgs e)
@@ -143,7 +139,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 					taskToolTip.SetToolTip(listView, description);
 					taskToolTip.Active       = true;
 				} else {
-					taskToolTip.RemoveAll(); 
+					taskToolTip.RemoveAll();
 					taskToolTip.Active       = false;
 				}
 				currentListViewItem = item;
@@ -185,12 +181,12 @@ namespace ICSharpCode.SharpDevelop.Gui
 			} catch (Exception) {}
 			
 			ListViewItem item = new ListViewItem(new string[] {
-				String.Empty,
+			                                     	String.Empty,
-				(task.Line + 1).ToString(),
+			                                     	(task.Line + 1).ToString(),
-				FormatDescription(task.Description),
+			                                     	FormatDescription(task.Description),
-				fileName,
+			                                     	fileName,
-				path
+			                                     	path
-			});
+			                                     });
 			item.ImageIndex = item.StateImageIndex = imageIndex;
 			item.Tag = task;
 			listView.Items.Add(item);
@@ -223,7 +219,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 		
 		/// <summary>
 		/// Removes new lines, carriage returns and tab characters from
-		/// the list view task description and replaces them with a space.  
+		/// the list view task description and replaces them with a space.
 		/// </summary>
 		/// <param name="description">The task list description.</param>
 		/// <returns>A formatted task list description.</returns>

src/Main/Base/Project/Src/Gui/Workbench/DefaultWorkbench.cs

@@ -208,7 +208,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 						((IMementoCapable)content).SetMemento(memento);
 					}
 				} catch (Exception e) {
-					Console.WriteLine("Can't get/set memento : " + e.ToString());
+					MessageService.ShowError(e, "Can't get/set memento");
 				}
 			}
 			

src/Main/Base/Project/Src/Gui/Workbench/Layouts/SdiWorkspaceLayout.cs

@@ -253,7 +253,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 					}
 				}
 			} catch (Exception e) {
-				Console.WriteLine(e);
+				MessageService.ShowError(e);
 			}
 		}
 		
@@ -267,7 +267,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 						padContentWrapper.DetachContent();
 						padContentWrapper.Dispose();
 					}
-				} catch (Exception e) { Console.WriteLine(e); }
+				} catch (Exception e) { MessageService.ShowError(e); }
 			}
 			if (dispose) {
 				contentHash.Clear();
@@ -286,7 +286,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 						f.DetachContent();
 						f.Dispose();
 					}
-				} catch (Exception e) { Console.WriteLine(e); }
+				} catch (Exception e) { MessageService.ShowError(e); }
 			}
 		}
 		public void Detach()
@@ -304,7 +304,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 					dockPanel = null;
 				}
 			} catch (Exception e) {
-				Console.WriteLine(e);
+				MessageService.ShowError(e);
 			}
 			if (contentHash != null) {
 				contentHash.Clear();

src/Main/Base/Project/Src/Gui/XmlForms/Lib/XmlLoader.cs

@@ -318,8 +318,7 @@ namespace ICSharpCode.SharpDevelop.Gui.XmlForms
 					}
 				}
 			} catch (Exception e) {
-				Console.WriteLine(e.ToString());
+				throw new ApplicationException("error while setting property " + propertyName + " of object "+ o.ToString() + " to value '" + val+ "'", e);
-				throw new ApplicationException("error while setting property " + propertyName + " of object "+ o.ToString() + " to value '" + val+ "'");
 			}
 		}
 		

src/Main/Base/Project/Src/Services/ParserService/ParserService.cs

@@ -364,7 +364,7 @@ namespace ICSharpCode.Core
 				try {
 					OnParseInformationUpdated(new ParseInformationEventArgs(fileName, parseInformation, parserOutput));
 				} catch (Exception e) {
-					Console.WriteLine(e);
+					MessageService.ShowError(e);
 				}
 			}
 			

src/Main/Base/Project/Src/Services/ProjectService/ParseableFileContentEnumerator.cs

@@ -121,9 +121,13 @@ namespace ICSharpCode.SharpDevelop.Project
 				} else {
 					fileContent = GetFileContent(item);
 				}
+			} catch (FileNotFoundException ex) {
+				res = null;
+				Console.WriteLine("ParseableFileContentEnumerator: " + ex.Message);
+				return MoveNext(); // skip files that were not found
 			} catch (IOException ex) {
 				res = null;
-				Console.WriteLine(ex);
+				Console.WriteLine("ParseableFileContentEnumerator: " + ex.Message);
 				return MoveNext(); // skip invalid files
 			}
 			if (nextItem != null && nextItem.ItemType == ItemType.Compile && CanReadAsync(nextItem))

src/Main/Base/Project/Src/TextEditor/Actions.cs

@@ -80,8 +80,7 @@ namespace ICSharpCode.SharpDevelop.DefaultEditor.Actions
 						else
 							FileService.JumpToFilePosition(pos.Filename, pos.Position.X - 1, pos.Position.Y - 1);
 					} catch (Exception ex) {
-						Console.WriteLine("Error jumping to '" + pos.Filename + "':\n" + ex.ToString());
+						MessageService.ShowError(ex, "Error jumping to '" + pos.Filename + "'.");
-						MessageBox.Show("Error jumping to '" + pos.Filename + "':\n" + ex.ToString());
 					}
 				}
 			}

src/Main/Base/Project/Src/TextEditor/Gui/Editor/CompletionWindow/CodeCompletionData.cs

@@ -277,7 +277,7 @@ namespace ICSharpCode.SharpDevelop.DefaultEditor.Gui.Editor
 					}
 				} while(xml.Read());
 			} catch (Exception ex) {
-				Console.WriteLine(ex);
+				Console.WriteLine("Invalid XML documentation: " + ex.Message);
 				return doc;
 			}
 			return ret.ToString();

src/Main/Base/Project/Src/TextEditor/XmlFormattingStrategy.cs

@@ -95,7 +95,7 @@ namespace ICSharpCode.SharpDevelop.DefaultEditor
 			try {
 				TryIndent(textArea, begin, end);
 			} catch (XmlException ex) {
-				Console.WriteLine(ex.ToString());
+				MessageService.ShowError(ex);
 			}
 		}
 		

src/Main/Core/Project/Src/AddInTree/AddIn/DefaultDoozers/IncludeDoozer.cs

@@ -58,8 +58,8 @@ namespace ICSharpCode.Core
 				try {
 					node = AddInTree.GetTreeNode(path);
 					items.AddRange(node.BuildChildItems(caller));
-				} catch (TreePathNotFoundException ex) {
+				} catch (TreePathNotFoundException) {
-					Console.WriteLine(ex);
+					MessageService.ShowError("IncludeDoozer: AddinTree-Path not found: " + path);
 				}
 			}
 		}

src/Main/Core/Project/Src/Services/MenuService/MenuService.cs

@@ -32,7 +32,6 @@ namespace ICSharpCode.Core
 		
 		public static ContextMenuStrip CreateContextMenu(object owner, string addInTreePath)
 		{
-			Console.WriteLine("Create Owner == " + owner);
 			if (addInTreePath == null) {
 				return null;
 			}
@@ -51,7 +50,7 @@ namespace ICSharpCode.Core
 				ContextMenuPopupHandler(contextMenu, EventArgs.Empty);
 				return contextMenu;
 			} catch (TreePathNotFoundException) {
-				Console.WriteLine("Warning tree path '" + addInTreePath +"' not found.");
+				MessageService.ShowError("Warning tree path '" + addInTreePath +"' not found.");
 				return null;
 			} 
 		}