From 6132821b2ab3fc3a362a4d6844997165c7c4f071 Mon Sep 17 00:00:00 2001 From: Daniel Grunwald Date: Thu, 28 Feb 2013 14:32:08 +0100 Subject: [PATCH] Fix NullReferenceException in semantic highlighting. --- .../Analysis/SemanticHighlightingVisitor.cs | 5 ++++- ICSharpCode.NRefactory.CSharp/Ast/AstNodeCollection.cs | 6 +++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ICSharpCode.NRefactory.CSharp/Analysis/SemanticHighlightingVisitor.cs b/ICSharpCode.NRefactory.CSharp/Analysis/SemanticHighlightingVisitor.cs index 03c21a406a..ed0f5f6e38 100644 --- a/ICSharpCode.NRefactory.CSharp/Analysis/SemanticHighlightingVisitor.cs +++ b/ICSharpCode.NRefactory.CSharp/Analysis/SemanticHighlightingVisitor.cs @@ -289,8 +289,11 @@ namespace ICSharpCode.NRefactory.CSharp.Analysis { if (member.EntityType != EntityType.Method || member.ReturnType.Kind != TypeKind.Void) return false; - while (member.IsOverride) + while (member.IsOverride) { member = (IParameterizedMember)InheritanceHelper.GetBaseMember(member); + if (member == null) + return false; + } return IsInactiveConditional(member.Attributes); } diff --git a/ICSharpCode.NRefactory.CSharp/Ast/AstNodeCollection.cs b/ICSharpCode.NRefactory.CSharp/Ast/AstNodeCollection.cs index b727dc2112..9bc2d35642 100644 --- a/ICSharpCode.NRefactory.CSharp/Ast/AstNodeCollection.cs +++ b/ICSharpCode.NRefactory.CSharp/Ast/AstNodeCollection.cs @@ -28,7 +28,11 @@ namespace ICSharpCode.NRefactory.CSharp /// /// Represents the children of an AstNode that have a specific role. /// - public class AstNodeCollection : ICollection where T : AstNode + public class AstNodeCollection : ICollection + #if NET_4_5 + , IReadOnlyCollection + #endif + where T : AstNode { readonly AstNode node; readonly Role role;