From 5f30db49e6b7b8548f6ce7d524f1ac7b330a8f0d Mon Sep 17 00:00:00 2001 From: David Alpert Date: Mon, 17 Jul 2006 11:18:34 +0000 Subject: [PATCH] Fixed SD2-939 git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@1594 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61 --- .../NavigationService/NavigationService.cs | 3 ++- .../NavigationServiceTestFixture.cs | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/Main/Base/Project/Src/Services/NavigationService/NavigationService.cs b/src/Main/Base/Project/Src/Services/NavigationService/NavigationService.cs index 70f27caf42..fb4513d96b 100644 --- a/src/Main/Base/Project/Src/Services/NavigationService/NavigationService.cs +++ b/src/Main/Base/Project/Src/Services/NavigationService/NavigationService.cs @@ -125,7 +125,8 @@ namespace ICSharpCode.Core private static void LogInternal(INavigationPoint p) { if (p == null - || p.FileName==null) { // HACK: why/how do we get here? + || p.FileName==null // HACK: why/how do we get here? + || p.FileName==String.Empty) { // HACK: why/how do we get here? return; } if (currentNode==null) { diff --git a/src/Main/Base/Test/Services_Navigation/NavigationServiceTestFixture.cs b/src/Main/Base/Test/Services_Navigation/NavigationServiceTestFixture.cs index 5d5558f643..398298240b 100644 --- a/src/Main/Base/Test/Services_Navigation/NavigationServiceTestFixture.cs +++ b/src/Main/Base/Test/Services_Navigation/NavigationServiceTestFixture.cs @@ -572,6 +572,22 @@ namespace NavigationServiceTests Assert.IsTrue(NavigationService.CanNavigateForwards); } + [Test] + /// + /// Addresses SD2-939: + /// Code Navigate Back dropdown first menu has a blank filename + /// + public void IgnoreBlankFilenamesTest() + { + Assert.AreEqual(0, NavigationService.Count); + + INavigationPoint testPoint = new TestNavigationPoint(String.Empty); + Assert.AreEqual(String.Empty, testPoint.FileName); + + NavigationService.Log(testPoint); + Assert.AreEqual(0, NavigationService.Count); + } + #region setup / tear down [SetUp]