diff --git a/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj b/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj index 508f64064b..59ce7d4487 100644 --- a/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj +++ b/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj @@ -246,6 +246,8 @@ + + diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyExpressionToStatementAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyExpressionToStatementAction.cs new file mode 100644 index 0000000000..e734f395d6 --- /dev/null +++ b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyExpressionToStatementAction.cs @@ -0,0 +1,80 @@ +// +// ConvertLambdaBodyExpressionToStatementAction.cs +// +// Author: +// Mansheng Yang +// +// Copyright (c) 2012 Mansheng Yang +// +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in +// all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +// THE SOFTWARE. + +using System.Linq; +using ICSharpCode.NRefactory.CSharp.Resolver; +using ICSharpCode.NRefactory.TypeSystem; + +namespace ICSharpCode.NRefactory.CSharp.Refactoring +{ + [ContextAction ("Converts expression of lambda body to statement", + Description = "Converts expression of lambda body to statement")] + public class ConvertLambdaBodyExpressionToStatementAction : SpecializedCodeAction + { + + protected override CodeAction GetAction (RefactoringContext context, LambdaExpression node) + { + if (!node.ArrowToken.Contains (context.Location)) + return null; + + var bodyExpr = node.Body as Expression; + if (bodyExpr == null) + return null; + return new CodeAction (context.TranslateString ("Convert to lambda statement"), + script => + { + var body = new BlockStatement (); + if (RequireReturnStatement (context, node)) { + body.Add (new ReturnStatement (bodyExpr.Clone ())); + } else { + body.Add (new ExpressionStatement (bodyExpr.Clone ())); + } + script.Replace (bodyExpr, body); + }); + } + + static bool RequireReturnStatement (RefactoringContext context, LambdaExpression lambda) + { + var parent = lambda.Parent; + while (parent is ParenthesizedExpression) + parent = parent.Parent; + + ITypeDefinition delegateTypeDef; + if (parent is InvocationExpression) { + var invocation = (InvocationExpression)parent; + var argIndex = invocation.Arguments.TakeWhile (arg => !arg.Contains (lambda.StartLocation)).Count (); + var resolveResult = (CSharpInvocationResolveResult)context.Resolve (invocation); + delegateTypeDef = resolveResult.Arguments [argIndex].Type.GetDefinition (); + } else { + delegateTypeDef = context.Resolve (parent).Type.GetDefinition (); + } + if (delegateTypeDef == null) + return false; + var invokeMethod = delegateTypeDef.GetMethods (m => m.Name == "Invoke").FirstOrDefault (); + return invokeMethod != null && invokeMethod.ReturnType.ReflectionName != "System.Void"; + } + } +} diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyStatementToExpressionAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyStatementToExpressionAction.cs new file mode 100644 index 0000000000..0126fea82b --- /dev/null +++ b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/ConvertLambdaBodyStatementToExpressionAction.cs @@ -0,0 +1,57 @@ +// +// ConvertLambdaBodyStatementToExpressionAction.cs +// +// Author: +// Mansheng Yang +// +// Copyright (c) 2012 Mansheng Yang +// +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in +// all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +// THE SOFTWARE. + +namespace ICSharpCode.NRefactory.CSharp.Refactoring +{ + [ContextAction ("Converts statement of lambda body to expression", + Description = "Converts statement of lambda body to expression")] + public class ConvertLambdaBodyStatementToExpressionAction : SpecializedCodeAction + { + protected override CodeAction GetAction (RefactoringContext context, LambdaExpression node) + { + if (!node.ArrowToken.Contains (context.Location)) + return null; + + var blockStatement = node.Body as BlockStatement; + if (blockStatement == null || blockStatement.Statements.Count > 1) + return null; + + Expression expr; + var returnStatement = blockStatement.Statements.FirstOrNullObject () as ReturnStatement; + if (returnStatement != null) { + expr = returnStatement.Expression; + } else { + var exprStatement = blockStatement.Statements.FirstOrNullObject () as ExpressionStatement; + if (exprStatement == null) + return null; + expr = exprStatement.Expression; + } + + return new CodeAction (context.TranslateString ("Convert to lambda expression"), + script => script.Replace (blockStatement, expr.Clone ())); + } + } +} diff --git a/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyExpressionToStatementTests.cs b/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyExpressionToStatementTests.cs new file mode 100644 index 0000000000..a3d720a19c --- /dev/null +++ b/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyExpressionToStatementTests.cs @@ -0,0 +1,161 @@ +// +// ConvertLambdaBodyExpressionToStatementTests.cs +// +// Author: +// Mansheng Yang +// +// Copyright (c) 2012 Mansheng Yang +// +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in +// all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +// THE SOFTWARE. + +using ICSharpCode.NRefactory.CSharp.Refactoring; +using NUnit.Framework; + +namespace ICSharpCode.NRefactory.CSharp.CodeActions +{ + [TestFixture] + public class ConvertLambdaBodyExpressionToStatementTests : ContextActionTestBase + { + [Test] + public void TestReturn () + { + Test (@" +class TestClass +{ + void TestMethod () + { + System.Func f = i $=> i + 1; + } +}", @" +class TestClass +{ + void TestMethod () + { + System.Func f = i => { + return i + 1; + }; + } +}"); + } + + [Test] + public void TestExprStatement() + { + Test (@" +class TestClass +{ + void TestMethod () + { + System.Action f = i $=> i++; + } +}", @" +class TestClass +{ + void TestMethod () + { + System.Action f = i => { + i++; + }; + } +}"); + } + + [Test] + public void TestWrongContext () + { + TestWrongContext (@" +class TestClass +{ + void TestMethod () + { + System.Func f = i $=> { + return i + 1; + }; + } +}"); + } + + [Test] + public void TestParenthesis () + { + Test (@" +class TestClass +{ + void TestMethod () + { + System.Func f; + f = (i $=> i + 1); + } +}", @" +class TestClass +{ + void TestMethod () + { + System.Func f; + f = (i => { + return i + 1; + }); + } +}"); + } + + [Test] + public void TestInvocation () + { + Test (@" +class TestClass +{ + void Test (int k, System.Func f) { } + void TestMethod () + { + Test (1, i $=> i + 1); + } +}", @" +class TestClass +{ + void Test (int k, System.Func f) { } + void TestMethod () + { + Test (1, i => { + return i + 1; + }); + } +}"); + Test (@" +class TestClass +{ + void Test2 (System.Action a) { } + void TestMethod () + { + Test2 (i $=> i++); + } +}", @" +class TestClass +{ + void Test2 (System.Action a) { } + void TestMethod () + { + Test2 (i => { + i++; + }); + } +}"); + } + } +} diff --git a/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyStatementToExpressionTests.cs b/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyStatementToExpressionTests.cs new file mode 100644 index 0000000000..041fb64a04 --- /dev/null +++ b/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/ConvertLambdaBodyStatementToExpressionTests.cs @@ -0,0 +1,79 @@ +// +// ConvertLambdaBodyStatementToExpressionTests.cs +// +// Author: +// Mansheng Yang +// +// Copyright (c) 2012 Mansheng Yang +// +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in +// all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +// THE SOFTWARE. + +using ICSharpCode.NRefactory.CSharp.Refactoring; +using NUnit.Framework; + +namespace ICSharpCode.NRefactory.CSharp.CodeActions +{ + [TestFixture] + public class ConvertLambdaBodyStatementToExpressionTests : ContextActionTestBase + { + [Test] + public void TestReturn () + { + Test (@" +class TestClass +{ + void TestMethod () + { + System.Func f = i $=> { + return i + 1; + }; + } +}", @" +class TestClass +{ + void TestMethod () + { + System.Func f = i => i + 1; + } +}"); + } + + [Test] + public void TestExpressionStatement () + { + Test (@" +class TestClass +{ + void TestMethod () + { + System.Action f = i $=> { + System.Console.Write (i); + }; + } +}", @" +class TestClass +{ + void TestMethod () + { + System.Action f = i => System.Console.Write (i); + } +}"); + } + } +} diff --git a/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj b/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj index 110211ec76..c886bfa7ff 100644 --- a/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj +++ b/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj @@ -86,6 +86,8 @@ + +