leoowen19
12 years ago
4 changed files with 199 additions and 2 deletions
@ -0,0 +1,98 @@
@@ -0,0 +1,98 @@
|
||||
//
|
||||
// RedundantConstructorIssue.cs
|
||||
//
|
||||
// Author:
|
||||
// Ji Kun <jikun.nus@gmail.com>
|
||||
//
|
||||
// Copyright (c) 2013 Ji Kun
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the "Software"), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SaHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
|
||||
using System; |
||||
using System.Collections.Generic; |
||||
using System.Linq; |
||||
using ICSharpCode.NRefactory.CSharp.Resolver; |
||||
using ICSharpCode.NRefactory.Semantics; |
||||
using ICSharpCode.NRefactory.TypeSystem; |
||||
|
||||
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
||||
{ |
||||
[IssueDescription("An empty constructor is not necessary", |
||||
Description = "An alone empty constructor is not necessary.", |
||||
Category = IssueCategories.Redundancies, |
||||
Severity = Severity.Suggestion, |
||||
ResharperDisableKeyword = "RedundantConstructor", |
||||
IssueMarker = IssueMarker.GrayOut)] |
||||
public class RedundantConstructorIssue : ICodeIssueProvider |
||||
{ |
||||
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context) |
||||
{ |
||||
var unit = context.RootNode as SyntaxTree; |
||||
if (unit == null) |
||||
return Enumerable.Empty<CodeIssue>(); |
||||
return new GatherVisitor(context).GetIssues(); |
||||
} |
||||
|
||||
class GatherVisitor : GatherVisitorBase<RedundantConstructorIssue> |
||||
{ |
||||
public GatherVisitor(BaseRefactoringContext ctx) |
||||
: base(ctx) |
||||
{ |
||||
} |
||||
|
||||
public override void VisitTypeDeclaration(TypeDeclaration typedeclaration) |
||||
{ |
||||
var typeResolveResult = ctx.Resolve(typedeclaration) as TypeResolveResult; |
||||
var constructors = typeResolveResult.GetType().GetConstructors(); |
||||
bool hasEmptyConstructor = false; |
||||
bool hasUnemptyConstructor = false; |
||||
ConstructorDeclaration emptyContructorNode = new ConstructorDeclaration(); |
||||
|
||||
foreach (var child in typedeclaration.Children) |
||||
{ |
||||
if (child is ConstructorDeclaration) |
||||
{ |
||||
if ((child as ConstructorDeclaration).HasModifier(Modifiers.Static)) |
||||
continue; |
||||
if ((child as ConstructorDeclaration).Body.Count() > 0 || |
||||
((child as ConstructorDeclaration).Parameters.Count > 0)) |
||||
{ |
||||
hasUnemptyConstructor = true; |
||||
} |
||||
else if ((child as ConstructorDeclaration).HasModifier(Modifiers.Public)) |
||||
{ |
||||
hasEmptyConstructor = true; |
||||
emptyContructorNode = child as ConstructorDeclaration; |
||||
} |
||||
} |
||||
} |
||||
|
||||
if (!hasUnemptyConstructor && hasEmptyConstructor) |
||||
{ |
||||
AddIssue(emptyContructorNode, ctx.TranslateString("Remove redundant constructor"), script => |
||||
{ |
||||
script.Remove(emptyContructorNode); |
||||
} |
||||
); |
||||
} |
||||
return; |
||||
} |
||||
} |
||||
} |
||||
} |
||||
@ -0,0 +1,96 @@
@@ -0,0 +1,96 @@
|
||||
//
|
||||
// RedundantConstructorTest.cs
|
||||
//
|
||||
// Author:
|
||||
// Ji Kun <jikun.nus@gmail.com>
|
||||
//
|
||||
// Copyright (c) 2013 Ji Kun
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the "Software"), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
using System; |
||||
using NUnit.Framework; |
||||
using ICSharpCode.NRefactory.CSharp.Refactoring; |
||||
using ICSharpCode.NRefactory.CSharp.CodeActions; |
||||
|
||||
namespace ICSharpCode.NRefactory.CSharp.CodeIssues |
||||
{ |
||||
[TestFixture] |
||||
public class RedundantConstructorTests : InspectionActionTestBase |
||||
{ |
||||
[Test] |
||||
public void TestInspectorCase1() |
||||
{ |
||||
var input = @"using System;class Test {private int member; public Test(){}}"; |
||||
|
||||
TestRefactoringContext context; |
||||
var issues = GetIssues(new RedundantConstructorIssue(), input, out context); |
||||
Assert.AreEqual(1, issues.Count); |
||||
|
||||
CheckFix(context, issues, @"using System;class Test {private int member; }"); |
||||
} |
||||
|
||||
[Test] |
||||
public void TestInspectorCase2() |
||||
{ |
||||
var input = @"using System;class Test {private int member;public Test(){} static Test(){}}"; |
||||
|
||||
TestRefactoringContext context; |
||||
var issues = GetIssues(new RedundantConstructorIssue(), input, out context); |
||||
Assert.AreEqual(1, issues.Count); |
||||
|
||||
CheckFix(context, issues, @"using System;class Test {private int member; static Test(){}}"); |
||||
} |
||||
|
||||
[Test] |
||||
public void TestResharperDisable() |
||||
{ |
||||
var input = @"using System;
|
||||
//Resharper disable RedundantConstructor
|
||||
class Test { |
||||
public Test(){ |
||||
} |
||||
//Resharper restore RedundantConstructor
|
||||
}";
|
||||
|
||||
TestRefactoringContext context; |
||||
var issues = GetIssues(new RedundantConstructorIssue(), input, out context); |
||||
Assert.AreEqual(0, issues.Count); |
||||
} |
||||
|
||||
[Test] |
||||
public void TestNegateCase1() |
||||
{ |
||||
var input = @"using System;class Test {public Test(){;}}"; |
||||
|
||||
TestRefactoringContext context; |
||||
var issues = GetIssues(new RedundantConstructorIssue(), input, out context); |
||||
Assert.AreEqual(0, issues.Count); |
||||
} |
||||
|
||||
[Test] |
||||
public void TestNegateCase2() |
||||
{ |
||||
var input = @"using System;class Test {public Test(){;} private Test(){}}"; |
||||
|
||||
TestRefactoringContext context; |
||||
var issues = GetIssues(new RedundantConstructorIssue(), input, out context); |
||||
Assert.AreEqual(0, issues.Count); |
||||
} |
||||
} |
||||
} |
||||
Loading…
Reference in new issue