From 422880a2a15daa07905a19eaa7e8fc2f1a5de6ba Mon Sep 17 00:00:00 2001 From: Daniel Grunwald Date: Sat, 23 May 2009 12:29:54 +0000 Subject: [PATCH] Fixed opening projects without explicitly set ToolsVersion git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/branches/dotnet4@4119 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61 --- src/Main/Base/Project/Src/Project/MSBuildBasedProject.cs | 5 ++++- src/Main/Base/Project/Src/Project/MSBuildEngine.cs | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Main/Base/Project/Src/Project/MSBuildBasedProject.cs b/src/Main/Base/Project/Src/Project/MSBuildBasedProject.cs index 318870b924..ef1f8a2919 100644 --- a/src/Main/Base/Project/Src/Project/MSBuildBasedProject.cs +++ b/src/Main/Base/Project/Src/Project/MSBuildBasedProject.cs @@ -332,7 +332,10 @@ namespace ICSharpCode.SharpDevelop.Project Dictionary globalProps = new Dictionary(); globalProps["Configuration"] = configuration; globalProps["Platform"] = platform; - var project = new MSBuild.Project(projectFile, globalProps, projectFile.ToolsVersion, projectCollection); + string toolsVersion = projectFile.ToolsVersion; + if (string.IsNullOrEmpty(toolsVersion)) + toolsVersion = projectCollection.DefaultToolsVersion; + var project = new MSBuild.Project(projectFile, globalProps, toolsVersion, projectCollection); return new ConfiguredProject(this, project); } catch { // Leave lock only on exceptions. diff --git a/src/Main/Base/Project/Src/Project/MSBuildEngine.cs b/src/Main/Base/Project/Src/Project/MSBuildEngine.cs index 916a667194..0ddf8a8f6b 100644 --- a/src/Main/Base/Project/Src/Project/MSBuildEngine.cs +++ b/src/Main/Base/Project/Src/Project/MSBuildEngine.cs @@ -76,7 +76,7 @@ namespace ICSharpCode.SharpDevelop.Project } - public static void StartBuild(MSBuildBasedProject project, ProjectBuildOptions options, IBuildFeedbackSink feedbackSink, IEnumerable additionalTargetFiles) + public static void StartBuild(IProject project, ProjectBuildOptions options, IBuildFeedbackSink feedbackSink, IEnumerable additionalTargetFiles) { if (project == null) throw new ArgumentNullException("project"); @@ -92,12 +92,12 @@ namespace ICSharpCode.SharpDevelop.Project engine.StartBuild(); } - MSBuildBasedProject project; + IProject project; ProjectBuildOptions options; IBuildFeedbackSink feedbackSink; IEnumerable additionalTargetFiles; - private MSBuildEngine(MSBuildBasedProject project, ProjectBuildOptions options, IBuildFeedbackSink feedbackSink) + private MSBuildEngine(IProject project, ProjectBuildOptions options, IBuildFeedbackSink feedbackSink) { this.project = project; this.options = options;