Browse Source

Remove "Remove Field Refactory" as it is dangerous.

pull/32/merge
Ciprian Khlud 12 years ago
parent
commit
3dcad69810
  1. 12
      ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj
  2. 110
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/RemoveFieldRefactoryActionRefactoringAction.cs
  3. 96
      ICSharpCode.NRefactory.Tests/CSharp/CodeActions/RemoveFieldRefactoryActionTests.cs
  4. 15
      ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj
  5. BIN
      NRefactory.suo

12
ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj

@ -534,7 +534,6 @@ @@ -534,7 +534,6 @@
<Compile Include="Refactoring\CodeIssues\RedundantBaseConstructorIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ConstructorIssues\RedudantConstructorIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ConstructorIssues\PublicConstructorInAbstractClass.cs" />
<Compile Include="Refactoring\CodeActions\RemoveFieldRefactoryActionRefactoringAction.cs" />
<Compile Include="Refactoring\CodeIssues\ConvertToStaticMethodIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ParameterCanBeDemotedIssue\ParameterCanBeIEnumerableIssue.cs" />
<Compile Include="Refactoring\CodeIssues\DuplicateBodyMethodIssue.cs" />
@ -546,16 +545,7 @@ @@ -546,16 +545,7 @@
</ProjectReference>
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.Targets" />
<ItemGroup>
<Folder Include="Completion\" />
<Folder Include="Refactoring\CodeIssues\" />
<Folder Include="Refactoring\CodeIssues\InconsistentNamingIssue\" />
<Folder Include="Refactoring\CodeActions\ExtractMethod\" />
<Folder Include="Refactoring\CodeActions\ConvertToInitializer\" />
<Folder Include="Refactoring\CodeIssues\FormatStringIssues\" />
<Folder Include="Refactoring\CodeIssues\CompilerErrors\" />
<Folder Include="Refactoring\CodeIssues\ConstructorIssues\" />
</ItemGroup>
<ItemGroup />
<ProjectExtensions>
<MonoDevelop>
<Properties>

110
ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/RemoveFieldRefactoryActionRefactoringAction.cs

@ -1,110 +0,0 @@ @@ -1,110 +0,0 @@
//
// RemoveField.cs
//
// Author:
// Ciprian Khlud <ciprian.mustiata@yahoo.com>
//
// Copyright (c) 2013 Ciprian Khlud
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System;
using ICSharpCode.NRefactory.CSharp.Refactoring;
using System.Collections.Generic;
using ICSharpCode.NRefactory.CSharp.Resolver;
using ICSharpCode.NRefactory.Semantics;
namespace ICSharpCode.NRefactory.CSharp
{
[ContextAction("Removes a field from a class", Description = "It removes also the empty assingments and the usages")]
public class RemoveFieldRefactoryAction : ICodeActionProvider
{
public IEnumerable<CodeAction> GetActions(RefactoringContext context)
{
var fieldDeclaration = GetFieldDeclaration(context);
if(fieldDeclaration==null)
yield break;
yield return new CodeAction(string.Format(context.TranslateString("Remove field '{0}'"), fieldDeclaration.Name)
, script => GenerateNewScript(
script, fieldDeclaration, context), fieldDeclaration);
}
void GenerateNewScript(Script script, FieldDeclaration fieldDeclaration, RefactoringContext context)
{
var firstOrNullObject = fieldDeclaration.Variables.FirstOrNullObject();
if(firstOrNullObject==null)
return;
var matchedNodes = ComputeMatchNodes(context, firstOrNullObject);
foreach (var matchNode in matchedNodes)
{
var parent = matchNode.Parent;
if (matchNode is VariableInitializer)
{
script.Remove(parent);
}
else
if (matchNode is IdentifierExpression)
{
if(parent is AssignmentExpression)
{
script.Remove(parent.Parent);
}
else
{
var clone = (IdentifierExpression)matchNode.Clone();
clone.Identifier = "TODO";
script.Replace(matchNode, clone);
}
}
}
}
private static List<AstNode> ComputeMatchNodes(RefactoringContext context, VariableInitializer firstOrNullObject)
{
var referenceFinder = new FindReferences();
var matchedNodes = new List<AstNode>();
var resolveResult = context.Resolver.Resolve(firstOrNullObject);
var member = resolveResult as MemberResolveResult;
if (member == null)//not a member is unexpected case, so is better to return no match than to break the code
return matchedNodes;
FoundReferenceCallback callback = (matchNode, result) => matchedNodes.Add(matchNode);
var searchScopes = referenceFinder.GetSearchScopes(member.Member);
referenceFinder.FindReferencesInFile(searchScopes,
context.UnresolvedFile,
context.RootNode as SyntaxTree,
context.Compilation, callback,
context.CancellationToken);
return matchedNodes;
}
FieldDeclaration GetFieldDeclaration(RefactoringContext context)
{
var result = context.GetNode<FieldDeclaration>();
return result;
}
}
}

96
ICSharpCode.NRefactory.Tests/CSharp/CodeActions/RemoveFieldRefactoryActionTests.cs

@ -1,96 +0,0 @@ @@ -1,96 +0,0 @@
//
// RemoveFieldRefactoryActionTests.cs
//
// Author:
// Ciprian Khlud <ciprian.mustiata@yahoo.com>
//
// Copyright (c) 2013 Ciprian Khlud
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using NUnit.Framework;
namespace ICSharpCode.NRefactory.CSharp.CodeActions
{
[TestFixture]
public class RemoveFieldRefactoryActionTests : ContextActionTestBase
{
[Test]
public void RemoveOneField()
{
Test<RemoveFieldRefactoryAction>(
@"
class A {
int $field;
}
",
@"
class A {
}
"
);}
[Test]
public void RemoveOneFieldAndAssignmentValue()
{
Test<RemoveFieldRefactoryAction>(
@"
class A {
int $field;
A() {
field = 3;
}
}
",
@"
class A {
A() {
}
}
"
);
}
[Test]
public void RemoveOneFieldAndAssignmentValueAndMethodCall()
{
Test<RemoveFieldRefactoryAction>(
@"
class A {
int $field;
A() {
field = 3;
if(field!=0)
Method(field);
}
}
",
@"
class A {
A() {
if(TODO!=0)
Method(TODO);
}
}
"
);
}
}
}

15
ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj

@ -1,4 +1,4 @@ @@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build">
<PropertyGroup>
<ProjectGuid>{63D3B27A-D966-4902-90B3-30290E1692F1}</ProjectGuid>
@ -409,7 +409,6 @@ @@ -409,7 +409,6 @@
<Compile Include="CSharp\CodeIssues\RedundantConstructorTests.cs" />
<Compile Include="CSharp\CodeIssues\PublicConstructorInAbstractClassIssueTest.cs" />
<Compile Include="CSharp\CodeIssues\ExpressionOfCompatibleTypeCastIssueTests.cs" />
<Compile Include="CSharp\CodeActions\RemoveFieldRefactoryActionTests.cs" />
<Compile Include="CSharp\CodeIssues\ConvertToStaticMethodIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\ParameterCanBeDemotedIssue\ParameterCanBeIEnumerableTests.cs" />
<Compile Include="CSharp\CodeIssues\DuplicateBodyMethodIssueTests.cs" />
@ -435,17 +434,7 @@ @@ -435,17 +434,7 @@
<Private>False</Private>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Folder Include="CSharp\" />
<Folder Include="CSharp\Parser\" />
<Folder Include="CSharp\CodeIssues\" />
<Folder Include="CSharp\CodeActions\" />
<Folder Include="CSharp\Parser\Bugs\" />
<Folder Include="CSharp\CodeActions\ConvertToInitializer\" />
<Folder Include="CSharp\CodeIssues\ParameterCanBeDemotedIssue\" />
<Folder Include="Utils\CompositeFormatStringParser\" />
<Folder Include="CSharp\CodeIssues\FormatStringIssues\" />
</ItemGroup>
<ItemGroup />
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<ProjectExtensions>
<MonoDevelop>

BIN
NRefactory.suo

Binary file not shown.
Loading…
Cancel
Save