From 3b46fef92b8eb79cc6737baa62d83c0620146d08 Mon Sep 17 00:00:00 2001 From: mkrueger <> Date: Thu, 28 Feb 2013 13:34:56 +0100 Subject: [PATCH] Fixed bug in redundant field initializer issue. --- .../CodeIssues/RedundantFieldInitializerIssue.cs | 3 ++- .../CodeIssues/RedundantFieldInitializerIssueTests.cs | 11 ++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantFieldInitializerIssue.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantFieldInitializerIssue.cs index 42db6f44d8..67def44769 100644 --- a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantFieldInitializerIssue.cs +++ b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantFieldInitializerIssue.cs @@ -52,7 +52,8 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring public override void VisitFieldDeclaration (FieldDeclaration fieldDeclaration) { base.VisitFieldDeclaration (fieldDeclaration); - + if (fieldDeclaration.HasModifier (Modifiers.Const)) + return; var defaultValueExpr = GetDefaultValueExpression (fieldDeclaration.ReturnType); if (defaultValueExpr == null) return; diff --git a/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/RedundantFieldInitializerIssueTests.cs b/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/RedundantFieldInitializerIssueTests.cs index 13df8cc531..366691ed63 100644 --- a/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/RedundantFieldInitializerIssueTests.cs +++ b/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/RedundantFieldInitializerIssueTests.cs @@ -153,7 +153,7 @@ class TestClass }"; Test (input, 1, output); } - + [Test] public void TestRedundantNullableInitializer () { @@ -169,5 +169,14 @@ class TestClass }"; Test (input, 1, output); } + + + [Test] + public void TestRedundantConstantBug () + { + Test (@"class Test { const int foo = 0; }", 0); + } + + } }