SharpDevelopMain.RunApplication() does not eat all exceptions

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@752 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/Main/StartUp/Project/SharpDevelopMain.cs

@@ -153,12 +153,12 @@ namespace ICSharpCode.SharpDevelop
 			try {
 				#if DEBUG
 				if (!Debugger.IsAttached) {
-					#endif
 					Application.ThreadException += ShowErrorBox;
 					AppDomain.CurrentDomain.UnhandledException += ShowErrorBox;
-					#if DEBUG
 				}
 				#else
+				Application.ThreadException += ShowErrorBox;
+				AppDomain.CurrentDomain.UnhandledException += ShowErrorBox;
 				MessageService.CustomErrorReporter = ShowErrorBox;
 				#endif
 				
@@ -178,14 +178,12 @@ namespace ICSharpCode.SharpDevelop
 					SplashScreenForm.SplashScreen.Dispose();
 				}
 				
-				bool exception = false;
+				bool exception = true;
 				// finally start the workbench.
 				try {
 					LoggingService.Info("Starting workbench...");
 					new StartWorkbenchCommand().Run(SplashScreenForm.GetRequestedFileList());
-				} catch {
-					exception = true;
-					throw;
+					exception = false;
 				} finally {
 					LoggingService.Info("Unloading services...");
 					try {