Browse Source

Adjusted default Fdg rules a bit (private static fields are now

camelCase).
newNRvisualizers
Mike Krüger 14 years ago
parent
commit
34b3e18c2a
  1. 28
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/InconsistentNamingIssue/DefaultRules.cs
  2. 8
      ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/InconsistentNamingTests.cs

28
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/InconsistentNamingIssue/DefaultRules.cs

@ -71,9 +71,21 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -71,9 +71,21 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
NamingStyle = NamingStyle.PascalCase
};
yield return new NamingRule(AffectedEntity.Field | AffectedEntity.ReadonlyField) {
yield return new NamingRule(AffectedEntity.ReadonlyField) {
Name = "Static Readonly Fields",
NamingStyle = NamingStyle.PascalCase,
IncludeInstanceMembers = false
};
yield return new NamingRule(AffectedEntity.Field) {
Name = "Fields (Non Private)",
NamingStyle = NamingStyle.PascalCase,
VisibilityMask = Modifiers.Public | Modifiers.Protected | Modifiers.Internal
};
yield return new NamingRule(AffectedEntity.ReadonlyField) {
Name = "ReadOnly Fields (Non Private)",
NamingStyle = NamingStyle.PascalCase,
VisibilityMask = Modifiers.Public | Modifiers.Protected | Modifiers.Internal,
IncludeStaticEntities = false
};
@ -81,18 +93,16 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -81,18 +93,16 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
yield return new NamingRule(AffectedEntity.Field | AffectedEntity.ReadonlyField) {
Name = "Fields (Private)",
NamingStyle = NamingStyle.CamelCase,
VisibilityMask = Modifiers.Private
};
yield return new NamingRule(AffectedEntity.ReadonlyField) {
Name = "ReadOnly Fields (Private)",
NamingStyle = NamingStyle.CamelCase,
VisibilityMask = Modifiers.Private,
IncludeStaticEntities = false
};
yield return new NamingRule(AffectedEntity.Field | AffectedEntity.ReadonlyField) {
Name = "Static fields",
NamingStyle = NamingStyle.PascalCase,
VisibilityMask = Modifiers.VisibilityMask,
IncludeStaticEntities = true,
IncludeInstanceMembers = false
};
yield return new NamingRule(AffectedEntity.ConstantField) {
Name = "Constant Fields",
NamingStyle = NamingStyle.PascalCase,

8
ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/InconsistentNamingTests.cs

@ -153,6 +153,14 @@ namespace ICSharpCode.NRefactory.CSharp.CodeIssues @@ -153,6 +153,14 @@ namespace ICSharpCode.NRefactory.CSharp.CodeIssues
CheckNaming (input, output);
}
[Test]
public void TestPrivateStaticFieldName ()
{
var input = @"class AClass { static int Field; }";
var output = @"class AClass { static int field; }";
CheckNaming (input, output);
}
[Test]
public void TestPublicStaticReadOnlyFieldName ()
{

Loading…
Cancel
Save