Mansheng Yang
14 years ago
4 changed files with 147 additions and 4 deletions
@ -0,0 +1,78 @@
@@ -0,0 +1,78 @@
|
||||
//
|
||||
// DoubleNegationIssue.cs
|
||||
//
|
||||
// Author:
|
||||
// Mansheng Yang <lightyang0@gmail.com>
|
||||
//
|
||||
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the "Software"), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
|
||||
using System.Collections.Generic; |
||||
|
||||
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
||||
{ |
||||
[IssueDescription ("Double negation is meaningless", |
||||
Description = "Double negation is meaningless.", |
||||
Category = IssueCategories.Redundancies, |
||||
Severity = Severity.Warning, |
||||
IssueMarker = IssueMarker.Underline)] |
||||
public class DoubleNegationIssue : ICodeIssueProvider |
||||
{ |
||||
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context) |
||||
{ |
||||
return new GatherVisitor (context).GetIssues (); |
||||
} |
||||
|
||||
class GatherVisitor : GatherVisitorBase |
||||
{ |
||||
public GatherVisitor (BaseRefactoringContext ctx) |
||||
: base (ctx) |
||||
{ |
||||
} |
||||
|
||||
static Expression RemoveParentheses (Expression expr) |
||||
{ |
||||
while (expr is ParenthesizedExpression) |
||||
expr = ((ParenthesizedExpression) expr).Expression; |
||||
return expr; |
||||
} |
||||
|
||||
public override void VisitUnaryOperatorExpression (UnaryOperatorExpression unaryOperatorExpression) |
||||
{ |
||||
base.VisitUnaryOperatorExpression (unaryOperatorExpression); |
||||
|
||||
if (unaryOperatorExpression.Operator != UnaryOperatorType.Not) |
||||
return; |
||||
|
||||
var innerUnaryOperatorExpr = |
||||
RemoveParentheses (unaryOperatorExpression.Expression) as UnaryOperatorExpression; |
||||
if (innerUnaryOperatorExpr == null || innerUnaryOperatorExpr.Operator != UnaryOperatorType.Not) |
||||
return; |
||||
|
||||
var expression = RemoveParentheses (innerUnaryOperatorExpr.Expression); |
||||
if (expression.IsNull) |
||||
return; |
||||
|
||||
AddIssue (unaryOperatorExpression, ctx.TranslateString ("Remove double negation"), |
||||
script => script.Replace (unaryOperatorExpression, expression.Clone ())); |
||||
} |
||||
} |
||||
} |
||||
} |
||||
@ -0,0 +1,63 @@
@@ -0,0 +1,63 @@
|
||||
//
|
||||
// DoubleNegationIssueTests.cs
|
||||
//
|
||||
// Author:
|
||||
// Mansheng Yang <lightyang0@gmail.com>
|
||||
//
|
||||
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the "Software"), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
|
||||
using ICSharpCode.NRefactory.CSharp.Refactoring; |
||||
using NUnit.Framework; |
||||
|
||||
namespace ICSharpCode.NRefactory.CSharp.CodeIssues |
||||
{ |
||||
[TestFixture] |
||||
public class DoubleNegationIssueTests : InspectionActionTestBase |
||||
{ |
||||
[Test] |
||||
public void Test () |
||||
{ |
||||
var input = @"
|
||||
class TestClass |
||||
{ |
||||
bool GetBool () { } |
||||
|
||||
void TestMethod () |
||||
{ |
||||
var x = !!GetBool (); |
||||
x = !(!(GetBool ())); |
||||
} |
||||
}";
|
||||
var output = @"
|
||||
class TestClass |
||||
{ |
||||
bool GetBool () { } |
||||
|
||||
void TestMethod () |
||||
{ |
||||
var x = GetBool (); |
||||
x = GetBool (); |
||||
} |
||||
}";
|
||||
Test<DoubleNegationIssue> (input, 2, output); |
||||
} |
||||
} |
||||
} |
||||
Loading…
Reference in new issue