Browse Source

[CodeIssue] TypeParameterNotUsedIssue: removed the fix because it may introduce errors.

newNRvisualizers
Mansheng Yang 13 years ago
parent
commit
1c0a7305f5
  1. 10
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/TypeParameterNotUsedIssue.cs
  2. 8
      ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/TypeParameterNotUsedIssueTests.cs

10
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/TypeParameterNotUsedIssue.cs

@ -86,15 +86,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -86,15 +86,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
if (FindUsage (ctx, unit, typeParameter, decl))
return;
AddIssue (decl.NameToken, ctx.TranslateString ("Remove unused type parameter"),
script =>
{
var newMethodDecl = (MethodDeclaration)methodDecl.Clone ();
newMethodDecl.TypeParameters.Remove (
newMethodDecl.TypeParameters.FirstOrNullObject (t => t.Name == decl.Name));
script.Replace (methodDecl, newMethodDecl);
});
AddIssue (decl.NameToken, ctx.TranslateString ("Type parameter is never used"));
}
}
}

8
ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/TypeParameterNotUsedIssueTests.cs

@ -42,13 +42,7 @@ class TestClass { @@ -42,13 +42,7 @@ class TestClass {
{
}
}";
var output = @"
class TestClass {
void TestMethod ()
{
}
}";
Test<TypeParameterNotUsedIssue> (input, 1, output);
Test<TypeParameterNotUsedIssue> (input, 1);
}
[Test]

Loading…
Cancel
Save