"F12 to Find references" also works on local variables.

Added error messages if F11 is pressed when caret is not over valid symbol. (Go to definition / Find references stays without error message - error message might be annoying; I think F11 needs some explanation to the user though)

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@6098 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/Main/Base/Project/Src/Editor/Commands/FindBaseClasses.cs

@@ -5,6 +5,7 @@
 //     <version>$Revision: $</version>
 // </file>
 using System;
+using ICSharpCode.Core;
 using ICSharpCode.SharpDevelop.Dom;
 using ICSharpCode.SharpDevelop.Refactoring;
 
@@ -17,14 +18,13 @@ namespace ICSharpCode.SharpDevelop.Editor.Commands
 	{
 		protected override void RunImpl(ITextEditor editor, int offset, ResolveResult symbol)
 		{
-			if (symbol == null)
+			var classUnderCaret = GetClass(symbol);
-				return;
+			if (classUnderCaret != null)
-			if (symbol is TypeResolveResult) {
+			{
-				var classUnderCaret = ((TypeResolveResult)symbol).ResolvedClass;
-				if (classUnderCaret == null)
-					return;
 				ContextActionsHelper.MakePopupWithBaseClasses(classUnderCaret).Open(editor);
+				return;
 			}
+			MessageService.ShowError("${res:ICSharpCode.Refactoring.NoClassUnderCursorError}");
 		}
 	}
 }

src/Main/Base/Project/Src/Editor/Commands/FindDerivedClassesOrOverrides.cs

@@ -5,6 +5,7 @@
 //     <version>$Revision: $</version>
 // </file>
 using System;
+using ICSharpCode.Core;
 using ICSharpCode.SharpDevelop.Dom;
 using ICSharpCode.SharpDevelop.Refactoring;
 
@@ -17,20 +18,18 @@ namespace ICSharpCode.SharpDevelop.Editor.Commands
 	{
 		protected override void RunImpl(ITextEditor editor, int offset, ResolveResult symbol)
 		{
-			if (symbol == null)
+			var classUnderCaret = GetClass(symbol);
-				return;
+			if (classUnderCaret != null) {
-			if (symbol is TypeResolveResult) {
-				var classUnderCaret = ((TypeResolveResult)symbol).ResolvedClass;
-				if (classUnderCaret == null)
-					return;
 				ContextActionsHelper.MakePopupWithDerivedClasses(classUnderCaret).Open(editor);
+				return;
 			}
-			if (symbol is MemberResolveResult) {
+			var memberUnderCaret = GetMember(symbol);
-				IMember memberUnderCaret = ((MemberResolveResult)symbol).ResolvedMember as IMember;
+			if (memberUnderCaret != null && memberUnderCaret.IsOverridable)
-				if (memberUnderCaret != null && memberUnderCaret.IsOverridable) {
+			{
-					ContextActionsHelper.MakePopupWithOverrides(memberUnderCaret).Open(editor);
+				ContextActionsHelper.MakePopupWithOverrides(memberUnderCaret).Open(editor);
-				}
+				return;
 			}
+			MessageService.ShowError("${res:ICSharpCode.Refactoring.NoClassOrOverridableSymbolUnderCursorError}");
 		}
 	}
 }

src/Main/Base/Project/Src/Editor/Commands/FindReferences.cs

@@ -17,19 +17,19 @@ namespace ICSharpCode.SharpDevelop.Editor.Commands
 	{
 		protected override void RunImpl(ITextEditor editor, int offset, ResolveResult symbol)
 		{
-			if (symbol == null)
+			var classUnderCaret = GetClass(symbol);
-				return;
+			if (classUnderCaret != null) {
-			if (symbol is TypeResolveResult) {
-				var classUnderCaret = ((TypeResolveResult)symbol).ResolvedClass;
-				if (classUnderCaret == null)
-					return;
 				FindReferencesAndRenameHelper.RunFindReferences(classUnderCaret);
+				return;
 			}
-			if (symbol is MemberResolveResult) {
+			var memberUnderCaret = GetMember(symbol);
-				IMember memberUnderCaret = ((MemberResolveResult)symbol).ResolvedMember as IMember;
+			if (memberUnderCaret != null)
-				if (memberUnderCaret == null)
+			{
-					return;
 				FindReferencesAndRenameHelper.RunFindReferences(memberUnderCaret);
+				return;
+			}
+			if (symbol is LocalResolveResult) {
+				FindReferencesAndRenameHelper.RunFindReferences((LocalResolveResult)symbol);
 			}
 		}
 	}

src/Main/Base/Project/Src/Editor/Commands/SymbolUnderCaretCommand.cs

@@ -30,6 +30,22 @@ namespace ICSharpCode.SharpDevelop.Editor.Commands
 			RunImpl(editor, caretOffset, resolveResult);
 		}
 		
+		public IClass GetClass(ResolveResult symbol)
+		{
+			if (symbol == null || !(symbol is TypeResolveResult)) {
+				return null;
+			}
+			return ((TypeResolveResult)symbol).ResolvedClass;
+		}
+		
+		public IMember GetMember(ResolveResult symbol)
+		{
+			if (symbol == null || !(symbol is MemberResolveResult)) {
+				return null;
+			}
+			return ((MemberResolveResult)symbol).ResolvedMember;
+		}
+		
 		protected abstract void RunImpl(ITextEditor editor, int caretOffset, ResolveResult symbol);
 	}
 }

src/Main/Base/Project/Src/Services/RefactoringService/FindReferencesAndRenameHelper.cs

@@ -545,11 +545,20 @@ namespace ICSharpCode.SharpDevelop.Refactoring
 			}
 		}
 		
+		public static void RunFindReferences(LocalResolveResult local)
+		{
+			FindReferencesAndRenameHelper.ShowAsSearchResults(
+				StringParser.Parse("${res:SharpDevelop.Refactoring.ReferencesTo}",
+				                   new string[,] {{ "Name", local.VariableName }}),
+				RefactoringService.FindReferences(local, null)
+			);
+		}
+		
 		public static ICSharpCode.Core.WinForms.MenuCommand MakeFindReferencesMenuCommand(EventHandler handler)
 		{
 			return new ICSharpCode.Core.WinForms.MenuCommand("${res:SharpDevelop.Refactoring.FindReferencesCommand}", handler) {
-			                                                 	ShortcutKeys = System.Windows.Forms.Keys.F12
+				ShortcutKeys = System.Windows.Forms.Keys.F12
-			                                                 };
+			};
 		}
 		#endregion
 	}

src/Main/Base/Project/Src/Services/RefactoringService/LocalVariableRefactoring.cs

@@ -18,11 +18,7 @@ namespace ICSharpCode.SharpDevelop.Refactoring
 		{
 			RefactoringMenuContext context = (RefactoringMenuContext)Owner;
 			LocalResolveResult local = (LocalResolveResult)context.ResolveResult;
-			FindReferencesAndRenameHelper.ShowAsSearchResults(
+			FindReferencesAndRenameHelper.RunFindReferences(local);
-				StringParser.Parse("${res:SharpDevelop.Refactoring.ReferencesTo}",
-				                   new string[,] {{ "Name", local.VariableName }}),
-				RefactoringService.FindReferences(local, null)
-			);
 		}
 	}