ILSpy

.NET Decompiler with support for PDB generation, ReadyToRun, Metadata (&more) - cross-platform!

c-sharp dotnet mono decompile decompiler decompiler-engine dotnetcore ilspy pdb unity

Siegfried Pammer ba7fe1d75f Share the settings-derived type system between tree, search, and views LoadedAssembly caches one type system per TypeSystemOptions value, but the consumers disagreed on which one to use: tree nodes and the metadata navigator resolved through GetTypeSystemOrNull (a separate default-options instance) and the search built its request with default settings. Each module could therefore materialise several type systems, and none of the display surfaces respected settings that change entity shapes (nullability, tuples, extension methods, ...). WPF routed all of these through GetTypeSystemWithCurrentOptionsOrNull. Reintroduce that helper on top of CreateEffectiveDecompilerSettings and use it in TypeTreeNode, AssemblyReferenceTreeNode, and the metadata navigator; the search request now derives its settings the same way, so all of them hit the same cached instance. NamespaceTreeNode.Decompile enumerates through the type system matching the decompilation options it was handed. Assisted-by: Claude:claude-fable-5:Claude Code	3 months ago
..
TypeSystemSharingTests.cs	Share the settings-derived type system between tree, search, and views	3 months ago

Siegfried Pammer ba7fe1d75f Share the settings-derived type system between tree, search, and views

LoadedAssembly caches one type system per TypeSystemOptions value, but
the consumers disagreed on which one to use: tree nodes and the
metadata navigator resolved through GetTypeSystemOrNull (a separate
default-options instance) and the search built its request with default
settings. Each module could therefore materialise several type systems,
and none of the display surfaces respected settings that change entity
shapes (nullability, tuples, extension methods, ...). WPF routed all of
these through GetTypeSystemWithCurrentOptionsOrNull.

Reintroduce that helper on top of CreateEffectiveDecompilerSettings and
use it in TypeTreeNode, AssemblyReferenceTreeNode, and the metadata
navigator; the search request now derives its settings the same way, so
all of them hit the same cached instance. NamespaceTreeNode.Decompile
enumerates through the type system matching the decompilation options
it was handed.

Assisted-by: Claude:claude-fable-5:Claude Code

3 months ago

TypeSystemSharingTests.cs

Share the settings-derived type system between tree, search, and views

3 months ago