mirror of https://github.com/icsharpcode/ILSpy.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
192 lines
8.9 KiB
192 lines
8.9 KiB
// Copyright (c) 2026 AlphaSierraPapa for the SharpDevelop Team |
|
// |
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this |
|
// software and associated documentation files (the "Software"), to deal in the Software |
|
// without restriction, including without limitation the rights to use, copy, modify, merge, |
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons |
|
// to whom the Software is furnished to do so, subject to the following conditions: |
|
// |
|
// The above copyright notice and this permission notice shall be included in all copies or |
|
// substantial portions of the Software. |
|
// |
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, |
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR |
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE |
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR |
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER |
|
// DEALINGS IN THE SOFTWARE. |
|
|
|
using System.Linq; |
|
using System.Threading.Tasks; |
|
|
|
using Avalonia; |
|
using Avalonia.Controls; |
|
using Avalonia.Headless; |
|
using Avalonia.Headless.NUnit; |
|
using Avalonia.Input; |
|
using Avalonia.VisualTree; |
|
|
|
using AwesomeAssertions; |
|
|
|
using ICSharpCode.ILSpy.AppEnv; |
|
using ICSharpCode.ILSpy.AssemblyTree; |
|
using ICSharpCode.ILSpy.Docking; |
|
using ICSharpCode.ILSpy.TreeNodes; |
|
using ICSharpCode.ILSpy.ViewModels; |
|
using ICSharpCode.ILSpy.Views; |
|
|
|
using NUnit.Framework; |
|
|
|
namespace ICSharpCode.ILSpy.Tests.Input; |
|
|
|
/// <summary> |
|
/// Drives a real <see cref="HeadlessWindowExtensions.MouseDown"/> event through the |
|
/// input pipeline so the MMB → "open in new tab" gesture is verified end-to-end |
|
/// rather than via a synthetic <c>OpenNodeInNewTab</c> call. Catches routing regressions |
|
/// (the existing synthetic tests would pass even if the PointerPressed handler stopped |
|
/// being installed). |
|
/// </summary> |
|
[TestFixture] |
|
public class HeadlessMmbPointerTests |
|
{ |
|
[AvaloniaTest] |
|
public async Task Middle_Click_On_An_Assembly_Tree_Row_Opens_A_New_Decompiler_Tab() |
|
{ |
|
// Boot + load enough assemblies that we have visible rows. |
|
var window = AppComposition.Current.GetExport<MainWindow>(); |
|
window.Show(); |
|
var vm = (MainWindowViewModel)window.DataContext!; |
|
await vm.AssemblyTreeModel.WaitForAssembliesAsync(minimumCount: 1); |
|
|
|
var pane = await window.WaitForComponent<AssemblyListPane>(); |
|
var grid = await pane.WaitForComponent<ICSharpCode.ILSpy.Controls.TreeView.SharpTreeView>(); |
|
var (topLevel, centreInTopLevel) = await WaitForClickableRowAsync(grid); |
|
|
|
// Snapshot the tab count BEFORE the gesture so we can assert a strict +1 after. |
|
var documents = ((ILSpyDockFactory)vm.DockWorkspace.Factory).Documents!; |
|
int before = documents.VisibleDockables?.Count ?? 0; |
|
|
|
// Real pointer event — exercises bubble + handledEventsToo routing through SharpTreeView. |
|
topLevel.MouseDown(centreInTopLevel, MouseButton.Middle); |
|
topLevel.MouseUp(centreInTopLevel, MouseButton.Middle); |
|
|
|
// Wait for the tab to land. Without WaitForAsync this races the async decompile path. |
|
await Waiters.WaitForAsync(() => (documents.VisibleDockables?.Count ?? 0) > before); |
|
|
|
(documents.VisibleDockables?.Count ?? 0).Should().Be(before + 1); |
|
} |
|
|
|
[AvaloniaTest] |
|
public async Task Ctrl_LMB_On_An_Assembly_Tree_Row_Does_Not_Open_A_New_Tab() |
|
{ |
|
// Ctrl+LMB previously did double duty: the tree's Extended-selection mode treats |
|
// it as "toggle this row in the multi-selection", and our OnTreePointerPressed |
|
// also treated it as "open in new tab". Both fired on a single click, so users |
|
// trying to extend a multi-selection ended up spawning unwanted tabs. The intended |
|
// gesture for "open in new tab" is MMB (matches WPF's DecompileInNewViewCommand |
|
// InputGestureText). Pin the corrected behaviour: Ctrl+LMB must NOT open a tab — |
|
// any future regression that re-adds the branch fails this test. |
|
|
|
var window = AppComposition.Current.GetExport<MainWindow>(); |
|
window.Show(); |
|
var vm = (MainWindowViewModel)window.DataContext!; |
|
await vm.AssemblyTreeModel.WaitForAssembliesAsync(minimumCount: 1); |
|
|
|
var pane = await window.WaitForComponent<AssemblyListPane>(); |
|
var grid = await pane.WaitForComponent<ICSharpCode.ILSpy.Controls.TreeView.SharpTreeView>(); |
|
var (topLevel, centreInTopLevel) = await WaitForClickableRowAsync(grid); |
|
|
|
var documents = ((ILSpyDockFactory)vm.DockWorkspace.Factory).Documents!; |
|
int before = documents.VisibleDockables?.Count ?? 0; |
|
|
|
topLevel.MouseDown(centreInTopLevel, MouseButton.Left, RawInputModifiers.Control); |
|
topLevel.MouseUp(centreInTopLevel, MouseButton.Left, RawInputModifiers.Control); |
|
|
|
// Give the (former) "open new tab" path a beat to land if it were going to. |
|
await Task.Delay(250); |
|
global::Avalonia.Threading.Dispatcher.UIThread.RunJobs(); |
|
|
|
(documents.VisibleDockables?.Count ?? 0).Should().Be(before, |
|
"Ctrl+LMB must be reserved for the tree's multi-selection toggle — only MMB opens a new tab"); |
|
} |
|
|
|
[AvaloniaTest] |
|
public async Task LMB_Double_Click_On_An_Internal_Tree_Row_Expands_Without_Opening_A_New_Tab() |
|
{ |
|
// LMB double-click is WPF's expand/collapse gesture. The OnTreeGridDoubleTapped handler |
|
// is supposed to be the only path that fires; an earlier patch had OnTreeGridPointerPressed |
|
// also treating double-click as a "open in new tab" gesture, which produced both effects |
|
// at once. Pin the behaviour so it doesn't drift back: double-click on an internal |
|
// (non-leaf) row must change neither the tab count nor the dock topology. |
|
|
|
var window = AppComposition.Current.GetExport<MainWindow>(); |
|
window.Show(); |
|
var vm = (MainWindowViewModel)window.DataContext!; |
|
await vm.AssemblyTreeModel.WaitForAssembliesAsync(minimumCount: 1); |
|
|
|
var pane = await window.WaitForComponent<AssemblyListPane>(); |
|
var grid = await pane.WaitForComponent<ICSharpCode.ILSpy.Controls.TreeView.SharpTreeView>(); |
|
|
|
var (topLevel, centreInTopLevel) = await WaitForClickableRowAsync(grid); |
|
|
|
var documents = ((ILSpyDockFactory)vm.DockWorkspace.Factory).Documents!; |
|
int before = documents.VisibleDockables?.Count ?? 0; |
|
|
|
// Drive two LMB clicks at the same coordinate — Avalonia.Headless interprets the |
|
// second click within the double-click threshold as a real double-click event. |
|
topLevel.MouseDown(centreInTopLevel, MouseButton.Left); |
|
topLevel.MouseUp(centreInTopLevel, MouseButton.Left); |
|
topLevel.MouseDown(centreInTopLevel, MouseButton.Left); |
|
topLevel.MouseUp(centreInTopLevel, MouseButton.Left); |
|
|
|
// Give the decompile path a beat — if a tab is going to spawn, it will have queued by |
|
// now. (We can't `WaitForAsync` on "did NOT spawn", so wait a short fixed budget.) |
|
await Task.Delay(250); |
|
global::Avalonia.Threading.Dispatcher.UIThread.RunJobs(); |
|
|
|
(documents.VisibleDockables?.Count ?? 0).Should().Be(before, |
|
"LMB double-click must not open a new tab — only MMB does"); |
|
} |
|
|
|
/// <summary> |
|
/// Waits until an assembly-tree row is actually clickable and returns the TopLevel point that |
|
/// lands on it. "Realised in the visual tree" is not enough: under layout churn (assemblies |
|
/// still streaming into the tree) the virtualizing panel can hand out a container whose Bounds |
|
/// are still empty, and a row can sit outside the grid's viewport - a pointer event aimed at |
|
/// either reaches nothing, so the gesture silently does not happen. Hit-testing the candidate |
|
/// point back to its own row before clicking rules both out. Which row is used does not matter, |
|
/// only that the click lands on one whose node is an <see cref="ILSpyTreeNode"/>. |
|
/// </summary> |
|
static async Task<(TopLevel TopLevel, Point Point)> WaitForClickableRowAsync( |
|
ICSharpCode.ILSpy.Controls.TreeView.SharpTreeView grid) |
|
{ |
|
Point point = default; |
|
await Waiters.WaitForAsync(() => TryGetRowClickPoint(grid, out point), |
|
description: "an assembly-tree row whose centre hit-tests back to that row"); |
|
return (TopLevel.GetTopLevel(grid)!, point); |
|
} |
|
|
|
static bool TryGetRowClickPoint(ICSharpCode.ILSpy.Controls.TreeView.SharpTreeView grid, out Point point) |
|
{ |
|
point = default; |
|
if (TopLevel.GetTopLevel(grid) is not { } topLevel) |
|
return false; |
|
foreach (var row in grid.GetVisualDescendants().OfType<ICSharpCode.ILSpy.Controls.TreeView.SharpTreeViewItem>()) |
|
{ |
|
if (row.DataContext is not ILSpyTreeNode || row.Bounds.Width <= 0 || row.Bounds.Height <= 0) |
|
continue; |
|
// Tree rows stretch to content width (with horizontal scroll), so clamp the click X to the |
|
// visible grid viewport - the row centre can sit off-screen past the grid's right edge. |
|
var centreInRow = new Point(System.Math.Min(row.Bounds.Width, grid.Bounds.Width) / 2, row.Bounds.Height / 2); |
|
if (row.TranslatePoint(centreInRow, topLevel) is not { } candidate) |
|
continue; |
|
if (topLevel.InputHitTest(candidate) is Visual hit |
|
&& ReferenceEquals(hit.FindAncestorOfType<ICSharpCode.ILSpy.Controls.TreeView.SharpTreeViewItem>(includeSelf: true), row)) |
|
{ |
|
point = candidate; |
|
return true; |
|
} |
|
} |
|
return false; |
|
} |
|
}
|
|
|