// // UseVarKeywordInspector.cs // // Author: // Mike Krüger // // Copyright (c) 2012 Xamarin // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell // copies of the Software, and to permit persons to whom the Software is // furnished to do so, subject to the following conditions: // // The above copyright notice and this permission notice shall be included in // all copies or substantial portions of the Software. // // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. using System; using ICSharpCode.NRefactory.PatternMatching; using System.Collections.Generic; using ICSharpCode.NRefactory.TypeSystem; using ICSharpCode.NRefactory.Semantics; using System.Linq; namespace ICSharpCode.NRefactory.CSharp.Refactoring { /// /// Checks for places where the 'var' keyword can be used. Note that the action is actually done with a context /// action. /// [IssueDescription("Use 'var' keyword", Description = "Use implicitly typed local variable decaration", Category = IssueCategories.Opportunities, Severity = Severity.Hint, IssueMarker = IssueMarker.None)] public class UseVarKeywordIssue : ICodeIssueProvider { public IEnumerable GetIssues(BaseRefactoringContext context) { return new GatherVisitor(context, this).GetIssues(); } class GatherVisitor : GatherVisitorBase { readonly UseVarKeywordIssue inspector; public GatherVisitor (BaseRefactoringContext ctx, UseVarKeywordIssue inspector) : base (ctx) { this.inspector = inspector; } public override void VisitVariableDeclarationStatement(VariableDeclarationStatement variableDeclarationStatement) { base.VisitVariableDeclarationStatement(variableDeclarationStatement); if (variableDeclarationStatement.Type is PrimitiveType) { return; } if (variableDeclarationStatement.Type is SimpleType && ((SimpleType)variableDeclarationStatement.Type).Identifier == "var") { return; } if (variableDeclarationStatement.Variables.Count != 1) { return; } //only checks for cases where the type would be obvious - assignment of new, cast, etc. //also check the type actually matches else the user might want to assign different subclasses later var v = variableDeclarationStatement.Variables.Single(); var arrCreate = v.Initializer as ArrayCreateExpression; if (arrCreate != null) { var n = variableDeclarationStatement.Type as ComposedType; //FIXME: check the specifier compatibility if (n != null && n.ArraySpecifiers.Any() && n.BaseType.IsMatch(arrCreate.Type)) { AddIssue(variableDeclarationStatement); } } var objCreate = v.Initializer as ObjectCreateExpression; if (objCreate != null && objCreate.Type.IsMatch(variableDeclarationStatement.Type)) { AddIssue(variableDeclarationStatement); } var asCast = v.Initializer as AsExpression; if (asCast != null && asCast.Type.IsMatch(variableDeclarationStatement.Type)) { AddIssue(variableDeclarationStatement); } var cast = v.Initializer as CastExpression; if (cast != null && cast.Type.IsMatch(variableDeclarationStatement.Type)) { AddIssue(variableDeclarationStatement); } } void AddIssue(VariableDeclarationStatement variableDeclarationStatement) { AddIssue(variableDeclarationStatement.Type, ctx.TranslateString("Use 'var' keyword")); } } } }