// // AssignmentMadeToSameVariableIssue.cs // // Author: // Mansheng Yang // // Copyright (c) 2012 Mansheng Yang // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell // copies of the Software, and to permit persons to whom the Software is // furnished to do so, subject to the following conditions: // // The above copyright notice and this permission notice shall be included in // all copies or substantial portions of the Software. // // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. using System; using System.Collections.Generic; using ICSharpCode.NRefactory.Semantics; using ICSharpCode.NRefactory.TypeSystem; using ICSharpCode.NRefactory.PatternMatching; namespace ICSharpCode.NRefactory.CSharp.Refactoring { [IssueDescription ("CS1717:Assignment made to same variable", Description = "CS1717:Assignment made to same variable.", Category = IssueCategories.CompilerWarnings, Severity = Severity.Warning, IssueMarker = IssueMarker.GrayOut)] public class AssignmentMadeToSameVariableIssue : ICodeIssueProvider { public IEnumerable GetIssues (BaseRefactoringContext context) { return new GatherVisitor (context).GetIssues (); } class GatherVisitor : GatherVisitorBase { public GatherVisitor (BaseRefactoringContext ctx) : base (ctx) { } public override void VisitAssignmentExpression (AssignmentExpression assignmentExpression) { base.VisitAssignmentExpression (assignmentExpression); if (!(assignmentExpression.Left is IdentifierExpression) && !(assignmentExpression.Left is MemberReferenceExpression)) return; var resolveResult = ctx.Resolve (assignmentExpression.Left); var memberResolveResult = resolveResult as MemberResolveResult; if (memberResolveResult != null) { if (!(memberResolveResult.Member is IField)) return; if (!assignmentExpression.Left.Match (assignmentExpression.Right).Success) { // in case: this.field = field var memberResolveResult2 = ctx.Resolve (assignmentExpression.Right) as MemberResolveResult; if (memberResolveResult2 == null || memberResolveResult.Member != memberResolveResult2.Member) return; } } else if (resolveResult is LocalResolveResult) { if (!assignmentExpression.Left.Match (assignmentExpression.Right).Success) return; } else { return; } AstNode node; Action