ILSpy

9162 Commits

24 Branches

90 Tags

71 MiB

Tree: fc9d945e95

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	fc9d945e95	De-duplicate bookmark match/folding helpers; enabled glyph wins on a shared line - Extract MatchesBookmark for the token + assembly identity that tied a bookmark to a member; GetLineForBookmark and DocumentContainsBookmarkToken each spelled it out (four copies), so a change to the match rule had to be made everywhere. - Add a FoldingSection overload to FoldingsViewState.Restore and route the bookmark folding restore through it, dropping a duplicated checksum + match loop. - When two bookmarks resolve to the same gutter line, draw the enabled glyph so the line never reads as disabled while an active bookmark sits on it. - Drop an out-of-band reference in a test comment. Assisted-by: Claude:claude-opus-4-8:Claude Code	1 week ago
Christoph Wille	39d9020efd	Add a bookmarks feature for the decompiled C# view There was no way to mark and return to interesting spots in decompiled code. This adds a flat (no folders, no labels) bookmark list: toggle on a line from the context menu, the gutter, or Ctrl+B; see an icon in a new left-margin gutter that honours a disabled state; and manage the list in a dockable pane that auto-registers in the Window menu. Bookmarks anchor by metadata token, never by a raw line number, so they survive re-decompilation and decompiler-setting changes that reflow the C# text: a definition line anchors to its token, while a line inside a method body anchors to the method token plus an IL offset. Recovering an IL offset needs the decompiler's sequence points, which the normal C# output did not carry, so they are captured once at the WriteCode chokepoint and stored as a per-document line/offset map. The map is also what places gutter icons and scrolls navigation to the exact line. The list persists to an ILSpy.Bookmarks.json sidecar next to ILSpy.xml; the path logic is extracted into AppEnv/ConfigurationFiles so the dock layout sidecar shares it. Navigating to a bookmark loads its assembly from disk if it dropped out of the list (and only then offers to remove a bookmark whose file is gone), then centres the line and plays a brief line flash plus a gutter-icon pulse. Disabled bookmarks stay visible but are skipped by the next/previous actions. Assisted-by: Claude:claude-opus-4-8:Claude Code	1 week ago

Author

SHA1

Message

Date

Siegfried Pammer

fc9d945e95

De-duplicate bookmark match/folding helpers; enabled glyph wins on a shared line

- Extract MatchesBookmark for the token + assembly identity that tied a bookmark
  to a member; GetLineForBookmark and DocumentContainsBookmarkToken each spelled
  it out (four copies), so a change to the match rule had to be made everywhere.
- Add a FoldingSection overload to FoldingsViewState.Restore and route the
  bookmark folding restore through it, dropping a duplicated checksum + match loop.
- When two bookmarks resolve to the same gutter line, draw the enabled glyph so
  the line never reads as disabled while an active bookmark sits on it.
- Drop an out-of-band reference in a test comment.

Assisted-by: Claude:claude-opus-4-8:Claude Code

1 week ago

Christoph Wille

39d9020efd

Add a bookmarks feature for the decompiled C# view

There was no way to mark and return to interesting spots in decompiled
code. This adds a flat (no folders, no labels) bookmark list: toggle on a
line from the context menu, the gutter, or Ctrl+B; see an icon in a new
left-margin gutter that honours a disabled state; and manage the list in a
dockable pane that auto-registers in the Window menu.

Bookmarks anchor by metadata token, never by a raw line number, so they
survive re-decompilation and decompiler-setting changes that reflow the C#
text: a definition line anchors to its token, while a line inside a method
body anchors to the method token plus an IL offset. Recovering an IL offset
needs the decompiler's sequence points, which the normal C# output did not
carry, so they are captured once at the WriteCode chokepoint and stored as a
per-document line/offset map. The map is also what places gutter icons and
scrolls navigation to the exact line.

The list persists to an ILSpy.Bookmarks.json sidecar next to ILSpy.xml; the
path logic is extracted into AppEnv/ConfigurationFiles so the dock layout
sidecar shares it. Navigating to a bookmark loads its assembly from disk if
it dropped out of the list (and only then offers to remove a bookmark whose
file is gone), then centres the line and plays a brief line flash plus a
gutter-icon pulse. Disabled bookmarks stay visible but are skipped by the
next/previous actions.

Assisted-by: Claude:claude-opus-4-8:Claude Code

1 week ago

2 Commits (fc9d945e95d7adcb00bf82bd061b76829bd15fb5)