ILSpy

9736 Commits

54 Branches

94 Tags

91 MiB

Tree: fb9ff796da

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	3cc49044ec	Extend UseLambdaSyntax to emit statement lambdas Under UseLambdaSyntax, anonymous functions became lambdas only when an expression body was possible; statement-bodied ones kept C# 2 delegate syntax. Now every anonymous function whose parameter shape a lambda can express uses lambda syntax; delegate syntax remains for ref/out/in and params parameters and for pre-C# 3 language profiles. Two latent issues surfaced by the wider lambda coverage: DeclareVariables assumed an insertion point directly under a LambdaExpression is an expression body it must convert to a block, which block-bodied lambdas now violate; and anonymous methods declared without a parameter list carry compiler-generated parameter names like '<p0>' that are not valid identifiers, so the lambda's mandatory parameter list regenerates such names from the parameter type: (object obj, EventArgs e) => ... A side effect visible in fixtures: an explicit parameter list can make a delegate-creation cast redundant that bare 'delegate' syntax needed for overload resolution, e.g. new Thread((ThreadStart)delegate { }) becomes new Thread(() => { }). Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago
Jakob Hellermann	3c062bad0c	Fix anonymous-type lambda early-return emitting unresolvable cast (#3752 ) * Fix anonymous-type lambda early-return emitting unresolvable cast When a lambda's inferred return type contains an anonymous type and one branch returns null, the decompiler emitted an explicit cast such as `return (IEnumerable<<>f__AnonymousType0<int>>)null;`, which is invalid C#. Skip the cast in IsPossibleLossOfTypeInformation for null literals whenever the expected type contains an anonymous type: null is implicitly convertible to any reference type, so no cast is needed, and the anonymous type has no nameable form to cast to anyway. Fixes #3751	3 months ago

Author

SHA1

Message

Date

Siegfried Pammer

3cc49044ec

Extend UseLambdaSyntax to emit statement lambdas

Under UseLambdaSyntax, anonymous functions became lambdas only when an
expression body was possible; statement-bodied ones kept C# 2 delegate
syntax. Now every anonymous function whose parameter shape a lambda can
express uses lambda syntax; delegate syntax remains for ref/out/in and
params parameters and for pre-C# 3 language profiles.

Two latent issues surfaced by the wider lambda coverage: DeclareVariables
assumed an insertion point directly under a LambdaExpression is an
expression body it must convert to a block, which block-bodied lambdas
now violate; and anonymous methods declared without a parameter list
carry compiler-generated parameter names like '<p0>' that are not valid
identifiers, so the lambda's mandatory parameter list regenerates such
names from the parameter type: (object obj, EventArgs e) => ...
A side effect visible in fixtures: an explicit parameter list can make
a delegate-creation cast redundant that bare 'delegate' syntax needed
for overload resolution, e.g. new Thread((ThreadStart)delegate { })
becomes new Thread(() => { }).

Assisted-by: Claude:claude-fable-5:Claude Code

1 month ago

Jakob Hellermann

3c062bad0c

Fix anonymous-type lambda early-return emitting unresolvable cast (#3752 )

* Fix anonymous-type lambda early-return emitting unresolvable cast

When a lambda's inferred return type contains an anonymous type and one
branch returns null, the decompiler emitted an explicit cast such as
`return (IEnumerable<<>f__AnonymousType0<int>>)null;`, which is invalid C#.

Skip the cast in IsPossibleLossOfTypeInformation for null literals whenever
the expected type contains an anonymous type:
null is implicitly convertible to any reference type, so no cast is needed,
and the anonymous type has no nameable form to cast to anyway.

Fixes #3751

3 months ago

2 Commits (fb9ff796da30156c693f76a49f2b34f7f44aa108)