ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	716d7f6a5b	Fix #3803 : Crash on nested deconstruction of custom structs Optimized code stores no temporary for a deconstruction element that is used only once after the deconstruction. MatchAssignments handled that for trailing elements, but a nested deconstruction copies the inner element to a temporary, so the elements preceding it are also left without an assignment; their external load then violated the DeconstructInstruction invariant that all pattern variable loads are descendants of the instruction. The forwarding fixup now covers all unassigned elements and inserts in pattern order, because the statement and expression builders pair pattern variables with assignments positionally. This also fixes the nested tuple deconstruction crash reported in #3388. Also unwrap the address of the tested operand in VisitDeconstructInstruction: deconstructing a struct passes the receiver by reference, which was emitted as an invalid cast, 'var (x, y) = (S)(ref s);', even without nesting. Fixes #3388. Assisted-by: Claude:claude-fable-5:Claude Code	2 months ago
Siegfried Pammer	04505bbdf2	Highlight and scroll to the changed instruction in the ILAst view The C# debug-steps view highlights and centers the exact AST node a transform changed; the ILAst view already had the step tree and replay-at-step but produced no highlight. Bring it to parity. IL rendering has no token-writer seam like the C# output visitor, so per-instruction text spans are recorded by bracketing ILInstruction.WriteTo via a new INodeTrackingOutput. The dominant inst.ReplaceWith(newInst) transform pattern detaches the instruction passed to Step, so ILTransformContext gains EndStep to record the produced instruction; Stepper additionally records the position's ancestor chain as fallback candidates before the step-limit throw, so the "show state before" view -- which halts at the selected step -- still resolves to a surviving ancestor (ultimately the ILFunction). The highlight-range resolver is shared with the C# language. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	1 year ago
Siegfried Pammer	39992161b6	Fix #2692 : NRE in DeconstructionTransform.IsCompatibleImplicitConversion	4 years ago
Siegfried Pammer	5f73bfbb01	Fix Deconstruction for Deconstruct instance methods of value-types.	5 years ago
Siegfried Pammer	6bc0abc336	Fix #2378 : DeconstructionTransform produced invalid ILAst with some optimized deconstruction patterns.	5 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	a549b03bea	Implement ref local assignments	6 years ago
Siegfried Pammer	5afb7c82a6	support reference conversions	6 years ago
Siegfried Pammer	9eb0a98854	Fix NRE with tuple discards in DeconstructionTransform	6 years ago
Siegfried Pammer	7f4653c274	Add support for tuple deconstruction	6 years ago
Siegfried Pammer	442f6f90b7	Implement deconstruction discards	6 years ago
Siegfried Pammer	9cb3fe3484	Add support for basic deconstruction conversions	6 years ago
Siegfried Pammer	b435c07f4d	Added support for deconstruction assignments to properties	6 years ago
Siegfried Pammer	c9df069526	Add minimal test case + DecompilerSettings.Deconstruction setting	6 years ago
Siegfried Pammer	3f10294a72	Add DeconstructionTransform + implement DeconstructInstruction in ExpressionBuilder	6 years ago

16 Commits (e8346dc58c9ca206cb478ce2de5efd119d18bb11)