ILSpy

9713 Commits

54 Branches

94 Tags

91 MiB

Tree: e686819617

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	c6c6831200	Write item metadata the way a non-SDK project keeps it Metadata as attributes on an item element is MSBuild 15 syntax. The non-SDK project format is what an export falls back to for toolchains that predate the SDK, and those reject an unknown attribute on an item element, so a Page item carrying Generator and SubType as attributes undoes the reason to write that format at all. Every non-SDK project written by anything else keeps metadata in child elements. The SDK-style writer keeps attributes: there the syntax is a given and it is what the format's own tooling produces. Assisted-by: Claude:claude-opus-5:Claude Code	2 weeks ago
Siegfried Pammer	65092d8bd8	#3315 : List all decompiled project items in SDK-style projects The SDK-style writer only ever emitted EmbeddedResource items, so every other item type the export produced never reached the project file. XAML recovered from BAML lands in Page items: ILSpy wrote the .xaml files to disk and the project referenced none of them, leaving an exported WPF project that cannot rebuild. Explicit items collide with the SDK's own globs - a UseWPF project globs */.xaml into Page, and NETSDK1022 rejects the duplicate - so each include is preceded by a remove of the same item type, the pattern the EmbeddedResource path already uses. Setting EnableDefaultPageItems=false would work as well, but it is WPF-specific and switches off a glob for the whole project, whereas the remove is per item, applies to any item type, and keeps the SDK's item definitions (XamlRuntime) in effect. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago

Author

SHA1

Message

Date

Siegfried Pammer

c6c6831200

Write item metadata the way a non-SDK project keeps it

Metadata as attributes on an item element is MSBuild 15 syntax. The
non-SDK project format is what an export falls back to for toolchains
that predate the SDK, and those reject an unknown attribute on an item
element, so a Page item carrying Generator and SubType as attributes
undoes the reason to write that format at all. Every non-SDK project
written by anything else keeps metadata in child elements.

The SDK-style writer keeps attributes: there the syntax is a given and
it is what the format's own tooling produces.

Assisted-by: Claude:claude-opus-5:Claude Code

2 weeks ago

Siegfried Pammer

65092d8bd8

#3315 : List all decompiled project items in SDK-style projects

The SDK-style writer only ever emitted EmbeddedResource items, so every other
item type the export produced never reached the project file. XAML recovered
from BAML lands in Page items: ILSpy wrote the .xaml files to disk and the
project referenced none of them, leaving an exported WPF project that cannot
rebuild.

Explicit items collide with the SDK's own globs - a UseWPF project globs
**/*.xaml into Page, and NETSDK1022 rejects the duplicate - so each include is
preceded by a remove of the same item type, the pattern the EmbeddedResource
path already uses. Setting EnableDefaultPageItems=false would work as well, but
it is WPF-specific and switches off a glob for the whole project, whereas the
remove is per item, applies to any item type, and keeps the SDK's item
definitions (XamlRuntime) in effect.

Assisted-by: Claude:claude-opus-5[1m]:Claude Code

2 weeks ago

1 Commits (e68681961705131adb2bb54530f362c2fd183d25)