ILSpy

9457 Commits

54 Branches

94 Tags

91 MiB

Tree: e475e26443

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	e264e926bb	Enforce one child type per slot kind; de-alias shared kinds A slot kind names one child position, so the generator emits a single typed Slots.X constant for it. A kind used with two different child types had to widen that constant to AstNode, and the typed GetChildren<T> accessor then cast the live AstNodeCollection<Concrete> to AstNodeCollection<AstNode> -- an InvalidCastException waiting for the first caller (latent today, but the model permitted it). Make the loose state unrepresentable instead of guarding it at runtime: DSTG001 errors when a [Slot] kind is declared with more than one child type. The six kinds that only coincidentally shared a name (Body, True, False, Initializer, SwitchSection, Variable) are split into precisely typed kinds; a genuinely either/or position (a lambda body) stays one declared type, AstNode. Every Slots.X now carries its real element type, so the GetChildren cast can no longer fail. Output is unchanged: the Pretty suite stays byte-identical with CheckInvariant green in DEBUG. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Siegfried Pammer	cfc2872532	Document the AST source generator and how to extend it A contributor guide next to the node classes: the [DecompilerAstNode]/[Slot]/ [ExcludeFromMatch] attributes, the slot-and-kind model (per-node CSharpSlotInfo vs the canonical Slots constants), scalars and generated constructors, CheckInvariant, and a step-by-step for adding a node. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago

Author

SHA1

Message

Date

Siegfried Pammer

e264e926bb

Enforce one child type per slot kind; de-alias shared kinds

A slot kind names one child position, so the generator emits a single
typed Slots.X constant for it. A kind used with two different child types
had to widen that constant to AstNode, and the typed GetChildren<T>
accessor then cast the live AstNodeCollection<Concrete> to
AstNodeCollection<AstNode> -- an InvalidCastException waiting for the
first caller (latent today, but the model permitted it).

Make the loose state unrepresentable instead of guarding it at runtime:
DSTG001 errors when a [Slot] kind is declared with more than one child
type. The six kinds that only coincidentally shared a name (Body, True,
False, Initializer, SwitchSection, Variable) are split into precisely
typed kinds; a genuinely either/or position (a lambda body) stays one
declared type, AstNode. Every Slots.X now carries its real element type,
so the GetChildren cast can no longer fail.

Output is unchanged: the Pretty suite stays byte-identical with
CheckInvariant green in DEBUG.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

Siegfried Pammer

cfc2872532

Document the AST source generator and how to extend it

A contributor guide next to the node classes: the [DecompilerAstNode]/[Slot]/
[ExcludeFromMatch] attributes, the slot-and-kind model (per-node CSharpSlotInfo
vs the canonical Slots constants), scalars and generated constructors,
CheckInvariant, and a step-by-step for adding a node.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

2 Commits (e475e264432981fe56b649cea32b8564a09db6b3)