ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	e0aee1baa5	Fix #3714 : declare a local function in its innermost capture scope A local function nested in a lambda can capture closures at two depths: csc emits it as an instance method on the enclosing method's display class that takes the lambda's display class as a parameter. Combining those two capture scopes with FindCommonAncestorInstruction picked the enclosing method, moving the function out of the lambda that owns the deeper closure; the variables captured there were then unreachable and the display-class parameter survived into the output as an undeclared identifier. Nested capture scopes resolve to the innermost instead, which a local function can always see - it reaches the outer closure through the display class it is declared on. Assisted-by: Claude:claude-fable-5:Claude Code	2 weeks ago
Christoph Wille	fe9f6db3ee	Emit C# 7.1 default literals where the context supplies the type Shortening default(T) is the same problem as removing the redundant cast around a lambda whose delegate type the context already fixes, so it uses the same mechanism: ConvertTo makes the explicit type implicit when the conversion is an identity conversion and the caller allows an implicit one. The literal keeps the type it was shortened from, so any later conversion to a different type - or any context that requires an explicit type, such as an overload resolution recheck falling back to CastArguments - can spell default(T) out again. That keeps the value intact where the bare literal would change it, e.g. "object o = default(SomeStruct)", which boxes a non-null struct while "default" would be null. Because the shortened literal resolves to DefaultLiteralResolveResult, CallBuilder's existing overload resolution recheck sees a real default literal and rejects ambiguous calls on its own; no separate bookkeeping about which arguments may stay untyped is needed. Only the contexts that supply no target type at all restore the explicit form: an awaited expression, and arguments of operator methods, which later become operator or cast syntax rather than calls. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	4 weeks ago
Siegfried Pammer	3cc49044ec	Extend UseLambdaSyntax to emit statement lambdas Under UseLambdaSyntax, anonymous functions became lambdas only when an expression body was possible; statement-bodied ones kept C# 2 delegate syntax. Now every anonymous function whose parameter shape a lambda can express uses lambda syntax; delegate syntax remains for ref/out/in and params parameters and for pre-C# 3 language profiles. Two latent issues surfaced by the wider lambda coverage: DeclareVariables assumed an insertion point directly under a LambdaExpression is an expression body it must convert to a block, which block-bodied lambdas now violate; and anonymous methods declared without a parameter list carry compiler-generated parameter names like '<p0>' that are not valid identifiers, so the lambda's mandatory parameter list regenerates such names from the parameter type: (object obj, EventArgs e) => ... A side effect visible in fixtures: an explicit parameter list can make a delegate-creation cast redundant that bare 'delegate' syntax needed for overload resolution, e.g. new Thread((ThreadStart)delegate { }) becomes new Thread(() => { }). Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago
Siegfried Pammer	e54e844871	Add pretty tests for async local functions The fixture had an iterator local function but no async local function; the async state-machine-in-local-function shape, static and capturing, was not covered. Assisted-by: Claude:claude-fable-5:Claude Code	2 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	1 year ago
Siegfried Pammer	7d0262d779	Fix #3439 : Regressed decompilation of variables in lambda scope	1 year ago
Siegfried Pammer	349a89c1fa	Fix #3436 : Duplicate naming of local functions	1 year ago
Siegfried Pammer	2ca5b5affe	Rewrite AssignVariableNames algorithm to use variable usages instead of the list of variables.	2 years ago
Daniel Grunwald	efeaf1356f	Add feature: C#11 nint without NativeIntegerAttribute Because it is no longer possible to distinguish IntPtr from nint, this required a lot of testcase adjustment.	3 years ago
Daniel Grunwald	281586de1f	`#enable nullable` for a couple of files. Includes some fixes for potential NullReferenceExceptions.	6 years ago
Siegfried Pammer	d3b0e4cd72	Fix #2196 : Add support for extern local functions.	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	1a3e70b60a	Fix warnings in test cases	6 years ago
Siegfried Pammer	33bc9fbef4	Fix display of generic type parameters of local functions in tooltips	6 years ago
Siegfried Pammer	a231ab54d4	Add test cases	6 years ago
Siegfried Pammer	358d677084	#1798 : Add more unit tests	6 years ago
SilverFox	a5d85fea3f	Add an workaround for #1798	7 years ago
SilverFox	14cd09d7bc	Update some tests, and add some limited descributed in PR to tests(disabled)	7 years ago
SilverFox	22daaa3572	Enable static local functions and update related tests, since roslyn 3.4.0-beta3 is available for tests	7 years ago
SilverFox	906efc3d94	Disabled tests `LocalFunctions.NestedCapture2`	7 years ago
SilverFox	33f96fd888	Fix tests `LocalFunctions.NestedCapture1`	7 years ago
SilverFox	b8f00cf983	Add some new tests for local func	7 years ago
SilverFox	d88c73f59d	Add test for generic local function	7 years ago
Siegfried Pammer	7c8458dfa3	Refactor TransformDisplayClassUsage	7 years ago
Siegfried Pammer	0ca5ace524	#1349 : Fix assertions triggered by incorrect local function decompilation.	7 years ago
Siegfried Pammer	c51aea3601	Fix decompilation of yield return in local functions.	7 years ago
Siegfried Pammer	a109b77858	Refactor LocalFunctionDecompiler to allow mutually recursive local functions to be decompiled correctly.	7 years ago
Siegfried Pammer	763ea38644	Clean up CallBuilder.HandleDelegateConstruction	7 years ago
Siegfried Pammer	37e14f43e3	Refactor/Clean up local functions representation in type system.	7 years ago
Siegfried Pammer	bb066dbd04	Additional test (deactivated)	7 years ago
Siegfried Pammer	01e42b772c	Fix local functions inside lambdas.	7 years ago
Siegfried Pammer	b83cb41f2e	Add pretty tests for local functions.	7 years ago

32 Commits (e0aee1baa5509c62849fc2ae14bab27bcd99daad)