ILSpy

9697 Commits

54 Branches

94 Tags

91 MiB

Tree: d8dfbec04b

Commit Graph

Author	SHA1	Message	Date
Sebastien Lebreton	b0e446618f	Fix #3850 : recover ReadOnlySpan<T> array literals from the legacy lazy cache Roslyn caches a ReadOnlySpan<T> created from an array literal in a <PrivateImplementationDetails> field on target frameworks without RuntimeHelpers.CreateSpan (e.g. .NET Framework / netstandard2.0 + System.Memory): object obj = <PrivateImplementationDetails>.cache; if (obj == null) { obj = new char[] { '\r', '\n' }; <PrivateImplementationDetails>.cache = (char[])obj; } ... new ReadOnlySpan<char>((char[])obj) ... The decompiled output referenced the compiler-synthesized <PrivateImplementationDetails> type, whose escaped name is not expressible in C# and is never declared, so the output failed to recompile (CS0400). The modern RuntimeHelpers.CreateSpan form was already handled (TransformRuntimeHelpersCreateSpanInitialization); this adds the analogous handling for the legacy lazy-cache form, mirroring CachedDelegateInitialization (which collapses the same lazy-static-field cache for anonymous-method delegates). Once the cache is collapsed, the existing array-initializer transforms recover the array literal, so the <PrivateImplementationDetails> reference disappears. Test: ILPretty/CachedReadOnlySpanInitialization.	2 months ago

Author

SHA1

Message

Date

Sebastien Lebreton

b0e446618f

Fix #3850 : recover ReadOnlySpan<T> array literals from the legacy lazy cache

Roslyn caches a ReadOnlySpan<T> created from an array literal in a
<PrivateImplementationDetails> field on target frameworks without
RuntimeHelpers.CreateSpan (e.g. .NET Framework / netstandard2.0 + System.Memory):

    object obj = <PrivateImplementationDetails>.cache;
    if (obj == null) {
        obj = new char[] { '\r', '\n' };
        <PrivateImplementationDetails>.cache = (char[])obj;
    }
    ... new ReadOnlySpan<char>((char[])obj) ...

The decompiled output referenced the compiler-synthesized
<PrivateImplementationDetails> type, whose escaped name is not expressible in C#
and is never declared, so the output failed to recompile (CS0400).

The modern RuntimeHelpers.CreateSpan form was already handled
(TransformRuntimeHelpersCreateSpanInitialization); this adds the analogous
handling for the legacy lazy-cache form, mirroring CachedDelegateInitialization
(which collapses the same lazy-static-field cache for anonymous-method delegates).
Once the cache is collapsed, the existing array-initializer transforms recover
the array literal, so the <PrivateImplementationDetails> reference disappears.

Test: ILPretty/CachedReadOnlySpanInitialization.

2 months ago

1 Commits (d8dfbec04b82b034dab8410ec2fbc4d154915a4d)