ILSpy

9631 Commits

54 Branches

94 Tags

91 MiB

Tree: cd212ea05f

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	cd212ea05f	Pass the compilation to ILInstruction.CheckInvariant Invariants that involve types (stack type of a variable against its IType, the element type of an array access, the operand types of a comparison) need a type system to resolve them against, and the only correct one is the type system the instruction tree was decoded with. Until now CheckInvariant took only the phase, so such a check had no compilation to use: DeconstructInstruction.CheckInvariant called IsAssignment with a null type system, which only held up because the targets it sees are ldloc, whose InferType never touches the compilation; a ldflda-wrapped or pointer target would have failed inside the invariant instead of reporting a violation. Every call site already has that type system in scope: the ILReader's compilation, the ILTransformContext of the running transform, or the decompiler's own IDecompilerTypeSystem. It is now passed explicitly and the base implementation asserts it is present, so a future invariant can rely on it without re-plumbing the callers. Assisted-by: Claude:claude-fable-5:Claude Code	2 weeks ago
Christoph Wille	3ab2a2b0cb	Add decompiler architecture document (LLM-generated, human-reviewed) (#3870 ) * Add decompiler architecture document * Add StatementBuilder section to architecture doc, fix foreach story * Correct architecture doc per review by the decompiler author	2 months ago

Author

SHA1

Message

Date

Siegfried Pammer

cd212ea05f

Pass the compilation to ILInstruction.CheckInvariant

Invariants that involve types (stack type of a variable against its IType,
the element type of an array access, the operand types of a comparison)
need a type system to resolve them against, and the only correct one is the
type system the instruction tree was decoded with. Until now CheckInvariant
took only the phase, so such a check had no compilation to use:
DeconstructInstruction.CheckInvariant called IsAssignment with a null type
system, which only held up because the targets it sees are ldloc, whose
InferType never touches the compilation; a ldflda-wrapped or pointer target
would have failed inside the invariant instead of reporting a violation.

Every call site already has that type system in scope: the ILReader's
compilation, the ILTransformContext of the running transform, or the
decompiler's own IDecompilerTypeSystem. It is now passed explicitly and the
base implementation asserts it is present, so a future invariant can rely
on it without re-plumbing the callers.

Assisted-by: Claude:claude-fable-5:Claude Code

2 weeks ago

Christoph Wille

3ab2a2b0cb

Add decompiler architecture document (LLM-generated, human-reviewed) (#3870 )

* Add decompiler architecture document
* Add StatementBuilder section to architecture doc, fix foreach story
* Correct architecture doc per review by the decompiler author

2 months ago

2 Commits (cd212ea05f60ec687501a7906b1f4f1678673b1e)