ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	cd212ea05f	Pass the compilation to ILInstruction.CheckInvariant Invariants that involve types (stack type of a variable against its IType, the element type of an array access, the operand types of a comparison) need a type system to resolve them against, and the only correct one is the type system the instruction tree was decoded with. Until now CheckInvariant took only the phase, so such a check had no compilation to use: DeconstructInstruction.CheckInvariant called IsAssignment with a null type system, which only held up because the targets it sees are ldloc, whose InferType never touches the compilation; a ldflda-wrapped or pointer target would have failed inside the invariant instead of reporting a violation. Every call site already has that type system in scope: the ILReader's compilation, the ILTransformContext of the running transform, or the decompiler's own IDecompilerTypeSystem. It is now passed explicitly and the base implementation asserts it is present, so a future invariant can rely on it without re-plumbing the callers. Assisted-by: Claude:claude-fable-5:Claude Code	2 weeks ago
Siegfried Pammer	468e3da92c	Bracket ILAst WriteTo in one place via WriteToCore The debug-step node bracket (MarkNodeStart/try/finally/MarkNodeEnd) was copied into every hand-written WriteTo override and re-emitted by the T4 generator, so a newly added instruction could silently omit it and lose step highlighting with no compile error or test failure. Seal WriteTo on ILInstruction to apply the bracket once and delegate to a new abstract WriteToCore; move every override (hand-written and generated) to WriteToCore without the wrapper. Rendered output is unchanged -- the marks are no-ops unless the output tracks nodes. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Siegfried Pammer	04505bbdf2	Highlight and scroll to the changed instruction in the ILAst view The C# debug-steps view highlights and centers the exact AST node a transform changed; the ILAst view already had the step tree and replay-at-step but produced no highlight. Bring it to parity. IL rendering has no token-writer seam like the C# output visitor, so per-instruction text spans are recorded by bracketing ILInstruction.WriteTo via a new INodeTrackingOutput. The dominant inst.ReplaceWith(newInst) transform pattern detaches the instruction passed to Step, so ILTransformContext gains EndStep to record the produced instruction; Stepper additionally records the position's ancestor chain as fallback candidates before the step-limit throw, so the "show state before" view -- which halts at the selected step -- still resolves to a surviving ancestor (ultimately the ILFunction). The highlight-range resolver is shared with the C# language. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	1 year ago
Daniel Grunwald	5fb2f7a22f	#nullable enable for ILAst (except for generated code)	5 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	c1fca21e8a	Make ILRange field private - introduce public API for IL range manipulation.	8 years ago
Siegfried Pammer	bbe16584f7	Fix #1150 : - Allow unknown type in BinaryNumericInstruction - Make conversions explicit: I+I8=I8, I4+I8=I8, F4+F8=F8	8 years ago
Daniel Grunwald	75a627d40b	Don't use compound assignment when the RHS value does not fit into the LHS type.	8 years ago
Daniel Grunwald	568b3e2d91	Fix DetectPinnedRegions introducing stack type inconsistencies.	9 years ago
Siegfried Pammer	5fec6bd7f7	Implement Interval.WriteTo extension method on ILAst	9 years ago
Daniel Grunwald	61900e33c3	[nullables] Lifted compound assignments	9 years ago
Daniel Grunwald	66d1b744c3	Add ILAstWritingOptions parameter to ILInstruction.WriteTo().	9 years ago
Daniel Grunwald	21ef967d4d	[nullables] Lifting for non-equality comparisons.	9 years ago
Daniel Grunwald	33099c5d65	[nullables] Extend nullable lifting to arbitrary combinations of 'conv' and 'binary.numeric'.	9 years ago
Daniel Grunwald	e266c634de	[nullables] Add support for lifted binary operators where one of the inputs is nullable.	9 years ago
Siegfried Pammer	840ec04fde	Namespace adjustments for Syntax classes	10 years ago
Christoph Wille	1ce8349dd9	Adjust namespaces	10 years ago
Daniel Grunwald	421ad617f8	Fix MayThrow flag on BinaryNumericInstruction	10 years ago
Siegfried Pammer	ae75c57e22	Basic implementation of CompoundAssignmentInstruction	10 years ago
Siegfried Pammer	3a89500e0c	Merge binary arithmetic instructions into one class.	10 years ago
Siegfried Pammer	8766783eb6	Remove ld(s)fld/st(s)fld	10 years ago
Daniel Grunwald	55d953b889	Remove CompoundAssignmentType from BinaryNumericInstruction: Compound assignments were not supported by any user of the ILAst. In particular, they are problematic because they are yet another way to store to a local variable (making reaching definitions complex). They also didn't update the StoreCount correctly when inst.Left or inst.Left.Variable was changed. Since they weren't used (yet), just remove them. Hopefully we'll find a better representation once we need compound assignments.	10 years ago
Daniel Grunwald	ae318eca02	Make implicit I4->I conversions explicit in ILAst.	10 years ago
Daniel Grunwald	c171dbd520	Add class VariableScope.	10 years ago
Siegfried Pammer	7fdb7765c8	fix copy-paste error in PeekOrDefault extension	11 years ago
Siegfried Pammer	abc29ef52f	determine proper ResultType of Shl/Shr	11 years ago
Daniel Grunwald	ea0eaf9623	Add CompoundAssignment mode to BinaryNumericInstruction	12 years ago
Daniel Grunwald	3d47e1028e	Instead of OverflowMode, use bool checkForOverflow + Sign	12 years ago
Daniel Grunwald	42bfff077d	Finish the move to the new generated ILAst classes	12 years ago
Daniel Grunwald	49ce1bcea3	Worked on ILAst instruction representation	12 years ago

31 Commits (cd212ea05f60ec687501a7906b1f4f1678673b1e)