ILSpy

9229 Commits

24 Branches

90 Tags

71 MiB

Tree: c79aefb325

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	c5f8834e57	Stop the assembly list from disposing removed assemblies Unload / Clear / ReloadAssembly / HotReplaceAssembly all called LoadedAssembly.Dispose() on the assembly they removed, which disposes its MetadataFile and unmaps the underlying file. But open document tabs and tree nodes can still hold that MetadataFile, and the list has no safe point at which to know those references are gone -- so disposing risked unmapping a file out from under a live reader (use-after-dispose). Drop the removed assembly and let the GC reclaim it once nothing references it instead. The DockWorkspace cancel-on-remove is now a courtesy, not a guard against an unmap race.	4 weeks ago

Author

SHA1

Message

Date

Siegfried Pammer

c5f8834e57

Stop the assembly list from disposing removed assemblies

Unload / Clear / ReloadAssembly / HotReplaceAssembly all called LoadedAssembly.Dispose() on the assembly they removed, which disposes its MetadataFile and unmaps the underlying file. But open document tabs and tree nodes can still hold that MetadataFile, and the list has no safe point at which to know those references are gone -- so disposing risked unmapping a file out from under a live reader (use-after-dispose). Drop the removed assembly and let the GC reclaim it once nothing references it instead. The DockWorkspace cancel-on-remove is now a courtesy, not a guard against an unmap race.

4 weeks ago

1 Commits (c79aefb325c6ee9dd4ac347a576c637fdc8461a6)