ILSpy

8827 Commits

24 Branches

90 Tags

71 MiB

Tree: bca2098448

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	91133c1272	Keep the tree selection put when right-clicking a node Right-clicking a tree row to reach its context menu used to move the real selection there first, because ProDataGrid selects the row on press. With the preview document bound to the selection, that meant 'Decompile to new tab' on node B (while viewing A) jumped the preview to B before the command ran, so you ended up with B twice instead of the intended A + B. Middle-click avoided it, but not every mouse has a usable one. Capture the right-clicked row in ContextRequested (which fires even when a previous menu's light-dismiss popup swallows the press) and swallow the right-press so the grid never reselects: the menu now acts on the clicked row as a Thunderbird-style context target while the selection -- and the document -- stay put. The targeted row gets a faint focus-box highlight, cleared when the menu closes (guarded so a stale menu's close can't wipe a newer target). Also adds TestHarness.ClickItem to collapse the repeated Items.OfType<MenuItem>().Single(...).RaiseEvent(...) menu-click dance. Assisted-by: Claude:claude-opus-4-8:Claude Code	4 weeks ago
Siegfried Pammer	f466b2399b	Add per-step visual breakpoints to the headless UI tests To audit what each UI test actually exercises, every step now snapshots the live window to <TestFixtureName>/<TestName>_<NN>_<ShortDescription>.png: a booted frame (emitted automatically by TestHarness.BootAsync), one after each state-changing action, and one before each assertion. Flip ILSPY_TESTS_VISIBLE=1 to render the filmstrip; it lands under %TEMP%/ilspy-test-captures (overridable via ILSPY_TEST_CAPTURES). The step number and fixture/test name are derived automatically so inserting a breakpoint never renumbers the rest. The identity is recorded up front from the real ITest in an ITestAction hook rather than read live: NUnit's TestContext.CurrentContext does not flow onto async continuations, so a capture after an await would otherwise collide under the ad-hoc context. And when rendering is off the whole call is a true no-op -- not even a dispatcher pump -- so instrumenting a test can never perturb the navigation/tab timing it asserts on. Full headless suite stays green.	4 weeks ago
Siegfried Pammer	56afcf8abd	Factor repeated headless-test setup into shared helpers Nearly every headless UI test opened with the same four-line prologue (resolve the shared MainWindow, show it, cast its DataContext, wait for the assembly list), then repeated the corelib lookup, the EnsureLazyChildren + Children.OfType<T>().Single() drill, the registry single-by-header lookups, and the open-an-assembly-and-wait dance. The duplication made the intent of each test hard to see and every signature tweak a suite-wide edit. Collapse those into TestHarness (BootAsync, OpenAssemblyAsync, GetCommand, GetEntry) and TreeNavigation extensions (FindCoreLib, GetChild<T>, Expand<T>), then apply them across the suite. Net ~865 lines of boilerplate removed with no change in behaviour; the full headless suite stays green.	4 weeks ago

Author

SHA1

Message

Date

Siegfried Pammer

91133c1272

Keep the tree selection put when right-clicking a node

Right-clicking a tree row to reach its context menu used to move the real
selection there first, because ProDataGrid selects the row on press. With the
preview document bound to the selection, that meant 'Decompile to new tab' on
node B (while viewing A) jumped the preview to B before the command ran, so you
ended up with B twice instead of the intended A + B. Middle-click avoided it,
but not every mouse has a usable one.

Capture the right-clicked row in ContextRequested (which fires even when a
previous menu's light-dismiss popup swallows the press) and swallow the
right-press so the grid never reselects: the menu now acts on the clicked row
as a Thunderbird-style context target while the selection -- and the document
-- stay put. The targeted row gets a faint focus-box highlight, cleared when
the menu closes (guarded so a stale menu's close can't wipe a newer target).

Also adds TestHarness.ClickItem to collapse the repeated
Items.OfType<MenuItem>().Single(...).RaiseEvent(...) menu-click dance.

Assisted-by: Claude:claude-opus-4-8:Claude Code

4 weeks ago

Siegfried Pammer

f466b2399b

Add per-step visual breakpoints to the headless UI tests

To audit what each UI test actually exercises, every step now snapshots the
live window to <TestFixtureName>/<TestName>_<NN>_<ShortDescription>.png: a
booted frame (emitted automatically by TestHarness.BootAsync), one after each
state-changing action, and one before each assertion. Flip ILSPY_TESTS_VISIBLE=1
to render the filmstrip; it lands under %TEMP%/ilspy-test-captures (overridable
via ILSPY_TEST_CAPTURES).

The step number and fixture/test name are derived automatically so inserting a
breakpoint never renumbers the rest. The identity is recorded up front from the
real ITest in an ITestAction hook rather than read live: NUnit's
TestContext.CurrentContext does not flow onto async continuations, so a capture
after an await would otherwise collide under the ad-hoc context. And when
rendering is off the whole call is a true no-op -- not even a dispatcher pump --
so instrumenting a test can never perturb the navigation/tab timing it asserts
on. Full headless suite stays green.

4 weeks ago

Siegfried Pammer

56afcf8abd

Factor repeated headless-test setup into shared helpers

Nearly every headless UI test opened with the same four-line prologue
(resolve the shared MainWindow, show it, cast its DataContext, wait for the
assembly list), then repeated the corelib lookup, the EnsureLazyChildren +
Children.OfType<T>().Single() drill, the registry single-by-header lookups,
and the open-an-assembly-and-wait dance. The duplication made the intent of
each test hard to see and every signature tweak a suite-wide edit.

Collapse those into TestHarness (BootAsync, OpenAssemblyAsync, GetCommand,
GetEntry) and TreeNavigation extensions (FindCoreLib, GetChild<T>, Expand<T>),
then apply them across the suite. Net ~865 lines of boilerplate removed with
no change in behaviour; the full headless suite stays green.

4 weeks ago

3 Commits (bca209844827c5f6edfbb5fe94de758fe6aa2b5c)