ILSpy

8827 Commits

54 Branches

94 Tags

91 MiB

Tree: bca2098448

Commit Graph

Author	SHA1	Message	Date
Daniel Grunwald	f826037acc	Protect IsInst against multi-step inlining -- we can only allow `Box` as the top-level argument, not anywhere within the argument tree.	1 year ago
Daniel Grunwald	dd4bf7d8a4	Fix #3518 by replacing `FixLoneIsInst` with an inlining restriction. This way we avoid having to extract later, as we will never inline if the `isinst` argument if this could result in it being unrepresentable in C#. This commit also refactors inlining restrictions to avoid requiring special cases in ILInlining itself. But when making this change, I discovered that this broke our pattern-matching tests, and that the weird IL with double `isinst` is indeed generated by the C# compiler for `if (genericParam is StringComparison.Ordinal)` style code. So instead we also allow `isinst` with a `box(expr-without-side-effects)` argument to be represented with the `expr is T ? (T)expr : null` emulation.	1 year ago

Author

SHA1

Message

Date

Daniel Grunwald

f826037acc

Protect IsInst against multi-step inlining -- we can only allow `Box` as the top-level argument, not anywhere within the argument tree.

1 year ago

Daniel Grunwald

dd4bf7d8a4

Fix #3518 by replacing `FixLoneIsInst` with an inlining restriction.

This way we avoid having to extract later, as we will never inline if the `isinst` argument if this could result in it being unrepresentable in C#.
This commit also refactors inlining restrictions to avoid requiring special cases in ILInlining itself.

But when making this change, I discovered that this broke our pattern-matching tests, and that the weird IL with double `isinst` is indeed generated by the C# compiler for `if (genericParam is StringComparison.Ordinal)` style code. So instead we also allow `isinst` with a `box(expr-without-side-effects)` argument to be represented with the `expr is T ? (T)expr : null` emulation.

1 year ago

2 Commits (bca209844827c5f6edfbb5fe94de758fe6aa2b5c)