pimhwang/ILSpy - ILSpy - git.quantfans.net

Author	SHA1	Message	Date
Siegfried Pammer	0b7fa142d7	#3315 : Gate implicit references the way the SDK gates them The exporter dropped PresentationFramework, System.Xaml, System.Windows.Forms and System.Drawing from every project it wrote, whatever the assembly used, while a second list held the remaining WPF assemblies behind a WPF check. The SDK draws the line elsewhere: Microsoft.NET.Sdk.WindowsDesktop.props promotes the nine _WpfCommonNetFxReference items to _SDKImplicitReference only when UseWPF is set, System.Windows.Forms only when UseWindowsForms is, and WindowsFormsIntegration only when both are. A XAML-only assembly therefore lost a reference that nothing supplied, and a WPF application that also used Windows Forms lost the Windows Forms references while the project only said UseWPF. Following the SDK there makes WPF and Windows Forms independent rather than alternatives, which is what the flags enum is for: an assembly can use both, and then both properties have to be written. Where an assembly looks like more than one kind of project, the web SDK wins the Sdk attribute, because Microsoft.NET.Sdk.Web imports Microsoft.NET.Sdk and so carries the desktop targets, while Microsoft.NET.Sdk.WindowsDesktop carries no web targets. System.Drawing stays unconditional: Microsoft.NET.Sdk.BeforeCommon.targets adds it for every .NETFramework target rather than only for Windows Forms ones, and on .NET Core it ships in the Microsoft.NETCore.App reference pack. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago
Siegfried Pammer	d93bbcdb73	#3315 : Drop references that UseWPF already supplies An exported WPF project listed PresentationCore next to the implicit Windows Desktop framework reference, which is a duplicate reference (MSB3243) or an unresolvable one (MSB3245) once the hint path stops pointing anywhere. The target-pack filter that should have caught it asks the assembly resolver, which answers by probing the shared frameworks installed on the machine running the export - so the same assembly exported from Linux, or from a Windows box without the desktop runtime, produced a different project file. What the SDK adds for UseWPF is a fixed list, so match it by name instead. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago
Siegfried Pammer	2900d18bca	#3315 : Ask for the WindowsDesktop SDK only where it is still needed Microsoft.NET.Sdk imports the Windows Desktop targets itself for .NET Framework and for .NET 5 and later, and warns (NETSDK1137) about every project that still names the separate SDK. Only .NET Core 3.x, where those targets are not imported without a platform-suffixed moniker, genuinely needs Microsoft.NET.Sdk.WindowsDesktop. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago
Siegfried Pammer	fe8477e943	#3315 : Keep the target platform in exported target framework monikers A .NET 5 or later project that sets UseWPF or UseWindowsForms is rejected outright (NETSDK1136) unless its target framework names the Windows platform, so an exported WPF assembly produced a project that could not build at all. The platform belongs to the assembly rather than to WPF - TargetPlatformAttribute records it, SupportedOSPlatform its minimum version - so the moniker follows the attributes wherever they are present, and falls back to plain "windows" only for a desktop project built before those attributes existed. Monikers older than net5.0 take no platform suffix and must not grow one. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago
Siegfried Pammer	1534a051fe	#2253 : Export the WPF application definition as such, not as a Page The WPF markup compiler generates the program entry point from the ApplicationDefinition item, so an exported project that lists App.xaml as a Page has no Main at all and fails to build with CS5001. Both the UI and ilspycmd already resolve the BAML root's partial class, which makes deriving Application from System.Windows.Application the natural signal. The module additionally has to have an entry point of its own: a library that merely contains an Application subclass would otherwise have MSBuild generate a Main into it. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	2 weeks ago