ILSpy

9475 Commits

54 Branches

94 Tags

91 MiB

Tree: a4ef71bb76

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	590793fd21	Document the two roles of the language version in the settings API The language version appears in two places that share a name but not a concept, which repeatedly reads as one confused API: on DecompilerSettings it is a construction shortcut (SetLanguageVersion initializes the feature flags once and the version is not stored, so the flags are the only state and the call is deliberately one-way), while on WholeProjectDecompiler it is an export parameter (the LangVersion stamped into the project file, defaulting to GetMinimumRequiredVersion() and rejected below it as a safety net against exporting uncompilable projects). Spell both roles out in the XML docs so the distinction no longer has to be reverse-engineered. Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago
Siegfried Pammer	401530b86d	Let ExtensionMethods, UseLambdaSyntax and UseEnhancedUsing raise the minimum version These three settings were disabled by SetLanguageVersion for older targets but, unlike every comparable syntax-preference setting, never raised GetMinimumRequiredVersion while enabled - an omission that had gone unnoticed in the handwritten version bookkeeping. Drop the AffectsMinimumRequiredVersion escape hatch that reproduced it. Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago
Siegfried Pammer	b75ea27800	Generate DecompilerSettings boilerplate from [DecompilerSetting] attributes Every version-gated setting was bookkept in four places that had to stay in sync by hand: the property boilerplate, SetLanguageVersion, GetMinimumRequiredVersion, and the [Category] display string - and that sync had already drifted in a handful of settings. A new source generator in ICSharpCode.Decompiler.Generators now derives all four from a single [DecompilerSetting] attribute on a partial property: backing field, accessors with change notification, the version-derived [Category], and both version methods. [Description] stays handwritten because its resource keys are irregular and are grepped from the resx. This commit is a 1:1 translation: the current inconsistencies are reproduced exactly (AffectsMinimumRequiredVersion = false on ExtensionMethods, UseLambdaSyntax and UseEnhancedUsing; no gate on SwitchOnReadOnlySpanChar), verified against the old build by comparing SetLanguageVersion and GetMinimumRequiredVersion behavior for every setting at every language version, plus a reflection diff of the full per-property attribute surface. Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago

Author

SHA1

Message

Date

Siegfried Pammer

590793fd21

Document the two roles of the language version in the settings API

The language version appears in two places that share a name but not a
concept, which repeatedly reads as one confused API: on
DecompilerSettings it is a construction shortcut (SetLanguageVersion
initializes the feature flags once and the version is not stored, so
the flags are the only state and the call is deliberately one-way),
while on WholeProjectDecompiler it is an export parameter (the
LangVersion stamped into the project file, defaulting to
GetMinimumRequiredVersion() and rejected below it as a safety net
against exporting uncompilable projects). Spell both roles out in the
XML docs so the distinction no longer has to be reverse-engineered.

Assisted-by: Claude:claude-fable-5:Claude Code

1 month ago

Siegfried Pammer

401530b86d

Let ExtensionMethods, UseLambdaSyntax and UseEnhancedUsing raise the minimum version

These three settings were disabled by SetLanguageVersion for older
targets but, unlike every comparable syntax-preference setting, never
raised GetMinimumRequiredVersion while enabled - an omission that had
gone unnoticed in the handwritten version bookkeeping. Drop the
AffectsMinimumRequiredVersion escape hatch that reproduced it.

Assisted-by: Claude:claude-fable-5:Claude Code

1 month ago

Siegfried Pammer

b75ea27800

Generate DecompilerSettings boilerplate from [DecompilerSetting] attributes

Every version-gated setting was bookkept in four places that had to stay
in sync by hand: the property boilerplate, SetLanguageVersion,
GetMinimumRequiredVersion, and the [Category] display string - and that
sync had already drifted in a handful of settings. A new source
generator in ICSharpCode.Decompiler.Generators now derives all four
from a single [DecompilerSetting] attribute on a partial property:
backing field, accessors with change notification, the version-derived
[Category], and both version methods. [Description] stays handwritten
because its resource keys are irregular and are grepped from the resx.

This commit is a 1:1 translation: the current inconsistencies are
reproduced exactly (AffectsMinimumRequiredVersion = false on
ExtensionMethods, UseLambdaSyntax and UseEnhancedUsing; no gate on
SwitchOnReadOnlySpanChar), verified against the old build by comparing
SetLanguageVersion and GetMinimumRequiredVersion behavior for every
setting at every language version, plus a reflection diff of the full
per-property attribute surface.

Assisted-by: Claude:claude-fable-5:Claude Code

1 month ago

3 Commits (a4ef71bb7643d92e174d53f8abcbe2158324feb8)