ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	a1f9a6b6f5	Fix #3824 : fold a hoisted argument null-guard at the ILAst level When a chained constructor-call argument contains a throwing null-check (e.g. `value?.Length ?? throw ...`) and the argument is evaluated more than once, the compiler hoists the null-check in front of the chained call. The hoisted `if (value == null) throw ...;` then became the first body statement, so MoveConstructorInitializer could not recognize the chained call and left it as an illegal in-body `base..ctor(...)` / `this..ctor(...)` (a parse error). Fix it in the ILAst, where the `?? throw` shape already lives, rather than re-deriving it on the C# AST: NullCoalescingTransform folds a guard that directly precedes the chained call back into the first use of the parameter as `if.notnull(ldloc param, throw)`. Nothing in a constructor body can legally run before the chained call, so a statement preceding it is necessarily compiler-hoisted; matching is by ILVariable identity, not parameter name. The guard disappears before the AST transforms run, so they need no change. Reference types chain via a base/this..ctor CallInstruction; value types chain via `this = new TSelf(...)`, i.e. stobj(ldthis, newobj TSelf(...)), which ChainedConstructorCallILOffset does not report -- so the value-type chain (including the case where this is spilled to a stack slot because the guard sits between its load and the call) is matched directly. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 days ago
Siegfried Pammer	79b0cbb719	Fix #3703 : Do not transform to a primary constructor if it's not public (or protected in abstract classes)	3 months ago
Siegfried Pammer	77d9ee73e9	Fix IDE2000 globally	6 months ago
Siegfried Pammer	c0a9afc4ad	Fix #3616 : local variable naming conflict with primary constructor parameters.	7 months ago
Siegfried Pammer	e42ee2428f	Remove warnings in test cases.	7 months ago
Siegfried Pammer	94050a4aca	Rewrite TransformFieldAndConstructorInitializers from a step-by-step AST-based analysis to an analysis that tracks the whole constructor body.	8 months ago
Siegfried Pammer	9c8d1e48d9	Many thanks to @sonyps5201314 for providing the test cases and a suggested fix, which inspired these changes. Various improvements regarding primary constructor decompilation, including: - introduce `HasPrimaryConstructor` property in the AST, as there is a difference between no primary constructor and a parameterless primary constructor - improved support for inherited records and forwarded ctor calls - exclude non-public fields and properties in IsPrintedMember - introduce an option to always make the decompiler emit primary constructors, when possible	8 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	10 months ago
Siegfried Pammer	e96605ca87	Fix #3310 : Filter out copy-constructor only if it's an actual record type.	2 years ago
Siegfried Pammer	c6e3752977	Fix #3089 : Add comment regarding .constraint prefix expressed as cast in C#	2 years ago
Siegfried Pammer	2043e5dd6f	Add support for C# 12 primary constructors.	2 years ago
Siegfried Pammer	702a7da2c3	Fix #2714 : Force inlining of call targets in ctor initializers.	4 years ago
Siegfried Pammer	ea1cea96c4	Fix #2547 : decimal const not removed from static constructor.	5 years ago
Siegfried Pammer	b1352aa569	Fix #1743 : Add pattern for struct constructor initializers.	7 years ago
Siegfried Pammer	17f42066a0	Fix #1378 : Missing unsafe modifier for static fields	8 years ago
Siegfried Pammer	4da1addd2b	Implement C# 2, C# 4 legacy and Roslyn lock patterns.	9 years ago
Siegfried Pammer	e26af08a1c	Move test projects to their own directory in \	9 years ago
Siegfried Pammer	9f161006a5	fix #560 : properly recognize `lock` pattern of C# 2, and add `lock (this)` pattern	12 years ago
Daniel Grunwald	2c75fada90	Update to NRefactory 5.4	12 years ago

15 Commits (a1f9a6b6f555c54179eb747136463281e83368bf)