ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	bb114b27a7	Prevent FailFast when an assembly is unloaded mid-decompile When the user removes an assembly while a decompile is still in flight, the title-refresh paths (spinner tick, post-Task.Run InvokeAsync, StopSpinner) walk node.Text -> LoadedAssembly.Text -> metadata.GetAssemblyDefinition().Version, reading directly from the PE file's MemoryMappedFile. AssemblyList.Unload calls Dispose synchronously and unmaps that file; any continuation that lands on the UI thread after Dispose dereferences freed pages and the CLR reports the AV through FailFastIfCorruptingStateException -- a catch block cannot intervene in .NET 5+. Assisted-by: Claude:claude-opus-4-7:Claude Code	4 weeks ago
Siegfried Pammer	a9b6b0d318	Tree paints before decompile; AssemblyTreeNode observes load Two ordering fixes for startup so the user sees the assembly tree before any decompiled content shows up in the document area, and so the lazy-load story actually holds. Assisted-by: Claude:claude-opus-4-7:Claude Code	4 weeks ago
Siegfried Pammer	2d0a7418d7	Lazy LoadedAssembly + 2s cooldown sweep + perf test Replace LoadedAssembly's eager Task.Run(LoadAsync) with a Lazy<Task<LoadResult>> so construction is free and the load only starts on the first GetLoadResultAsync / await / .Result access. Active assembly's load fires from the saved-path restore and runs without competition; everything else stays cold until either the user expands a tree node OR the cooldown sweep fires. Assisted-by: Claude:claude-opus-4-7:Claude Code	4 weeks ago
Siegfried Pammer	a8d841199d	Lift IDisposable to MetadataFile and dispose evicted assemblies. MetadataFile now declares IDisposable using the canonical pattern (public non-virtual Dispose() + protected virtual Dispose(bool)). PEFile and WebCilFile become sealed and override Dispose(bool) to release the PEReader and MemoryMappedViewAccessor they own; ResourcesFile is also sealed. PortableDebugInfoProvider disposes the MetadataReaderProvider it owns. LoadedAssembly implements IDisposable and disposes both the loaded MetadataFile and the debug-info provider. AssemblyList.Unload / Clear / ReloadAssembly / HotReplaceAssembly now dispose the LoadedAssembly instances they evict, fixing a resource leak where every "Reload Assembly" held the previous PEReader (and the underlying file handle / memory-mapped view) alive until GC eventually finalized it. The disposal contract terminates at the AssemblyList tier: downstream holders of MetadataFile (MetadataModule, DecompilerTypeSystem, AssemblyListSnapshot, ...) hold borrowed references rather than owned ones, so making the base IDisposable does not cascade into CA1001 / CA2213 warnings elsewhere. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2 months ago
Siegfried Pammer	77d9ee73e9	Fix IDE2000 globally	6 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	10 months ago
Siegfried Pammer	e94eb91739	Fix #3372 : Fix loading a DLL that contains byte sequences matching ZIP central directory.	1 year ago
Siegfried Pammer	df859a0520	Fix #3300 : System.FormatException: The input string 'PDB' was not in a correct format.	2 years ago
Siegfried Pammer	76cc084dcd	LazyInitializer.EnsureInitialized does not allow null as return value. Use LazyInit instead.	2 years ago
Siegfried Pammer	dbd9632f34	Fix #3247 : InvalidOperationException thrown when reading debug metadata files	2 years ago
Siegfried Pammer	77b237d5a4	Fix mysteriously deleted issue #3197 : Skip file formats that currently can only be loaded from a file when dealing with a file from a bundle or package.	2 years ago
Siegfried Pammer	65e30c0bd6	Add IFileLoader API	2 years ago
Siegfried Pammer	921bf36261	Add WebCIL support	2 years ago
Siegfried Pammer	ca78d4a14d	Use MetadataFile instead of PEFile in TypeSystem.	2 years ago
Siegfried Pammer	12cbf14106	Clean up node classes.	3 years ago
Siegfried Pammer	942131f487	#3068 : Introduce MetadataFile for pure ECMA-335 streams and as base class for PEFile	3 years ago
Christoph Wille	f56881de32	Change .Result to .GetAwaiter().GetResult() (#3040 )	3 years ago
Siegfried Pammer	35440d9974	Remove LoadedAssembly.WaitUntilLoaded	4 years ago
Siegfried Pammer	4b475cfa69	Create ILSpyX project and make the following APIs reusable: - AssemblyList, AssemblyListManager, AssemblyListSnapshot - LoadedAssembly - LoadedPackage and friends - PDB providers	4 years ago
Siegfried Pammer	31f6be38b5	Fix nullability warnings	4 years ago
Siegfried Pammer	669b48b609	Add AssemblyListSnapshot.TryGetSimilarModuleAsync	4 years ago
Siegfried Pammer	11fbb2610d	#2594 : Introduce AssemblyListSnapshot to avoid expensive and repetitive LoadedAssembly.CreateLoadedAssemblyLookupAsync calls	4 years ago
Siegfried Pammer	e823ed9966	#2594 : Cache LoadedAssembly.GetTargetFrameworkIdAsync, LoadedAssembly.GetRuntimePackAsync, PEFile.Name, PEFile.FullName to improve performance of assembly resolving. This improves performance of the analysis by a factor of 2.	5 years ago
Siegfried Pammer	27f56a9253	Use ArrayPool<byte>.Shared for decompression.	5 years ago
Siegfried Pammer	6cda7cceb1	Use FileName parameter instead of LoadedAssembly.fileName	5 years ago
Christian Prähauser	95f9908823	Ensure we read all of compressed data in LoadCompressedAssembly	5 years ago
Christian Prähauser	39d230f022	Support loading compressed Xamarin assemblies, see #2137 Extend class LoadedAssembly to detect and load compressed Xamarin assemblies if direct loading of assembly fails. Requires Nuget pkg K4os.Compression.LZ4 for LZ4 decompression.	5 years ago
Daniel Grunwald	6757295b3b	Fix #2379 : Keep `return` statements around in original form for ConditionDetection, only transform to fall-through block-exit at the end of the transform pipeline. This fixes an issue where `return` statements within try-blocks could turn into `goto` statements.	5 years ago
Daniel Grunwald	46e9f633ca	#enable nullable in AssemblyList + DecompilerTextView	5 years ago
riQQ	95bd57c888	Fix warning CS8625 Fix warning CS8625: Cannot convert null literal to non-nullable reference type.	5 years ago
Siegfried Pammer	5734da4294	Fix #2314 : ILSpy incorrectly resolves a runtime dependency when dll is present in both WindowsDesktop.App and NETCore.App	5 years ago
Siegfried Pammer	5740068753	Fix #2310 : Do not set mainAssemblyFileName in UniversalAssemblyResolver in case LoadedAssembly.FileName is not a full path.	5 years ago
Daniel Grunwald	281586de1f	`#enable nullable` for a couple of files. Includes some fixes for potential NullReferenceExceptions.	5 years ago
Daniel Grunwald	2f14cde050	#2295 : Handle BadImageFormatException in LoadAssembly. When nuget packages are <40 KB, SRM seems to throw `BadImageFormatException` instead of `PEFileNotSupportedException`.	5 years ago
Daniel Grunwald	263d9b9e07	Simplify the assembly-resolving implementation. * We no longer maintain the weird `loadingAssemblies` global state. * AssemblyList now internally handles multiple concurrent load requests for the same filename. * AssemblyList.assemblies and its lock is now private to the AssemblyList. * Removed a questionable caching layer (cache was per-AssemblyList, but was caching the result of a per-LoadedAssembly lookup function. * Replaced static DisableAssemblyLoad() with bool-parameter on GetAssemblyResolver() call.	5 years ago
Daniel Grunwald	3664e36e3e	Fix GetAssemblyReferenceClassifier() not initializing the universalResolver.	5 years ago
Daniel Grunwald	d70bfe80d5	Add ResolveAsync() method to IAssemblyResolver interface. DecompilerTypeSystem uses this to resolve/load multiple assemblies in parallel. Unfortunately this doesn't gain us any performance yet in ILSpy because there we have a global assembly-loader-lock :(	5 years ago
Daniel Grunwald	687bca88f3	LoadedAssembly.GetPEFileOrNull(): avoid unnecessary throw+catch when called on bundles. This improves ILSpy performance when run inside the debugger.	6 years ago
Siegfried Pammer	924e7a0ec4	Fix "Select PDB" command when working with bundles.	6 years ago
Daniel Grunwald	82bb805657	Don't show PDB context menu entries on bundle nodes.	6 years ago
Daniel Grunwald	0de6238d65	Support resolving assembly references within a bundle.	6 years ago
Daniel Grunwald	b2cbb12f15	Thread-safety for LoadedAssembly.GetTypeSystemOrNull()	6 years ago
Siegfried Pammer	f0012cbc1a	#2198 : Make ILSpy more resilient in case of obfuscated assemblies.	6 years ago
Daniel Grunwald	a354b32a16	Add support for .NET bundles.	6 years ago
Daniel Grunwald	f74d3c40a9	Add NuGet packages (and other files) to TreeView	6 years ago
文煌	d612008c9f	write OutputType for asp.net library	6 years ago
文煌	e8e0f89f6d	don't write HintPath for .NET Core shared assembly	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	4b865c27e4	Fix #2076 : VS AddIn opens reference assembly.	6 years ago
Siegfried Pammer	4f8c588c7b	Fix #2068 : ILSpy can't find referenced library even though it's open	6 years ago

19 Commits (931375708f215f545da8091445be8edc4fbce49a)