ILSpy

8953 Commits

24 Branches

90 Tags

71 MiB

Tree: 87748e0cde

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	87748e0cde	Override vulnerable transitive packages from the DiaSymReader chain The Microsoft.DiaSymReader / .PortablePdb packages pull NETStandard.Library 1.6.1, which drags in 4.3.0 builds of System.Net.Http, System.Private.Uri and System.Text.RegularExpressions, all carrying known advisories (NU1902/ NU1903). They are framework-provided at runtime on net10.0; pin the patched 4.3.4 / 4.3.2 / 4.3.1 via central transitive pinning so NuGet audit passes. Enabling transitive pinning also aligns a handful of other transitive packages to their declared central versions. Assisted-by: Claude:claude-opus-4-8:Claude Code	4 weeks ago
Siegfried Pammer	8488e5e214	Reference DiaSymReader on every OS so the lock file is OS-stable The Pdb2Xml command (ILSpy) and the PDB round-trip tests (Decompiler.Tests) reference Microsoft.DiaSymReader, previously gated on the build host being Windows. That made dotnet restore resolve a different graph on Windows than on Linux -- the packages (and their transitive tail: DiaSymReader.PortablePdb, the legacy NETCore.Platforms/Win32 packages) appear only on Windows, and DiaSymReader.Native flips between Direct and CentralTransitive. So a checkout could not be developed across OSes without the committed packages.lock.json churning on every Windows restore. Drop the OS gate (keep Debug-only) so the restored graph, and the committed lock, are identical on every OS. The consuming code is still gated by DEBUG and WINDOWS, so on non-Windows the packages are restored but never compiled in; the native asset only resolves for win- RIDs. The "Verify package contents" step (which checks the committed *.filelist snapshots still match the built VSIX/MSI contents) had been excluding packages.lock.json from its git diff to tolerate that per-OS churn. With the locks now identical across OSes the carve-out is unnecessary, so it goes back to a plain git diff --exit-code. Assisted-by: Claude:claude-opus-4-8:Claude Code	4 weeks ago
Siegfried Pammer	667f6ad5f8	Add pwsh dev scripts, repo-wide lock files, and CI NuGet caching Replace the Windows-only .bat helpers (clean / debugbuild / releasebuild / restore / updatedeps and BuildTools/format) with cross-platform pwsh scripts at the repo root: restore.ps1, build.ps1 (-Configuration), clean.ps1, updatedeps.ps1 and BuildTools/format.ps1, alongside the existing publish.ps1. Enable a packages.lock.json for every project by hoisting RestorePackagesWithLockFile into the root Directory.Build.props (the four core libraries set it individually before) and commit the generated locks, so restores are repeatable and CI can cache packages off them. Cache the NuGet packages folder in the three setup-dotnet workflows (build-ilspy, build-frontends, codeql-analysis), keyed on the lock files per the setup-dotnet caching guidance. Scope the Debug "Verify package contents" check to the .filelist outputs it actually generates. A project's packages.lock.json is keyed only by (framework, RID), with no host-OS axis, so a lock produced on Linux legitimately differs from one produced on Windows whenever an OS-conditional PackageReference applies (Debug+Windows pulls Microsoft.DiaSymReader). The Windows restore then rewrites those locks; that churn must not fail a step whose job is to police the VSIX/MSI file lists. Also drop the dead ILSpy.BamlDecompiler publish line from publishlocaldev.ps1, mirroring the earlier publish.ps1 fix. Assisted-by: Claude:claude-opus-4-8:Claude Code	4 weeks ago

Author

SHA1

Message

Date

Siegfried Pammer

87748e0cde

Override vulnerable transitive packages from the DiaSymReader chain

The Microsoft.DiaSymReader / .PortablePdb packages pull NETStandard.Library
1.6.1, which drags in 4.3.0 builds of System.Net.Http, System.Private.Uri
and System.Text.RegularExpressions, all carrying known advisories (NU1902/
NU1903). They are framework-provided at runtime on net10.0; pin the patched
4.3.4 / 4.3.2 / 4.3.1 via central transitive pinning so NuGet audit passes.
Enabling transitive pinning also aligns a handful of other transitive
packages to their declared central versions.

Assisted-by: Claude:claude-opus-4-8:Claude Code

4 weeks ago

Siegfried Pammer

8488e5e214

Reference DiaSymReader on every OS so the lock file is OS-stable

The Pdb2Xml command (ILSpy) and the PDB round-trip tests (Decompiler.Tests)
reference Microsoft.DiaSymReader*, previously gated on the build host being
Windows. That made dotnet restore resolve a different graph on Windows than
on Linux -- the packages (and their transitive tail: DiaSymReader.PortablePdb,
the legacy NETCore.Platforms/Win32 packages) appear only on Windows, and
DiaSymReader.Native flips between Direct and CentralTransitive. So a checkout
could not be developed across OSes without the committed packages.lock.json
churning on every Windows restore.

Drop the OS gate (keep Debug-only) so the restored graph, and the committed
lock, are identical on every OS. The consuming code is still gated by DEBUG
and WINDOWS, so on non-Windows the packages are restored but never compiled
in; the native asset only resolves for win-* RIDs.

The "Verify package contents" step (which checks the committed *.filelist
snapshots still match the built VSIX/MSI contents) had been excluding
packages.lock.json from its git diff to tolerate that per-OS churn. With the
locks now identical across OSes the carve-out is unnecessary, so it goes back
to a plain git diff --exit-code.

Assisted-by: Claude:claude-opus-4-8:Claude Code

4 weeks ago

Siegfried Pammer

667f6ad5f8

Add pwsh dev scripts, repo-wide lock files, and CI NuGet caching

Replace the Windows-only .bat helpers (clean / debugbuild / releasebuild /
restore / updatedeps and BuildTools/format) with cross-platform pwsh
scripts at the repo root: restore.ps1, build.ps1 (-Configuration), clean.ps1,
updatedeps.ps1 and BuildTools/format.ps1, alongside the existing publish.ps1.

Enable a packages.lock.json for every project by hoisting
RestorePackagesWithLockFile into the root Directory.Build.props (the four
core libraries set it individually before) and commit the generated locks,
so restores are repeatable and CI can cache packages off them.

Cache the NuGet packages folder in the three setup-dotnet workflows
(build-ilspy, build-frontends, codeql-analysis), keyed on the lock files
per the setup-dotnet caching guidance.

Scope the Debug "Verify package contents" check to the *.filelist outputs
it actually generates. A project's packages.lock.json is keyed only by
(framework, RID), with no host-OS axis, so a lock produced on Linux
legitimately differs from one produced on Windows whenever an OS-conditional
PackageReference applies (Debug+Windows pulls Microsoft.DiaSymReader*). The
Windows restore then rewrites those locks; that churn must not fail a step
whose job is to police the VSIX/MSI file lists.

Also drop the dead ILSpy.BamlDecompiler publish line from
publishlocaldev.ps1, mirroring the earlier publish.ps1 fix.

Assisted-by: Claude:claude-opus-4-8:Claude Code

4 weeks ago

3 Commits (87748e0cded6e39617256fa2b2503548a99ece18)