ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	c5f8834e57	Stop the assembly list from disposing removed assemblies Unload / Clear / ReloadAssembly / HotReplaceAssembly all called LoadedAssembly.Dispose() on the assembly they removed, which disposes its MetadataFile and unmaps the underlying file. But open document tabs and tree nodes can still hold that MetadataFile, and the list has no safe point at which to know those references are gone -- so disposing risked unmapping a file out from under a live reader (use-after-dispose). Drop the removed assembly and let the GC reclaim it once nothing references it instead. The DockWorkspace cancel-on-remove is now a courtesy, not a guard against an unmap race.	4 weeks ago
Siegfried Pammer	a8d841199d	Lift IDisposable to MetadataFile and dispose evicted assemblies. MetadataFile now declares IDisposable using the canonical pattern (public non-virtual Dispose() + protected virtual Dispose(bool)). PEFile and WebCilFile become sealed and override Dispose(bool) to release the PEReader and MemoryMappedViewAccessor they own; ResourcesFile is also sealed. PortableDebugInfoProvider disposes the MetadataReaderProvider it owns. LoadedAssembly implements IDisposable and disposes both the loaded MetadataFile and the debug-info provider. AssemblyList.Unload / Clear / ReloadAssembly / HotReplaceAssembly now dispose the LoadedAssembly instances they evict, fixing a resource leak where every "Reload Assembly" held the previous PEReader (and the underlying file handle / memory-mapped view) alive until GC eventually finalized it. The disposal contract terminates at the AssemblyList tier: downstream holders of MetadataFile (MetadataModule, DecompilerTypeSystem, AssemblyListSnapshot, ...) hold borrowed references rather than owned ones, so making the base IDisposable does not cascade into CA1001 / CA2213 warnings elsewhere. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	10 months ago
Siegfried Pammer	3b8302903a	Fix #3450 : Fix "Clear assembly list" not actually persistent.	1 year ago
tom-englert	152f70e789	ILSpyX: remove InternalsVisibleTo for ILSpy + remove some redundant code.	2 years ago
tom-englert	0c1c5cecd7	Decouple AssemblyListPane from MainWindow	2 years ago
Siegfried Pammer	65e30c0bd6	Add IFileLoader API	2 years ago
Siegfried Pammer	84c5e63370	Fix #3118 : Add "Clear assembly list" menu item.	3 years ago
Siegfried Pammer	3043af0ead	Fix NRT warnings in ILSpyX	4 years ago
Siegfried Pammer	ed88a230a5	#2657 : Properly set ApplyWinRTProjections and UseDebugSymbols settings on loaded assemblies.	4 years ago
Siegfried Pammer	4b475cfa69	Create ILSpyX project and make the following APIs reusable: - AssemblyList, AssemblyListManager, AssemblyListSnapshot - LoadedAssembly - LoadedPackage and friends - PDB providers	4 years ago
Siegfried Pammer	31f6be38b5	Fix nullability warnings	4 years ago
Siegfried Pammer	11fbb2610d	#2594 : Introduce AssemblyListSnapshot to avoid expensive and repetitive LoadedAssembly.CreateLoadedAssemblyLookupAsync calls	4 years ago
Siegfried Pammer	07ee98ca37	#2564 : lock list.lockObj as well.	5 years ago
Siegfried Pammer	2debfe9e73	Fix #2564 : Make sure lock is held in all AssemblyList ctors that modify it.	5 years ago
Daniel Grunwald	46e9f633ca	#enable nullable in AssemblyList + DecompilerTextView	5 years ago
Siegfried Pammer	c67f204fd2	Avoid possible race with HasLoadError.	5 years ago
Siegfried Pammer	64338d8d23	Fix #2340 : Do not traverse assemblies with load errors in AssemblyList.GetAllAssemblies()	5 years ago
Siegfried Pammer	feb623d602	Fix #2234 : Implement support for nuget packages/bundles in search, analyzers and the derived types list.	5 years ago
Siegfried Pammer	fff2d0a787	Fix assertions on AssemblyList.Sort and AssemblyList.Unload. Fix hang on LoadDependencies.Execute.	5 years ago
Daniel Grunwald	263d9b9e07	Simplify the assembly-resolving implementation. * We no longer maintain the weird `loadingAssemblies` global state. * AssemblyList now internally handles multiple concurrent load requests for the same filename. * AssemblyList.assemblies and its lock is now private to the AssemblyList. * Removed a questionable caching layer (cache was per-AssemblyList, but was caching the result of a per-LoadedAssembly lookup function. * Replaced static DisableAssemblyLoad() with bool-parameter on GetAssemblyResolver() call.	5 years ago
Siegfried Pammer	924e7a0ec4	Fix "Select PDB" command when working with bundles.	6 years ago
Daniel Grunwald	0de6238d65	Support resolving assembly references within a bundle.	6 years ago
Daniel Grunwald	f74d3c40a9	Add NuGet packages (and other files) to TreeView	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Daniel Grunwald	04662d7c7d	Auto-loading dependent assemblies shouldn't trigger saving the assembly list This avoids saving the file a dozen times during the initial decompilation.	6 years ago
Siegfried Pammer	60e9c204cc	Fix #1940 : Make sure that we use the correct .NET Core version, when there are multiple frameworks loaded in the current assembly list.	6 years ago
Siegfried Pammer	32dad4f476	Fix bug occurring when trying to load .netmodule reference after invoking LoadedAssembly.DisableAssemblyLoad()	6 years ago
Siegfried Pammer	82f048d497	Add "Select PDB..." context menu item on assemblies, to be able to manually load a PDB for an assembly.	7 years ago
Siegfried Pammer	38dec5cf5e	Fix #1800 : Modernize Assembly Lists	7 years ago
Siegfried Pammer	5ad3cf9143	Add support for module references in ILSpy.	8 years ago
Siegfried Pammer	0e0291a113	Refactoring of LookupReferencedAssemblyInternal	9 years ago
Siegfried Pammer	bb381327ac	Implement API to reload loaded nuget assemblies.	9 years ago
Siegfried Pammer	3fcdfaab8a	Add basic NugetPackageBrowserDialog	9 years ago
Siegfried Pammer	6cdfc22f1c	fix #350 - Refresh item in context menu of assemblies	10 years ago
Ed Harvey	0469352e1e	fix #574 : "Add To Main List" context menu updates not always persisted across program runs	11 years ago
de4dot	f35ebc64d1	Preserve IsAutoLoaded property when hot replacing assemblies	11 years ago
Ed Harvey	1ca36b98d7	Set LoadedAssembly.IsAutoLoaded before adding to AssemblyList Adding LoadedAssy to list triggers events handlers that need IsAutoLoaded.	12 years ago
Ed Harvey	60fe27f744	#358 Separate automatically-loaded assemblies from manually loaded assemblies The assembly list is not automatically sorted into explicit/auto loaded groups at the moment. Sorting the list loses the tree state (expanded nodes/selections)...	12 years ago
Sebastien LEBRETON	560eb73565	Allow assembly hot replacement from stream	12 years ago
Ed Harvey	729cc9da0c	Code Tidy : Remove redundant using statements	15 years ago
Daniel Grunwald	21f6f01b36	Add support for resolving WinRT metadata.	15 years ago
Daniel Grunwald	fdb8001b87	Explicitly trigger garbage collection after an assembly was unloaded. Closes #246 .	15 years ago
Daniel Grunwald	a318ce67be	Cache assembly lookup results - improves performance (especially for failed lookups)	15 years ago
Daniel Grunwald	e5f043e643	AssemblyList: add Sort() method	15 years ago
Daniel Grunwald	5c7d679c52	Add TestPlugin.	15 years ago
Daniel Grunwald	d0670aae7b	Use MEF for the existing File menu items.	16 years ago
Daniel Grunwald	381df74fa6	Split assembly loading logic out of AssemblyTreeNode.	16 years ago
Daniel Grunwald	0e47eaf60c	Use SharpTreeNode.IsHidden for filtering.	16 years ago
Daniel Grunwald	7f45c26f6d	Adjust ILSpy to SharpTreeView changes.	16 years ago

11 Commits (8696b691e6285e6ab9bbe70e277799a2d9a25e6b)