ILSpy

9270 Commits

54 Branches

94 Tags

91 MiB

Tree: 7554c1b004

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	7554c1b004	Remove the syntactic automatic-event patterns With recognition on the ILAst and reference substitution during translation, the four accessor-body patterns in PatternStatementTransform were only reachable as a fallback, and any divergence between them and the AutoEventDecompiler verdict produced inconsistent output. A compiler shape the ILAst matchers do not know now degrades to explicit accessors with the backing field kept in the output, which stays compilable. Bodyless events (abstract, extern, interface members) previously relied on the patterns' no-body clause to become field-like; since C# cannot express bodyless custom accessors, DoDecompile now chooses the field-like form for them directly. Also deletes the orphaned IsEventBackingFieldName helper; the name association lives in PropertyAndEventBackingFieldLookup. Assisted-by: Claude:claude-fable-5:Claude Code Claude-Session: https://claude.ai/code/session_01Btdypgm8utyxqt1Etn2BDi	2 months ago
Siegfried Pammer	5fa44fab6a	Emit member-initializer sequence points in every constructor A field, auto-property, or event initializer is written once at its declaration, but in IL it runs in every instance constructor that does not chain to this(...) (and static initializers run in the static constructor). The decompiler lifts the initializer from a single constructor, so its breakpoint was emitted only there and the other constructors had none. Two causes are addressed: - The lift discarded the initializer's copies in the other constructors. They are now kept on MemberInitializerInOtherConstructorsAnnotation and replayed by SequencePointBuilder, mapping the same source location onto each constructor's IL. - PortablePdbWriter only emitted methods that DebugInfoGenerator discovered through declaration syntax, so a constructor whose declaration is omitted from the output (implicit default ctor, implicit static ctor, primary ctor) dropped its generated points. Those functions are now emitted by walking the sequence-point map directly. PdbGen fixtures cover single, multiple, this()-chained, implicit, static, primary-constructor, and field-like event initializers, pinning the reconstructed breakpoint map against the C# compiler's. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago

Author

SHA1

Message

Date

Siegfried Pammer

7554c1b004

Remove the syntactic automatic-event patterns

With recognition on the ILAst and reference substitution during
translation, the four accessor-body patterns in
PatternStatementTransform were only reachable as a fallback, and any
divergence between them and the AutoEventDecompiler verdict produced
inconsistent output. A compiler shape the ILAst matchers do not know now
degrades to explicit accessors with the backing field kept in the
output, which stays compilable. Bodyless events (abstract, extern,
interface members) previously relied on the patterns' no-body clause to
become field-like; since C# cannot express bodyless custom accessors,
DoDecompile now chooses the field-like form for them directly. Also
deletes the orphaned IsEventBackingFieldName helper; the name
association lives in PropertyAndEventBackingFieldLookup.

Assisted-by: Claude:claude-fable-5:Claude Code
Claude-Session: https://claude.ai/code/session_01Btdypgm8utyxqt1Etn2BDi

2 months ago

Siegfried Pammer

5fa44fab6a

Emit member-initializer sequence points in every constructor

A field, auto-property, or event initializer is written once at its
declaration, but in IL it runs in every instance constructor that does not
chain to this(...) (and static initializers run in the static constructor).
The decompiler lifts the initializer from a single constructor, so its
breakpoint was emitted only there and the other constructors had none.

Two causes are addressed:

- The lift discarded the initializer's copies in the other constructors.
  They are now kept on MemberInitializerInOtherConstructorsAnnotation and
  replayed by SequencePointBuilder, mapping the same source location onto
  each constructor's IL.
- PortablePdbWriter only emitted methods that DebugInfoGenerator discovered
  through declaration syntax, so a constructor whose declaration is omitted
  from the output (implicit default ctor, implicit static ctor, primary
  ctor) dropped its generated points. Those functions are now emitted by
  walking the sequence-point map directly.

PdbGen fixtures cover single, multiple, this()-chained, implicit, static,
primary-constructor, and field-like event initializers, pinning the
reconstructed breakpoint map against the C# compiler's.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

2 Commits (7554c1b0042dddac2a7385cea5b64f12dd52281b)