ILSpy

9792 Commits

54 Branches

94 Tags

91 MiB

Tree: 72dbe6f41d

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	483a8661f6	Add VB tests for On Error and Try/Catch/Finally VB lowers error handling differently from C# and no fixture covered it: every Catch brackets its body with SetProjectError/ClearProjectError, Catch...When moves that call into the filter, and On Error becomes one try block with a dispatch switch driven by line and handler state. The expected output is the current decompilation, rough spots included (delegate-invoked filter blocks; gotos into the dispatch switch that leave unreachable code, which keeps VBOnError.cs out of the warnings-as-errors project), so improvements show up as diffs. IL offset labels differ per compiler and optimization level, hence the per-method #if variants. Legacy vbc output was verified on Windows. The correctness test covers what a pretty test cannot: catching object made the decompiled On Error code fail to recompile with CS0155, and the round trip shows the rewritten dispatch code still runs the same. Like the mcs configurations, the legacy and Roslyn 2.10/.NET Core 2.2 ones recompile the decompiled VB code with the latest Roslyn: C# 5 cannot express the exception filters VB error handling compiles to, and the .NET Core 2.2 Microsoft.VisualBasic.dll lacks Information.Err and ProjectData.CreateProjectError. Assisted-by: Claude:claude-opus-5:Claude Code	15 hours ago

Author

SHA1

Message

Date

Siegfried Pammer

483a8661f6

Add VB tests for On Error and Try/Catch/Finally

VB lowers error handling differently from C# and no fixture covered it:
every Catch brackets its body with SetProjectError/ClearProjectError,
Catch...When moves that call into the filter, and On Error becomes one
try block with a dispatch switch driven by line and handler state. The
expected output is the current decompilation, rough spots included
(delegate-invoked filter blocks; gotos into the dispatch switch that
leave unreachable code, which keeps VBOnError.cs out of the
warnings-as-errors project), so improvements show up as diffs. IL offset
labels differ per compiler and optimization level, hence the per-method
#if variants. Legacy vbc output was verified on Windows.

The correctness test covers what a pretty test cannot: catching object
made the decompiled On Error code fail to recompile with CS0155, and the
round trip shows the rewritten dispatch code still runs the same. Like
the mcs configurations, the legacy and Roslyn 2.10/.NET Core 2.2 ones
recompile the decompiled VB code with the latest Roslyn: C# 5 cannot
express the exception filters VB error handling compiles to, and the
.NET Core 2.2 Microsoft.VisualBasic.dll lacks Information.Err and
ProjectData.CreateProjectError.

Assisted-by: Claude:claude-opus-5:Claude Code

15 hours ago

1 Commits (72dbe6f41d480728ffa60bb68d1b95f9118d6b15)