ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	322add8d14	Fix dynamic event-assignment decompilation leaking is-event opcode DynamicIsEventInstruction has no ExpressionBuilder visitor, so any is-event diamond that survives the transform pipeline leaks as an "OpCode not supported" comment. The collapse only fired for the plain statement form; every other lowering the compiler emits for "d.Event += b" was missed: - a copy-of-value temporary between the getmember cache and the diamond (modern Roslyn emits it for the statement form), - the result-used shape, where the diamond is a value-if nested inside the consuming expression (a call argument, or a leave's value when returned), - the result-returned shape as two leaves, "if (isevent) leave(add)" plus a fall-through "leave(compound)" rather than an if/else, and - the same two-leaves shape when the optimizer drops the getmember cache (legacy csc and Roslyn <= 2.x): the is-event flag then feeds a single branch, inlining folds it into the condition, and the compound leave is already collapsed, so the cache-based entry never matched it and the branch leaked. These compilers only run on Windows CI, so the gap was invisible on Linux. The descendants walk handles the nested value-if once an over-strict copy-of-value bounds guard (which never held for the compact return block) is dropped. The two two-leaves shapes share a skeleton matcher and the add/remove accessor-name check, and both validate the accessor name and arguments. Re-running from the collapsed statement instead of the next one avoids indexing past the end of a block that has shrunk to a single leave. Assisted-by: Claude:claude-opus-4-8:Claude Code	2 months ago
Siegfried Pammer	04505bbdf2	Highlight and scroll to the changed instruction in the ILAst view The C# debug-steps view highlights and centers the exact AST node a transform changed; the ILAst view already had the step tree and replay-at-step but produced no highlight. Bring it to parity. IL rendering has no token-writer seam like the C# output visitor, so per-instruction text spans are recorded by bracketing ILInstruction.WriteTo via a new INodeTrackingOutput. The dominant inst.ReplaceWith(newInst) transform pattern detaches the instruction passed to Step, so ILTransformContext gains EndStep to record the produced instruction; Stepper additionally records the position's ancestor chain as fallback candidates before the step-limit throw, so the "show state before" view -- which halts at the selected step -- still resolves to a surviving ancestor (ultimately the ILFunction). The highlight-range resolver is shared with the C# language. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Siegfried Pammer	49368caf1c	Rename option to "UseObjectCreationOfGenericTypeParameter"	1 year ago
Siegfried Pammer	2461f520ab	Move LocalFunctionDecompiler.GetStatement to Block.GetContainingStatement	1 year ago
Siegfried Pammer	47dd905ad0	Make InlineArrayTransform post-order	1 year ago
Siegfried Pammer	79f7a188b0	Add support for C# 12 inline array expressions	1 year ago
Siegfried Pammer	6c72d1c5f0	Add transform to remove unconstrained generic reference type check.	1 year ago
Siegfried Pammer	9f77f8a919	Prevent inlining of call arguments when doing so would change order of evaluation with regards to the implicit ldobj performed by a constrained.callvirt.	1 year ago
ds5678	b0d6fa2276	Add support for array initialization based on RuntimeHelpers.CreateSpan<T>	2 years ago
Siegfried Pammer	2ca5b5affe	Rewrite AssignVariableNames algorithm to use variable usages instead of the list of variables.	2 years ago
Siegfried Pammer	28aa88bfb8	Make NullableLiftingTransform handle the case where ExpressionTransforms.VisitComp already lifted a nullable comparison with constant.	2 years ago
Siegfried Pammer	9d22e3ab41	NullableLiftingTransform: Undo new compiler optimization (omitting get_HasValue for comparisions with constants)	2 years ago
Siegfried Pammer	9ba47db69b	Add new a.GetValueOrDefault(b) -> a ?? b transform for side-effect-free default values.	3 years ago
Siegfried Pammer	e193b838da	Move TransformDecimalCtorToConstant to EarlyExpressionTransforms	3 years ago
Siegfried Pammer	688474facd	Add missing DecompilerSettings for new language features	3 years ago
Daniel Grunwald	f568123704	Add support for UTF8 string literals	3 years ago
ElektroKill	01fd6e97f3	Fixed overflow exception and added tests	3 years ago
ElektroKill	bf0fe3aa15	Consider constructor type when lifting decimal constants	3 years ago
Daniel Grunwald	d3919aa99a	Support native ints in "Combine bit.and into shift" transform	4 years ago
Siegfried Pammer	dbbcbb87fe	Make pattern matching transform a simple ILTransform for both reference and value types. Check that the true branch dominates all uses of the pattern variable.	5 years ago
Siegfried Pammer	cd0c76d7b1	Support leave instructions in RemoveInfeasiblePathTransform and transform match(x) ? true : false to match(x).	5 years ago
Siegfried Pammer	76227af89d	Fix #1749 , fix #2339 , fix #2353 : Add support for rethrow in async exception handlers, fix await catch/finally patterns for complex methods.	6 years ago
Daniel Grunwald	80cf72e498	#2182 : Move "Transform call to struct constructor" from EarlyExpressionTransforms to ILReader. This fixes the evaluation order for such calls (and an assertion in StObj.CheckTargetSlot).	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	7ed4a736f3	Fix #2103 : Support for `Stackalloc initializers` not working for `byte`	6 years ago
Daniel Grunwald	abb9d49a0f	Add support for C# 8 switch expressions.	6 years ago
Siegfried Pammer	9c8df1d949	Fix assignment of ILRanges in ExpressionTransforms.TransformCatchVariable	6 years ago
Daniel Grunwald	dc6e094a30	Add support for indexing arrays using System.Index	7 years ago
Siegfried Pammer	4db41f69db	Fix #1919 : Use unmapped IL offsets at the start of a catch-block for the 'exception specifier' sequence point.	7 years ago
Siegfried Pammer	ba5c645257	Add TryCatchHandler annotation to CatchClause	7 years ago
SilverFox	5914d5b96b	Fix #1854	7 years ago
Daniel Grunwald	93806b46fa	Fix compound assignments with type `bool`. This required removing the "Replace bit.and with logic.and" transform, as it interfered with the compound assignment transform.	7 years ago
Daniel Grunwald	a1c211f326	Fix #1794 : Avoid extra cast to double for ulong -> float conversion	7 years ago
Daniel Grunwald	f1021cb300	Fix #1643 : Handle unbox.any in TransformCatchVariable.	7 years ago
Siegfried Pammer	03151bf37b	Remove redundant code in ExpressionTransforms.VisitBlockContainer	7 years ago
Siegfried Pammer	9c06d5c924	Fix #1642 : Allow StackTypes I, I4, I8 and Unknown as switch value, convert Unknown and I to I8.	7 years ago
Siegfried Pammer	7502e521c1	Improve documentation of ExpressionTransforms.TransformCatchVariable	7 years ago
Siegfried Pammer	72c3e828f3	Check IsPure before Match.	7 years ago
Siegfried Pammer	c477ccf68e	Add SemanticHelper.IsPure check as per code-review.	7 years ago
Siegfried Pammer	ec18094c65	Implement transformation of delegate construction with ldvirtftn.	7 years ago
Daniel Grunwald	752f0de978	Further adjustments to transforms now that copy propagation no longer runs.	7 years ago
Siegfried Pammer	adc443e4e2	Fix dynamic compound assignments	7 years ago
Daniel Grunwald	539e3a906d	Fix #1552 : user-defined and decimal increments For user-defined increments, there were problems with Roslyn was optimizing out one of the stores. The new transform FixRemainingIncrements now takes increments/decrements that were not detected by TransformAssignment and introduces a temporary variable that can be incremented. This sometimes requires un-inlining via the new ILInstruction.Extract() operation. Extract() is not supported in all possible contexts, so it is possible but unlikely that some op_Increment calls remain. For decimals, the situation is different: legacy csc actually was optimizing "d + 1m" to "op_Increment(d)", so we can get rid of any left-over increments by undoing this optimization. This now happens in ReplaceMethodCallsWithOperators.	7 years ago
Siegfried Pammer	19a7898786	Add addressof(ldloc) => ldloca transform to EarlyExpressionTransforms	7 years ago
Siegfried Pammer	119c679fad	Add addressof(ldloc V) => ldloca V transform for read access on value types.	7 years ago
Daniel Grunwald	3314f3f37a	Fix #1571 : Expression transforms not running for values of inline assignments.	7 years ago
Siegfried Pammer	6a1229028c	Only try to inline stackalloc Span<T> if the next statement is a plain assignment.	7 years ago
Siegfried Pammer	9590cfbf59	Update tests to latest Roslyn implementation.	7 years ago
Daniel Grunwald	961923f4fd	#1499 , #1240 : Translate pointer arithmetic on managed pointers (ref T) using the System.Runtime.CompilerServices.Unsafe intrinsics	7 years ago
Siegfried Pammer	d42cf99a8c	Fix dynamic transforms because https://github.com/dotnet/roslyn/issues/27800 was fixed.	8 years ago

1 2 3

127 Commits (3ab2a2b0cbac1196586d3f9e13853bdbc0b74bb8)