ILSpy

9281 Commits

54 Branches

94 Tags

91 MiB

Tree: 1c010a828e

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	461df88572	Replace automatic-event backing-field references during translation PatternStatementTransform renamed backing-field identifiers to the event after the fact, keyed on the metadata name association alone: references belonging to an event that is not actually automatic were still renamed, binding them to a custom event that is unusable as a value (the same defect class as #3858), and the rename bypassed the resolver checks, so qualifiers were computed for the hidden field instead of the printed event. ExpressionBuilder.ConvertField now performs the substitution, keyed on the AutoEventDecompiler verdict whose memo moves into DecompileRun so that member hiding, the event declaration, and reference translation all decide from one analysis. Checking the verdict's field identity also keeps same-typed sibling events apart (#3575), and the qualifier logic running against the event drops spurious this./type qualifiers from raise sites. mcs 2.x accesses a sibling automatic event's backing field directly inside custom accessors instead of calling the accessor, so the fixture expects the resulting Delegate.Combine form there. Assisted-by: Claude:claude-fable-5:Claude Code Claude-Session: https://claude.ai/code/session_01Btdypgm8utyxqt1Etn2BDi	2 months ago
Siegfried Pammer	1b9131905d	Fix #3858 : Detect automatic events on the ILAst instead of the C# AST The syntactic accessor-body patterns in PatternStatementTransform sit downstream of every settings-dependent transform, so each new compiler shape or settings combination silently broke recognition: with AggressiveInlining enabled, static events inline the Delegate.Combine call into CompareExchange positionally, which none of the four patterns matched, while call sites were still rewritten to the event name from metadata alone - producing uncompilable output (CS0079). Recognition now happens in DoDecompile(IEvent) by structurally matching the ILAst of the accessors, decompiled with a fixed set of settings the same way RecordDecompiler analyzes method bodies. This makes detection independent of the user-visible settings by construction. Events that are not recognized fall back to the classic path unchanged, including the existing AST patterns. mcs 2.x compiles the accessors as a compound assignment, evaluating 'this' once via IL 'dup'; the simple-combine matcher accepts that stack-slot alias. Assisted-by: Claude:claude-fable-5:Claude Code	2 months ago

Author

SHA1

Message

Date

Siegfried Pammer

461df88572

Replace automatic-event backing-field references during translation

PatternStatementTransform renamed backing-field identifiers to the event
after the fact, keyed on the metadata name association alone: references
belonging to an event that is not actually automatic were still renamed,
binding them to a custom event that is unusable as a value (the same
defect class as #3858), and the rename bypassed the resolver checks, so
qualifiers were computed for the hidden field instead of the printed
event. ExpressionBuilder.ConvertField now performs the substitution,
keyed on the AutoEventDecompiler verdict whose memo moves into
DecompileRun so that member hiding, the event declaration, and reference
translation all decide from one analysis. Checking the verdict's field
identity also keeps same-typed sibling events apart (#3575), and the
qualifier logic running against the event drops spurious this./type
qualifiers from raise sites.

mcs 2.x accesses a sibling automatic event's backing field directly
inside custom accessors instead of calling the accessor, so the fixture
expects the resulting Delegate.Combine form there.

Assisted-by: Claude:claude-fable-5:Claude Code
Claude-Session: https://claude.ai/code/session_01Btdypgm8utyxqt1Etn2BDi

2 months ago

Siegfried Pammer

1b9131905d

Fix #3858 : Detect automatic events on the ILAst instead of the C# AST

The syntactic accessor-body patterns in PatternStatementTransform sit
downstream of every settings-dependent transform, so each new compiler
shape or settings combination silently broke recognition: with
AggressiveInlining enabled, static events inline the Delegate.Combine
call into CompareExchange positionally, which none of the four patterns
matched, while call sites were still rewritten to the event name from
metadata alone - producing uncompilable output (CS0079).

Recognition now happens in DoDecompile(IEvent) by structurally matching
the ILAst of the accessors, decompiled with a fixed set of settings the
same way RecordDecompiler analyzes method bodies. This makes detection
independent of the user-visible settings by construction. Events that
are not recognized fall back to the classic path unchanged, including
the existing AST patterns.

mcs 2.x compiles the accessors as a compound assignment, evaluating
'this' once via IL 'dup'; the simple-combine matcher accepts that
stack-slot alias.

Assisted-by: Claude:claude-fable-5:Claude Code

2 months ago

2 Commits (1c010a828eb9b376b3d7f75c4aa3ee8bdd3a52ff)