ILSpy

9163 Commits

24 Branches

90 Tags

71 MiB

Tree: 17b3539a20

Commit Graph

Author	SHA1	Message	Date
Christoph Wille	f302b1fb3e	Lazy-load custom package icons in the NuGet feed dialog The "Open from NuGet feed" chooser rendered every result with the default NuGet logo, even though the feed search already returns each package's own IconUrl - it was fetched into NuGetPackageInfo and then ignored. The list looked like a wall of identical icons, unlike the NuGet gallery. NuGetPackageInfo is an immutable feed DTO bound straight into the ListBox, so it can't raise PropertyChanged for an icon that arrives later. Rather than bolt mutability and an Avalonia image type onto that DTO, introduce a thin per-row view model (NuGetPackageViewModel) that owns an observable Icon defaulting to the logo and swaps in the real icon once downloaded, plus an INuGetIconLoader service that fetches and decodes off the UI thread. Icons are decoded to 64px (rendered at 32) and cached by URL as the in-flight Task so each URL downloads once and concurrent requests share it; the loader is held for the command's lifetime so the cache survives reopening the dialog. A per-search CancellationTokenSource stops a stale result set's downloads from painting onto rows recycled by the next search. Any failure - non-http URL, network error, decode error - collapses to null so a dead icon URL just keeps the default. Also disable horizontal scrolling on the results list. With it enabled (the default), rows measured at unbounded width, so the star column stopped filling the viewport and selecting a row brought the overflow into view - the list jumped sideways and grew a scrollbar. The row layout is meant to fit the width (the description wraps/trims), so horizontal scrolling was never wanted. Assisted-by: Claude:claude-opus-4-8:Claude Code	2 weeks ago

Author

SHA1

Message

Date

Christoph Wille

f302b1fb3e

Lazy-load custom package icons in the NuGet feed dialog

The "Open from NuGet feed" chooser rendered every result with the default
NuGet logo, even though the feed search already returns each package's own
IconUrl - it was fetched into NuGetPackageInfo and then ignored. The list
looked like a wall of identical icons, unlike the NuGet gallery.

NuGetPackageInfo is an immutable feed DTO bound straight into the ListBox, so
it can't raise PropertyChanged for an icon that arrives later. Rather than
bolt mutability and an Avalonia image type onto that DTO, introduce a thin
per-row view model (NuGetPackageViewModel) that owns an observable Icon
defaulting to the logo and swaps in the real icon once downloaded, plus an
INuGetIconLoader service that fetches and decodes off the UI thread. Icons
are decoded to 64px (rendered at 32) and cached by URL as the in-flight Task
so each URL downloads once and concurrent requests share it; the loader is
held for the command's lifetime so the cache survives reopening the dialog.
A per-search CancellationTokenSource stops a stale result set's downloads
from painting onto rows recycled by the next search. Any failure - non-http
URL, network error, decode error - collapses to null so a dead icon URL just
keeps the default.

Also disable horizontal scrolling on the results list. With it enabled
(the default), rows measured at unbounded width, so the star column stopped
filling the viewport and selecting a row brought the overflow into view -
the list jumped sideways and grew a scrollbar. The row layout is meant to
fit the width (the description wraps/trims), so horizontal scrolling was
never wanted.

Assisted-by: Claude:claude-opus-4-8:Claude Code

2 weeks ago

1 Commits (17b3539a20571acdc88a9841cee77fac3954c55b)